Use String.replace(char, char) instead of splitting

This code really wants to do a simple character substitution,
which has an elegant solution. This means we do not end up
compiling the replacement pattern and use a very efficient method.

Change-Id: I8430ecf9216ae49c3fcc58c24c0315f6510204fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorJavaFile.java b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorJavaFile.java
index 4a0fe00dc8721660cc8671d72aafaf302f762551..7ba0e846055070fd39df9ab33dd0e886d254de98 100644 (file)
--- a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorJavaFile.java
+++ b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorJavaFile.java
@@ -213,13 +213,6 @@ public final class GeneratorJavaFile {
             throw new IllegalArgumentException("Package Name cannot be NULL!");
         }
 
-        final String[] subDirNames = packageName.split("\\.");
-        final StringBuilder dirPathBuilder = new StringBuilder();
-        dirPathBuilder.append(subDirNames[0]);
-        for (int i = 1; i < subDirNames.length; ++i) {
-            dirPathBuilder.append(File.separator);
-            dirPathBuilder.append(subDirNames[i]);
-        }
-        return new File(parentDirectory, dirPathBuilder.toString());
+        return new File(parentDirectory, packageName.replace('.', File.separatorChar));
     }
 }