BUG-374: cleanup error messages present in controller startup

This tones down the "BUG" word which may alarm a casual user. These
still indicate run-time problems which should not occur in a
deterministic run-time environment.

Change-Id: I80871ea1999d2a92d6b343d83ddfc784e7e29ecc
Signed-off-by: SahilShah <sahil4.s@tcs.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/LazyGeneratedCodecRegistry.java b/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/LazyGeneratedCodecRegistry.java
index a8488bd34a5e74896cc3dcf79f06bf5bcbd487ad..9f151ded7783917406873dbe0c245d53189704c0 100644 (file)
--- a/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/LazyGeneratedCodecRegistry.java
+++ b/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/LazyGeneratedCodecRegistry.java
@@ -117,7 +117,7 @@ public class LazyGeneratedCodecRegistry implements //
             } catch (InstantiationException e) {
                 LOG.error("Can not instantiate raw augmentation codec {}", object.getSimpleName(), e);
             } catch (IllegalAccessException e) {
-                LOG.debug("BUG: Constructor for {} is not accessible.", object.getSimpleName(), e);
+                LOG.debug("Run-time consistency issue: constructor {} is not available. This indicates either a code generation bug or a misconfiguration of JVM.", object.getSimpleName(), e);
             }
         Class<? extends Augmentable<?>> objectSupertype = getAugmentableArgumentFrom(object);
         if (objectSupertype != null) {
@@ -387,7 +387,7 @@ public class LazyGeneratedCodecRegistry implements //
             ChoiceCaseNode node = (ChoiceCaseNode) SchemaContextUtil.findDataSchemaNode(module, caseNode.getKey());
 
             if (node == null) {
-                LOG.error("YANGTools Bug: SchemaNode for {}, with path {} was not found in context.",
+                LOG.warn("Failed to find YANG SchemaNode for {}, with path {} was not found in context.",
                         typeref.getFullyQualifiedName(), caseNode.getKey());
                 @SuppressWarnings("rawtypes")
                 ChoiceCaseCodecImpl value = new ChoiceCaseCodecImpl();