Deprecate DataObjectReadingUtil

This class is not used anywhere and is a rather heavy user of
reflection. Deprecate it for removal.

JIRA: MDSAL-802
Change-Id: If3f94622b9ae11b8f63f4d93e3ee211d456725f8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/util/DataObjectReadingUtil.java b/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/util/DataObjectReadingUtil.java
index 1bbe219ba9e9da7edd1b18859dc018e906c8d876..1d8f64af7734d05e441a814af3aa286c5aec0e2b 100644 (file)
--- a/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/util/DataObjectReadingUtil.java
+++ b/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/util/DataObjectReadingUtil.java
@@ -10,7 +10,6 @@ package org.opendaylight.mdsal.binding.spec.util;
 import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkState;
 
-import com.google.common.annotations.Beta;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableMap.Builder;
 import java.lang.reflect.InvocationTargetException;
@@ -34,9 +33,8 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.IdentifiableIt
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.Item;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.PathArgument;
 
-@Beta
+@Deprecated(since = "11.0.3", forRemoval = true)
 public final class DataObjectReadingUtil {
-
     private static final DataObjectReadingStrategy REAUSABLE_AUGMENTATION_READING_STRATEGY =
             new AugmentationReadingStrategy();
 
@@ -146,14 +144,14 @@ public final class DataObjectReadingUtil {
             checkArgument(DataContainer.class.isAssignableFrom(childType));
             this.parentType = parentType;
             this.childType = childType;
-            this.getterMethod = resolveGetterMethod(parentType, childType);
+            getterMethod = resolveGetterMethod(parentType, childType);
         }
 
         @SuppressWarnings("unchecked")
         DataObjectReadingStrategy(final Class parentType, final Class childType, final Method getter) {
             this.parentType = parentType;
             this.childType = childType;
-            this.getterMethod = getter;
+            getterMethod = getter;
         }
 
         @SuppressWarnings("unused")

diff --git a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/DataObjectReadingUtilTest.java b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/DataObjectReadingUtilTest.java
index 6b3b70189365d67eb0779e2f8b2854e8dc68bcb2..67bfe172bc564cd844fa8f22f0f7053bfa7b1c87 100644 (file)
--- a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/DataObjectReadingUtilTest.java
+++ b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/DataObjectReadingUtilTest.java
@@ -27,6 +27,7 @@ import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.binding.Identifiable;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 
+@Deprecated(since = "11.0.3", forRemoval = true)
 @RunWith(MockitoJUnitRunner.StrictStubs.class)
 public class DataObjectReadingUtilTest {
     @Mock

diff --git a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/FooChild.java b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/FooChild.java
index c8c655256d1ac4d73f767f7935d268571ff33032..dd5ac3c70b17ad248c6321ee0b39862c5ed5398c 100644 (file)
--- a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/FooChild.java
+++ b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/FooChild.java
@@ -9,6 +9,7 @@ package org.opendaylight.mdsal.binding.spec.util;
 
 import org.opendaylight.yangtools.yang.binding.ChildOf;
 
+@Deprecated(since = "11.0.3", forRemoval = true)
 public interface FooChild extends ChildOf<GroupingFoo> {
 
 }

diff --git a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/GroupingFoo.java b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/GroupingFoo.java
index eb3fb3525623bfa92ee4b00e236311dc4e812e1e..39b494178182ded41cd11f787121b7c3b5520a9e 100644 (file)
--- a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/GroupingFoo.java
+++ b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/GroupingFoo.java
@@ -7,6 +7,7 @@
  */
 package org.opendaylight.mdsal.binding.spec.util;
 
+@Deprecated(since = "11.0.3", forRemoval = true)
 public interface GroupingFoo {
 
 }

diff --git a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/Node.java b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/Node.java
index 06120118b90bca23170c0bbe4cf007b37909d250..c0059a4022b5889b48991a25633c991d0a297864 100644 (file)
--- a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/Node.java
+++ b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/Node.java
@@ -11,6 +11,7 @@ import org.opendaylight.yangtools.yang.binding.ChildOf;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.binding.Identifiable;
 
+@Deprecated(since = "11.0.3", forRemoval = true)
 public interface Node extends DataObject, Identifiable<NodeKey>, ChildOf<Nodes> {
 
 }

diff --git a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/NodeKey.java b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/NodeKey.java
index e0cdc74bc3f9b9301e2d2e45b99e31dc279ad2cc..fb639bd98e9f425fd5a2898d19de344877ec0501 100644 (file)
--- a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/NodeKey.java
+++ b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/NodeKey.java
@@ -10,6 +10,7 @@ package org.opendaylight.mdsal.binding.spec.util;
 import java.io.Serial;
 import org.opendaylight.yangtools.yang.binding.Identifier;
 
+@Deprecated(since = "11.0.3", forRemoval = true)
 public class NodeKey implements Identifier<Node> {
     @Serial
     private static final long serialVersionUID = 1L;

diff --git a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/Nodes.java b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/Nodes.java
index 775bf908199aa21f8de7544be06ec1533365bf73..add3b4cee41c3cf374670df1817647b903c5ec7f 100644 (file)
--- a/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/Nodes.java
+++ b/binding/mdsal-binding-spec-util/src/test/java/org/opendaylight/mdsal/binding/spec/util/Nodes.java
@@ -11,6 +11,7 @@ import org.opendaylight.yangtools.yang.binding.ChildOf;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.binding.DataRoot;
 
+@Deprecated(since = "11.0.3", forRemoval = true)
 public interface Nodes extends ChildOf<DataRoot>, DataObject {
 
     Iterable<?> getNode();