Use instanceof pattern in Identity's equals() 90/102090/3
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 16 Aug 2022 11:47:39 +0000 (13:47 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 16 Aug 2022 13:07:47 +0000 (15:07 +0200)
We can use an implicit cast here, let's just do that to make things a
tad simpler.

Change-Id: Ic2f48c2b8f3fc0e4b5aec0b699cad8edf4c434b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/BaseTemplate.xtend

index 9faa3fd6959b5acd0ed947ee4c70e5291076ef31..41c01a8a37341e2c9ab31008c8e6da15780a9b33 100644 (file)
@@ -316,8 +316,8 @@ abstract class BaseTemplate extends JavaFileTemplate {
 
                 @«override»
                 public boolean equals(final «objectType.importedName» obj) {
-                    return obj == this || obj instanceof «typeName»
-                        && «typeName».class.equals(((«typeName») obj).«BindingMapping.BINDING_CONTRACT_IMPLEMENTED_INTERFACE_NAME»());
+                    return obj == this || obj instanceof «typeName» other
+                        && «typeName».class.equals(other.«BindingMapping.BINDING_CONTRACT_IMPLEMENTED_INTERFACE_NAME»());
                 }
 
                 @«override»