Clean up TypeMemberComment 88/112388/2
authorRobert Varga <robert.varga@pantheon.tech>
Sun, 30 Jun 2024 08:55:32 +0000 (10:55 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Sun, 30 Jun 2024 09:18:33 +0000 (11:18 +0200)
We have a javadoc warning and an opporunity to simplify equals().

Change-Id: I5cf610d44f89f4b97ef272f09444f5104dfa46a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/binding-model-api/src/main/java/org/opendaylight/yangtools/binding/model/api/TypeMemberComment.java

index 9f3f1b45417cb75a0e93725c374082174fdd9558..52bf5b605fa6cade1502bf7f5332e6b9177b2f4e 100644 (file)
@@ -49,9 +49,7 @@ public final class TypeMemberComment implements Immutable {
 
     /**
      * Return the member reference description. This description is passed unmodified, pre-formatted in a single block.
-     * It is expected to look something like the following paragraph:
-     *
-     * <p>
+     * It is expected to look something like the following:
      * <pre>
      *   <code>
      *     A 32-bit bit unsigned word. Individual bits are expected to be interpreted as follows:
@@ -93,14 +91,8 @@ public final class TypeMemberComment implements Immutable {
 
     @Override
     public boolean equals(final Object obj) {
-        if (obj == this) {
-            return true;
-        }
-        if (!(obj instanceof TypeMemberComment)) {
-            return false;
-        }
-        final TypeMemberComment other = (TypeMemberComment) obj;
-        return Objects.equals(contractDescription, other.contractDescription)
+        return obj == this || obj instanceof TypeMemberComment other
+            && Objects.equals(contractDescription, other.contractDescription)
             && Objects.equals(referenceDescription, other.referenceDescription)
             && Objects.equals(typeSignature, other.typeSignature);
     }