Avoid StringBuilder's char constructor

Passing a char to StringBuilder's constructor is interpreted as
setting the initial capacity, not providing the initial content. This
was already accounted for; so this patch removes the char arguments
since they only end up being confusing.

Change-Id: Ic7b1281174e0faec891cb96dd89e0d4aa4ced670
Signed-off-by: Stephen Kitt <skitt@redhat.com>

diff --git a/binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/JavaCodePrettyPrint.java b/binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/JavaCodePrettyPrint.java
index 72eed408221fa00a0cc1521a439a14d89c10129b..d0fb2e844ddb307b4c5cf0d49b3bd06307df76e3 100644 (file)
--- a/binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/JavaCodePrettyPrint.java
+++ b/binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/JavaCodePrettyPrint.java
@@ -214,14 +214,11 @@ public final class JavaCodePrettyPrint {
         if (splittedByNewLine[cur].contains(JDOC_START)) {
             fixedLines.add(new StringBuilder(splittedByNewLine[cur]).append(NEW_LINE).toString());
             for (int next = cur + 1; next < splittedByNewLine.length - 1; next++) {
+                fixedLines.add(
+                    new StringBuilder().append(SPACE).append(splittedByNewLine[next]).append(NEW_LINE).toString());
                 if (splittedByNewLine[next].contains(JDOC_END)) {
-                    fixedLines.add(new StringBuilder(SPACE)
-                            .append(SPACE).append(splittedByNewLine[next]).append(NEW_LINE).toString());
                     cur = next + 1;
                     break;
-                } else {
-                    fixedLines.add(new StringBuilder(SPACE)
-                            .append(SPACE).append(splittedByNewLine[next]).append(NEW_LINE).toString());
                 }
             }
         }

diff --git a/binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/TextTemplateUtil.java b/binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/TextTemplateUtil.java
index e01888305b6ce9d02752c4013d8cb34c27ae7ad8..99652f592a6849d2fee4a47a3f2817ee49d1f8f1 100755 (executable)
--- a/binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/TextTemplateUtil.java
+++ b/binding2/mdsal-binding2-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/javav2/java/api/generator/util/TextTemplateUtil.java
@@ -99,7 +99,7 @@ public final class TextTemplateUtil {
         if (text.isEmpty()) {
             return "";
         }
-        final StringBuilder sb = new StringBuilder(NEW_LINE);
+        final StringBuilder sb = new StringBuilder();
         sb.append("/**");
         sb.append(NEW_LINE);
         for (final String t : NL_SPLITTER.split(text)) {