* @param message Update message containing prefixes in NLRI
* @return MpReachNlri with prefixes from the nlri field
*/
- private MpReachNlri prefixesToMpReach(final Update message) {
+ private static MpReachNlri prefixesToMpReach(final Update message) {
final List<Ipv4Prefixes> prefixes = new ArrayList<>();
for (final Ipv4Prefix p : message.getNlri().getNlri()) {
prefixes.add(new Ipv4PrefixesBuilder().setPrefix(p).build());
* @param message Update message containing withdrawn routes
* @return MpUnreachNlri with prefixes from the withdrawn routes field
*/
- private MpUnreachNlri prefixesToMpUnreach(final Update message) {
+ private static MpUnreachNlri prefixesToMpUnreach(final Update message) {
final List<Ipv4Prefixes> prefixes = new ArrayList<>();
for (final Ipv4Prefix p : message.getWithdrawnRoutes().getWithdrawnRoutes()) {
prefixes.add(new Ipv4PrefixesBuilder().setPrefix(p).build());
return this.asNumber.getValue() > other.asNumber.getValue();
}
- private long toLong(final Ipv4Address from) {
+ private static long toLong(final Ipv4Address from) {
final int i = InetAddresses.coerceToInteger(InetAddresses.forString(from.getValue()));
return UnsignedInts.toLong(i);
}
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
-
import com.google.common.base.Optional;
import com.google.common.collect.Lists;
import com.google.common.io.ByteSource;
}
}
- private ObjectName createRibExtensionsInstance(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
+ private static ObjectName createRibExtensionsInstance(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
final ObjectName nameCreated = transaction.createModule(RIBExtensionsImplModuleFactory.NAME, RIB_EXTENSIONS_INSTANCE_NAME);
transaction.newMXBeanProxy(nameCreated, RIBExtensionsImplModuleMXBean.class);
return nameCreated;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
-
import com.google.common.base.Optional;
import com.google.common.collect.Lists;
import io.netty.channel.Channel;
return transaction.commit();
}
- private ObjectName createPeerRegistry(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
+ private static ObjectName createPeerRegistry(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
return transaction.createModule(StrictBgpPeerRegistryModuleFactory.NAME, "peer-registry");
}
- private ObjectName createDispatcher(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
+ private static ObjectName createDispatcher(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
return transaction.createModule("dispatch", "mock");
}
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.mockito.Mockito.doReturn;
-
import com.google.common.collect.Lists;
import java.util.Collections;
import java.util.List;
return nameCreated;
}
- private ObjectName createPeerRegistry(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
+ private static ObjectName createPeerRegistry(final ConfigTransactionJMXClient transaction) throws InstanceAlreadyExistsException {
return transaction.createModule(StrictBgpPeerRegistryModuleFactory.NAME, "peer-registry");
}
- private BGPDispatcherImplModuleMXBean getBgpDispatcherImplModuleMXBean(final ConfigTransactionJMXClient transaction,
+ private static BGPDispatcherImplModuleMXBean getBgpDispatcherImplModuleMXBean(final ConfigTransactionJMXClient transaction,
final BGPPeerModuleMXBean mxBean) {
final RIBImplModuleMXBean ribProxy = transaction.newMXBeanProxy(mxBean.getRib(), RIBImplModuleMXBean.class);
final ObjectName dispatcherON = ribProxy.getBgpDispatcher();
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;
-
import com.google.common.primitives.UnsignedInteger;
import org.junit.Test;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.AsPath;
return this.dataContBuilder.build();
}
- private DataContainerNodeAttrBuilder<NodeIdentifier, ContainerNode> createContBuilder(final QName qname) {
+ private static DataContainerNodeAttrBuilder<NodeIdentifier, ContainerNode> createContBuilder(final QName qname) {
return ImmutableContainerNodeSchemaAwareBuilder.create().withNodeIdentifier(new NodeIdentifier(qname));
}
- private <T> ImmutableLeafNodeBuilder<T> createValueBuilder(final T value, final QName qname, final String localName) {
+ private static <T> ImmutableLeafNodeBuilder<T> createValueBuilder(final T value, final QName qname, final String localName) {
final ImmutableLeafNodeBuilder<T> valueBuilder = new ImmutableLeafNodeBuilder<>();
valueBuilder.withNodeIdentifier(new NodeIdentifier(QName.create(qname, localName))).withValue(value);
return valueBuilder;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
-
import com.google.common.base.Function;
import com.google.common.base.Optional;
import com.google.common.base.Throwables;
reg.close();
}
- private Collection<byte[]> fixMessages(final Collection<byte[]> bgpMessages) {
+ private static Collection<byte[]> fixMessages(final Collection<byte[]> bgpMessages) {
return Collections2.transform(bgpMessages, new Function<byte[], byte[]>() {
@Nullable
Mockito.doReturn(readFuture).when(readTx).read(Mockito.eq(LogicalDatastoreType.OPERATIONAL), Mockito.any(InstanceIdentifier.class));
}
- private BindingCodecTreeFactory createCodecFactory(final ClassLoadingStrategy str, final SchemaContext ctx) {
+ private static BindingCodecTreeFactory createCodecFactory(final ClassLoadingStrategy str, final SchemaContext ctx) {
final DataObjectSerializerGenerator generator = StreamWriterGenerator.create(JavassistUtils.forClassPool(ClassPool.getDefault()));
final BindingNormalizedNodeCodecRegistry codec = new BindingNormalizedNodeCodecRegistry(generator);
codec.onBindingRuntimeContextUpdated(BindingRuntimeContext.create(str, ctx));
return codec;
}
- private ModuleInfoBackedContext createClassLoadingStrategy() {
+ private static ModuleInfoBackedContext createClassLoadingStrategy() {
final ModuleInfoBackedContext ctx = ModuleInfoBackedContext.create();
try {
ctx.registerModuleInfo(BindingReflections.getModuleInfo(Ipv4Route.class));
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.fail;
-
import java.net.InetSocketAddress;
import java.util.Collections;
import org.junit.Before;
fail("Peer AS number mismatch");
}
- private ReusableBGPPeer getMockSession() {
+ private static ReusableBGPPeer getMockSession() {
final ReusableBGPPeer mock = Mockito.mock(ReusableBGPPeer.class);
Mockito.doNothing().when(mock).releaseConnection();
return mock;
public BGPSessionPreferences getMockPreferences() {
return new BGPSessionPreferences(AS1, 1, new Ipv4Address("0.0.0.1"), Collections.<BgpParameters>emptyList());
}
-}
\ No newline at end of file
+}
Code Review / bgpcep.git / commitdiff