Resolved some sonar issues: Dead store to local variable

DataValidationException - local variables actualValue and expectedValue in method checkListKey
were used only as parameters by throwing IllegalListKeyException, which was thrown when childNode was null.

This check was removed because:

1. it is already performed in call to overloaded checkListKey
2. value is already dereferenced and if it were null a
NullPointerException would have occurred

JSONNormalizedNodeStreamWriter - removed waste calling of anyxmlNode method

BindingToRestRPC - in method invoke added error, which occurs during extracting rpc
output in proxy method, to the rpc errors.

Change-Id: If58bf1e0342f0454600cbd3be1e152c397ce5249
Signed-off-by: Ladislav Borak <lborak@cisco.com>

diff --git a/restconf/restconf-client-impl/src/main/java/org/opendaylight/yangtools/restconf/client/BindingToRestRpc.java b/restconf/restconf-client-impl/src/main/java/org/opendaylight/yangtools/restconf/client/BindingToRestRpc.java
index 40d29da662a56e725d8ad0af79a409ee1a07e6d5..3d089625317497a4c212a1a707fc5ffa453c305d 100644 (file)
--- a/restconf/restconf-client-impl/src/main/java/org/opendaylight/yangtools/restconf/client/BindingToRestRpc.java
+++ b/restconf/restconf-client-impl/src/main/java/org/opendaylight/yangtools/restconf/client/BindingToRestRpc.java
@@ -7,12 +7,14 @@
  */
 package org.opendaylight.yangtools.restconf.client;
 
+import com.google.common.base.Function;
+import com.google.common.base.Optional;
+import com.sun.jersey.api.client.ClientResponse;
 import java.lang.reflect.InvocationHandler;
 import java.lang.reflect.Method;
 import java.lang.reflect.Proxy;
 import java.util.ArrayList;
 import java.util.List;
-
 import org.opendaylight.yangtools.restconf.client.to.RestRpcError;
 import org.opendaylight.yangtools.restconf.client.to.RestRpcResult;
 import org.opendaylight.yangtools.restconf.common.ResourceUri;
@@ -36,10 +38,6 @@ import org.w3c.dom.Document;
 import org.w3c.dom.ls.DOMImplementationLS;
 import org.w3c.dom.ls.LSSerializer;
 
-import com.google.common.base.Function;
-import com.google.common.base.Optional;
-import com.sun.jersey.api.client.ClientResponse;
-
 public class BindingToRestRpc implements InvocationHandler {
 
     private final RestconfClientImpl client;
@@ -92,6 +90,7 @@ public class BindingToRestRpc implements InvocationHandler {
                         } catch (Exception e) {
                             logger.trace("Error while extracting rpc output in proxy method {}",e);
                             RestRpcError error = new RestRpcError(RpcError.ErrorSeverity.ERROR, RpcError.ErrorType.APPLICATION,"Error while extracting rpc output in proxy method.",e);
+                            errors.add(error);
                         }
                         return new RestRpcResult(false,errors);
                     }