Sonar Warning Fix: reused parameter

moved obj Object into updated method
created new Object instead of reusing parameter

Change-Id: I0694a8e45f9c9070dd894c3382e8e39ec13beaf1
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

diff --git a/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/message/PCEPRequestMessageParser.java b/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/message/PCEPRequestMessageParser.java
index 1e2c55293b425a9bab15bc7ccb6ec71f65d349d9..cd24333ce985b41147c0efbef0dc87cba231583c 100644 (file)
--- a/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/message/PCEPRequestMessageParser.java
+++ b/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/message/PCEPRequestMessageParser.java
@@ -253,8 +253,7 @@ public class PCEPRequestMessageParser extends AbstractMessageParser {
 
         State state = State.INIT;
         while (!objects.isEmpty() && state != State.END) {
-            final Object obj = objects.get(0);
-            state = insertObject(state, obj, objects, viObjects, builder, metrics, errors, rp);
+            state = insertObject(state, objects, viObjects, builder, metrics, errors, rp);
             if (!state.equals(State.END)) {
                 objects.remove(0);
             }
@@ -277,16 +276,17 @@ public class PCEPRequestMessageParser extends AbstractMessageParser {
         return new SegmentComputationBuilder().setP2p(builder.build()).build();
     }
 
-    private State insertObject(final State state, Object obj, final List<Object> objects, final List<VendorInformationObject> viObjects, final P2pBuilder builder, final List<Metrics> metrics, final List<Message> errors, final Rp rp) {
+    private State insertObject(final State state, final List<Object> objects, final List<VendorInformationObject> viObjects, final P2pBuilder builder, final List<Metrics> metrics, final List<Message> errors, final Rp rp) {
+        final Object obj = objects.get(0);
         switch (state) {
         case INIT:
             if (obj instanceof Rro) {
                 final ReportedRouteBuilder rrBuilder = new ReportedRouteBuilder();
                 rrBuilder.setRro((Rro) obj);
                 objects.remove(0);
-                obj = objects.get(0);
-                if (obj instanceof Bandwidth) {
-                    rrBuilder.setBandwidth((Bandwidth) obj);
+                final Object nextObj = objects.get(0);
+                if (nextObj instanceof Bandwidth) {
+                    rrBuilder.setBandwidth((Bandwidth) nextObj);
                 }
                 return State.REPORTED_IN;
             }