Fix inefficient String buffering

Instead of using string concatenation before adding to stribuilder, add
the componets directly.

Change-Id: Ibbd9131f1a1ec5df5f32c84e86c140e52c5ec84d
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/LeafRefPath.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/LeafRefPath.java
index 649d911ac3ea88dd79e8fc010bf3da4fb74a7f7e..8f092dfebd321e661fbd9326c81b438d542e6e49 100644 (file)
--- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/LeafRefPath.java
+++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/LeafRefPath.java
@@ -7,7 +7,6 @@
  */
 package org.opendaylight.yangtools.yang.data.impl.leafref;
 
-import org.opendaylight.yangtools.concepts.Immutable;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Iterables;
@@ -16,6 +15,7 @@ import java.util.Iterator;
 import java.util.List;
 import java.util.NoSuchElementException;
 import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
+import org.opendaylight.yangtools.concepts.Immutable;
 
 public abstract class LeafRefPath implements Immutable {
 
@@ -354,7 +354,7 @@ public abstract class LeafRefPath implements Immutable {
         sb.append(isAbsolute() ? "Absolute path:" : "Relative path:");
 
         for (QNameWithPredicate qName : pathFromRoot) {
-            sb.append("/" + qName);
+            sb.append('/').append(qName);
         }
 
         return sb.toString();

diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateBuilder.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateBuilder.java
index 0cdb9dd6627d0c2c95ea6902bac6082b7136ce7a..778a851d72710d5b112d92045e22cb93272a8620 100644 (file)
--- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateBuilder.java
+++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateBuilder.java
@@ -45,7 +45,7 @@ class QNamePredicateBuilder {
     @Override
     public String toString() {
         final StringBuilder sb = new StringBuilder();
-        sb.append("[");
+        sb.append('[');
 
         sb.append(identifier);
         sb.append("=current()");
@@ -54,10 +54,10 @@ class QNamePredicateBuilder {
                 .getPathFromRoot();
 
         for (final QNameWithPredicate qName : pathFromRoot) {
-            sb.append("/" + qName);
+            sb.append('/').append(qName);
         }
 
-        sb.append("]");
+        sb.append(']');
         return sb.toString();
     }
 }

diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateImpl.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateImpl.java
index 6607475acef361a2bb83313a02994fc5219eda6d..4bfb861f2bdb303e386507a9925a3807f7285479 100644 (file)
--- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateImpl.java
+++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateImpl.java
@@ -37,7 +37,7 @@ class QNamePredicateImpl implements Immutable, Serializable,
     @Override
     public String toString() {
         final StringBuilder sb = new StringBuilder();
-        sb.append("[");
+        sb.append('[');
 
         sb.append(identifier);
         sb.append("=current()");
@@ -46,10 +46,10 @@ class QNamePredicateImpl implements Immutable, Serializable,
                 .getPathFromRoot();
 
         for (final QNameWithPredicate qName : pathFromRoot) {
-            sb.append("/" + qName);
+            sb.append('/').append(qName);
         }
 
-        sb.append("]");
+        sb.append(']');
         return sb.toString();
     }
 

diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateBuilder.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateBuilder.java
index 0fe0d443e19047277c210a09bc6b336b7d3c54b4..b1b0666548566fc9029691553da642fc6c653e85 100644 (file)
--- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateBuilder.java
+++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateBuilder.java
@@ -89,9 +89,9 @@ class QNameWithPredicateBuilder {
         final StringBuilder sb = new StringBuilder();
 
         if (moduleQname != null) {
-            sb.append("(" + moduleQname.getNamespace());
-            sb.append("?revision=" + moduleQname.getRevision());
-            sb.append(")");
+            sb.append('(').append(moduleQname.getNamespace());
+            sb.append("?revision=").append(moduleQname.getRevision());
+            sb.append(')');
         }
 
         sb.append(localName);

diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateImpl.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateImpl.java
index 757e3490903fda7525aab65d3a20d82108315306..5b14433266c2e5b0feb0e5be7707884be07d9012 100644 (file)
--- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateImpl.java
+++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateImpl.java
@@ -74,9 +74,9 @@ final class QNameWithPredicateImpl implements Immutable, Serializable,
         final StringBuilder sb = new StringBuilder();
 
         if (moduleQname != null) {
-            sb.append("(" + moduleQname.getNamespace());
-            sb.append("?revision=" + moduleQname.getRevision());
-            sb.append(")");
+            sb.append('(').append(moduleQname.getNamespace());
+            sb.append("?revision=").append(moduleQname.getRevision());
+            sb.append(')');
         }
 
         sb.append(localName);