Optimize IpConversionUtil.extractIpv4Address() 37/80537/2
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 22 Feb 2019 11:04:08 +0000 (12:04 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 7 Mar 2019 10:40:24 +0000 (11:40 +0100)
Rather than instantiating Ipv4Address ourselves, use IetfInetUtil
just as we do in the IPv6 case.

JIRA: OPNFLWPLUG-1067
Change-Id: Ie6a4b0ffe57adef2d884f1b0a3987b31f9c0795b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/common/IpConversionUtil.java

index af4849ed1b40eb00cbb889aaba25fac6a57e7886..02134cf6e7d1fb73785fa42646f9f3849ecaa173 100644 (file)
@@ -625,8 +625,7 @@ public final class IpConversionUtil {
     }
 
     public static Ipv4Address extractIpv4Address(final Ipv4Prefix ipv4Prefix) {
-        Iterator<String> addressParts = PREFIX_SPLITTER.split(ipv4Prefix.getValue()).iterator();
-        return new Ipv4Address(addressParts.next());
+        return IetfInetUtil.INSTANCE.ipv4AddressFrom(ipv4Prefix);
     }
 
     public static DottedQuad extractIpv4AddressMask(final Ipv4Prefix ipv4Prefix) {