Fix checkstyle problems not detected by the current version

This change is required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle

Change-Id: I4fac148d693e5de5c96485243a5469a22f1a8237
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

diff --git a/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/CommandArgHandlerRegistry.java b/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/CommandArgHandlerRegistry.java
index 3319b9fda4699355b93a11f8085721cb72b5c0c4..27e3ca8976147589ae2daa101cc35612ac2d35b9 100644 (file)
--- a/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/CommandArgHandlerRegistry.java
+++ b/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/CommandArgHandlerRegistry.java
@@ -94,8 +94,8 @@ public class CommandArgHandlerRegistry {
      */
     private interface ReaderProvider {
         Reader<? extends DataSchemaNode> provide(ConsoleIO consoleIO,
-                final CommandArgHandlerRegistry commandArgHandlerRegistry,
-                final SchemaContextRegistry schemaContextRegistry);
+                CommandArgHandlerRegistry commandArgHandlerRegistry,
+                SchemaContextRegistry schemaContextRegistry);
     }
 
     private static final class FilterReaderProvider implements ReaderProvider {
@@ -141,7 +141,7 @@ public class CommandArgHandlerRegistry {
      */
     private interface WriterProvider {
         Writer<DataSchemaNode> provide(ConsoleIO consoleIO, SchemaContext schema,
-                final CommandArgHandlerRegistry commandArgHandlerRegistry);
+                CommandArgHandlerRegistry commandArgHandlerRegistry);
     }
 
     private class DataWriterProvider implements WriterProvider {

diff --git a/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/reader/impl/BasicDataHolderReader.java b/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/reader/impl/BasicDataHolderReader.java
index e5447ce5a87af1b7e8d5b08dc6845ea3830d030b..71cf6afc2f37a0835463eb0a0b386492715c7d61 100644 (file)
--- a/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/reader/impl/BasicDataHolderReader.java
+++ b/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/reader/impl/BasicDataHolderReader.java
@@ -125,7 +125,7 @@ public abstract class BasicDataHolderReader<T extends DataSchemaNode> extends Ab
         return Collections.<NormalizedNode<?, ?>>singletonList(newNode);
     }
 
-    protected abstract TypeDefinition<?> getType(final T schemaNode);
+    protected abstract TypeDefinition<?> getType(T schemaNode);
 
     protected final DataHolderCompleter getBaseCompleter(final T schemaNode) {
         final TypeDefinition<?> type = getType(schemaNode);

diff --git a/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/writer/impl/AbstractWriter.java b/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/writer/impl/AbstractWriter.java
index 5ec1f9817c85b70b5f5949b90b7e045591c51fb0..45546d15499a84c1a30c0022867bbd9d97807be0 100644 (file)
--- a/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/writer/impl/AbstractWriter.java
+++ b/netconf/tools/netconf-cli/src/main/java/org/opendaylight/netconf/cli/writer/impl/AbstractWriter.java
@@ -32,6 +32,6 @@ public abstract class AbstractWriter<T extends DataSchemaNode> implements Writer
         }
     }
 
-    protected abstract void writeInner(final T dataSchemaNode, final List<NormalizedNode<?, ?>> dataNodes)
+    protected abstract void writeInner(T dataSchemaNode, List<NormalizedNode<?, ?>> dataNodes)
         throws IOException, WriteException;
 }