Fix potential ByteBuf leak in bgp-inet

We are using ByteBuf.readBytes() to actually skip over some content,
use ByteBuf.skipBytes() instead.

JIRA: BGPCEP-973
Change-Id: Ia33e199d63ea05fe4d3383384970f7aaf4441757
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/bgp/extensions/inet/src/main/java/org/opendaylight/protocol/bgp/inet/codec/Ipv6BgpPrefixSidParser.java b/bgp/extensions/inet/src/main/java/org/opendaylight/protocol/bgp/inet/codec/Ipv6BgpPrefixSidParser.java
index 1309aca80fe27c81152c65903f1311aa662f1af0..9891a9a0e48662c567bd8786ea8b6ece3c61cc85 100644 (file)
--- a/bgp/extensions/inet/src/main/java/org/opendaylight/protocol/bgp/inet/codec/Ipv6BgpPrefixSidParser.java
+++ b/bgp/extensions/inet/src/main/java/org/opendaylight/protocol/bgp/inet/codec/Ipv6BgpPrefixSidParser.java
@@ -35,7 +35,7 @@ public final class Ipv6BgpPrefixSidParser implements BgpPrefixSidTlvParser, BgpP
 
     @Override
     public Ipv6SidTlv parseBgpPrefixSidTlv(final ByteBuf buffer) {
-        buffer.readBytes(RESERVED);
+        buffer.skipBytes(RESERVED);
         final boolean canProcessIpv6Header = BitArray.valueOf(buffer, FLAGS_SIZE).get(PROCESS_IPV6_HEADER_FLAG);
         return new Ipv6SidTlvBuilder().setProcessIpv6HeadAbility(canProcessIpv6Header).build();
     }