Fix device data update failure after successful connection 33/106833/7
authorSangwook Ha <sangwook.ha@verizon.com>
Wed, 5 Jul 2023 21:59:55 +0000 (14:59 -0700)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 10 Jul 2023 12:25:55 +0000 (14:25 +0200)
NetconfNodeHandler does not propagate successful connection to its
delegate (RemoteDeviceHandler). Make sure that it's notified so that
the device data is updated accordingly.

JIRA: NETCONF-1074
Change-Id: Id32996c11d0a63812d439ad386472c059255cf4e
Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
apps/netconf-topology/src/main/java/org/opendaylight/netconf/topology/spi/NetconfNodeHandler.java

index d768f5842a529b7961e09a38935e7cce240e7c07..dd4c859feb2b6df267da96dc841a49bd4cd3d74e 100644 (file)
@@ -193,9 +193,12 @@ public final class NetconfNodeHandler extends AbstractRegistration implements Re
     }
 
     @Override
-    public synchronized void onDeviceConnected(final NetconfDeviceSchema deviceSchema,
+    public void onDeviceConnected(final NetconfDeviceSchema deviceSchema,
             final NetconfSessionPreferences sessionPreferences, final RemoteDeviceServices services) {
-        attempts = 0;
+        synchronized (this) {
+            attempts = 0;
+        }
+        delegate.onDeviceConnected(deviceSchema, sessionPreferences, services);
     }
 
     @Override