Fix odlparent 3 Checkstyle issues

Change-Id: Ida69b8e8c3a3e4964887230d645e8da0d153c4f7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

diff --git a/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/serializer/address/ServicePathSerializer.java b/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/serializer/address/ServicePathSerializer.java
index fdd0f2f5d35ac873e7b026a3d4da075070d93f3b..175b23c410b2f8740eff942d7ba35dda43c94dd9 100644 (file)
--- a/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/serializer/address/ServicePathSerializer.java
+++ b/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/serializer/address/ServicePathSerializer.java
@@ -8,7 +8,6 @@
 package org.opendaylight.lispflowmapping.lisp.serializer.address;
 
 import java.nio.ByteBuffer;
-
 import org.opendaylight.lispflowmapping.lisp.type.LispCanonicalAddressFormatEnum;
 import org.opendaylight.lispflowmapping.lisp.util.ByteUtil;
 import org.opendaylight.lispflowmapping.lisp.util.NumberUtil;
@@ -28,7 +27,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.proto.rev151105.ei
  * @author Lorand Jakab
  *
  */
-public class ServicePathSerializer extends LcafSerializer {
+public final class ServicePathSerializer extends LcafSerializer {
 
     private static final ServicePathSerializer INSTANCE = new ServicePathSerializer();
 

diff --git a/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/util/Constants.java b/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/util/Constants.java
index 0ade1a3c018734954b52ed44cc3f5a3b2096cdc7..6c360a0690d75b91f85db78a0deb070c83fe0ec3 100644 (file)
--- a/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/util/Constants.java
+++ b/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/util/Constants.java
@@ -13,8 +13,8 @@ package org.opendaylight.lispflowmapping.lisp.util;
  * @author Lorand Jakab
  *
  */
-public final class Constants {
-    public static final int INET6_ADDRSTRLEN = 46;
+public interface Constants {
+    int INET6_ADDRSTRLEN = 46;
 
     // TODO Move constants from other files that don't clearly belong there into this file.
 }

diff --git a/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/util/Stringifier.java b/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/util/Stringifier.java
index 4b8e92067cf24f19cb6c06baf1646751b76c37f9..5ff968473ee8862a2c671d82679ec499de9b10d6 100644 (file)
--- a/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/util/Stringifier.java
+++ b/mappingservice/lisp-proto/src/main/java/org/opendaylight/lispflowmapping/lisp/util/Stringifier.java
@@ -18,9 +18,12 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.proto.rev151105.ma
  * @author Lorand Jakab
  *
  */
-public class Stringifier {
+public final class Stringifier {
     private static final String NEW_LINE = System.lineSeparator();
 
+    private Stringifier() {
+    }
+
     public static String getSpacesAsString(int length) {
         return new String(new char[length]).replace("\0", " ");
     }