Do no subclass HashMap 84/92684/1
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 25 Sep 2020 07:33:43 +0000 (09:33 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 25 Sep 2020 07:33:43 +0000 (09:33 +0200)
Eclipse is correctly pointing out we are creating a serializable
subclass without assigning a version to it. Rather than doing that,
use a simple initializer through an intermediate map.

Change-Id: I83d5a05c138bf7ee664612daf81f721fe30435f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/OpenflowDiagStatusProviderImpl.java

index 9c877711f5b6aedbe6c5edab84afcdf98de6bcee..21349f1656997b9fa1ccf36a6e5762df82d7894a 100644 (file)
@@ -34,12 +34,10 @@ public class OpenflowDiagStatusProviderImpl implements OpenflowDiagStatusProvide
     private static final String OPENFLOW_SERVICE_AGGREGATE = OPENFLOW_SERVICE;
 
     private final DiagStatusService diagStatusService;
-    private volatile Map<String, ServiceState> statusMap = new HashMap<String, ServiceState>() {{
-            put(OPENFLOW_SERVICE, STARTING);
-            put(OPENFLOW_SERVER_6633, STARTING);
-            put(OPENFLOW_SERVER_6653, STARTING);
-        }
-    };
+    private volatile Map<String, ServiceState> statusMap = new HashMap<>(Map.of(
+        OPENFLOW_SERVICE, STARTING,
+        OPENFLOW_SERVER_6633, STARTING,
+        OPENFLOW_SERVER_6653, STARTING));
 
     @Inject
     public OpenflowDiagStatusProviderImpl(final @Reference DiagStatusService diagStatusService) {