Lower log level for non errors 81/63581/2
authorSam Hague <shague@redhat.com>
Tue, 26 Sep 2017 21:51:28 +0000 (17:51 -0400)
committerSam Hague <shague@redhat.com>
Wed, 27 Sep 2017 23:31:41 +0000 (23:31 +0000)
Change-Id: I7108bb53268bf5d2513b44117d9755cf62c5aaac
Signed-off-by: Sam Hague <shague@redhat.com>
vpnservice/bgpmanager/bgpmanager-impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpConfigurationManager.java
vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java
vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronFloatingToFixedIpMappingChangeListener.java
vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronPortChangeListener.java
vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java
vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java
vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java
vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/utilities/InterfaceUtils.java

index c08bc3916dd002942b2655d1cf3f1ef7ef821775..0ad7809e812db855e51f90e9fe4427bc171678b4 100755 (executable)
@@ -482,7 +482,7 @@ public class BgpConfigurationManager {
             synchronized (BgpConfigurationManager.this) {
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process add for asNum {}; {}", YANG_OBJ, val.getLocalAs(),
+                    LOG.debug("{} Unable to process add for asNum {}; {}", YANG_OBJ, val.getLocalAs(),
                             BgpRouterException.BGP_ERR_NOT_INITED, ADD_WARN);
                     return;
                 }
@@ -530,7 +530,7 @@ public class BgpConfigurationManager {
                 long asNum = val.getLocalAs();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process remove for asNum {}; {}", YANG_OBJ, asNum,
+                    LOG.debug("{} Unable to process remove for asNum {}; {}", YANG_OBJ, asNum,
                             BgpRouterException.BGP_ERR_NOT_INITED, DEL_WARN);
                     return;
                 }
@@ -764,7 +764,7 @@ public class BgpConfigurationManager {
                 final String md5Secret = extractMd5Secret(val);
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process add for peer {} as {}; {}", YANG_OBJ, peerIp, as,
+                    LOG.debug("{} Unable to process add for peer {} as {}; {}", YANG_OBJ, peerIp, as,
                             BgpRouterException.BGP_ERR_NOT_INITED, ADD_WARN);
                     return;
                 }
@@ -798,7 +798,7 @@ public class BgpConfigurationManager {
                 String peerIp = val.getAddress().getValue();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process remove for peer {}; {}", YANG_OBJ, peerIp,
+                    LOG.debug("{} Unable to process remove for peer {}; {}", YANG_OBJ, peerIp,
                             BgpRouterException.BGP_ERR_NOT_INITED, DEL_WARN);
                     return;
                 }
@@ -843,7 +843,7 @@ public class BgpConfigurationManager {
                 String peerIp = val.getPeerIp().getValue();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process add for peer {}; {}", YANG_OBJ, peerIp,
+                    LOG.debug("{} Unable to process add for peer {}; {}", YANG_OBJ, peerIp,
                             BgpRouterException.BGP_ERR_NOT_INITED, ADD_WARN);
                     return;
                 }
@@ -875,7 +875,7 @@ public class BgpConfigurationManager {
                 String peerIp = val.getPeerIp().getValue();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process remove for peer {}; {}", YANG_OBJ, peerIp,
+                    LOG.debug("{} Unable to process remove for peer {}; {}", YANG_OBJ, peerIp,
                             BgpRouterException.BGP_ERR_NOT_INITED, DEL_WARN);
                     return;
                 }
@@ -917,7 +917,7 @@ public class BgpConfigurationManager {
                 String peerIp = val.getPeerIp().getValue();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process add for peer {}; {}", YANG_OBJ, peerIp,
+                    LOG.debug("{} Unable to process add for peer {}; {}", YANG_OBJ, peerIp,
                             BgpRouterException.BGP_ERR_NOT_INITED, ADD_WARN);
                     return;
                 }
@@ -949,7 +949,7 @@ public class BgpConfigurationManager {
                 String peerIp = val.getPeerIp().getValue();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process remove for peer {}; {}", YANG_OBJ, peerIp,
+                    LOG.debug("{} Unable to process remove for peer {}; {}", YANG_OBJ, peerIp,
                             BgpRouterException.BGP_ERR_NOT_INITED, DEL_WARN);
                     return;
                 }
@@ -991,7 +991,7 @@ public class BgpConfigurationManager {
                 String peerIp = val.getPeerIp().getValue();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process add for peer {}; {}", YANG_OBJ, peerIp,
+                    LOG.debug("{} Unable to process add for peer {}; {}", YANG_OBJ, peerIp,
                             BgpRouterException.BGP_ERR_NOT_INITED, ADD_WARN);
                     return;
                 }
@@ -1025,7 +1025,7 @@ public class BgpConfigurationManager {
                 String peerIp = val.getPeerIp().getValue();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process remove for peer {}; {}", YANG_OBJ, peerIp,
+                    LOG.debug("{} Unable to process remove for peer {}; {}", YANG_OBJ, peerIp,
                             BgpRouterException.BGP_ERR_NOT_INITED, DEL_WARN);
                     return;
                 }
@@ -1076,7 +1076,7 @@ public class BgpConfigurationManager {
                 String nh = val.getNexthop().getValue();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process add for rd {} prefix {} nexthop {}; {}", YANG_OBJ, rd, pfxlen, nh,
+                    LOG.debug("{} Unable to process add for rd {} prefix {} nexthop {}; {}", YANG_OBJ, rd, pfxlen, nh,
                             BgpRouterException.BGP_ERR_NOT_INITED, ADD_WARN);
                     return;
                 }
@@ -1120,7 +1120,7 @@ public class BgpConfigurationManager {
                 String pfxlen = val.getPrefixLen();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process remove for rd {} prefix {}; {}", YANG_OBJ, rd, pfxlen,
+                    LOG.debug("{} Unable to process remove for rd {} prefix {}; {}", YANG_OBJ, rd, pfxlen,
                             BgpRouterException.BGP_ERR_NOT_INITED, DEL_WARN);
                     return;
                 }
@@ -1203,7 +1203,7 @@ public class BgpConfigurationManager {
                 String rd = vrfs.getRd();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process add for rd {}; {}", YANG_OBJ, rd,
+                    LOG.debug("{} Unable to process add for rd {}; {}", YANG_OBJ, rd,
                             BgpRouterException.BGP_ERR_NOT_INITED, ADD_WARN);
                     return;
                 }
@@ -1261,7 +1261,7 @@ public class BgpConfigurationManager {
                 String rd = val.getRd();
                 BgpRouter br = getClient(YANG_OBJ);
                 if (br == null) {
-                    LOG.error("{} Unable to process remove for rd {}; {}", YANG_OBJ, rd,
+                    LOG.debug("{} Unable to process remove for rd {}; {}", YANG_OBJ, rd,
                             BgpRouterException.BGP_ERR_NOT_INITED, DEL_WARN);
                     return;
                 }
@@ -1322,7 +1322,7 @@ public class BgpConfigurationManager {
             String rd = newval.getRd();
             BgpRouter br = getClient(YANG_OBJ);
             if (br == null) {
-                LOG.error("{} Unable to process add for rd {}; {}", YANG_OBJ, rd,
+                LOG.debug("{} Unable to process add for rd {}; {}", YANG_OBJ, rd,
                         BgpRouterException.BGP_ERR_NOT_INITED, ADD_WARN);
                 return;
             }
@@ -1377,7 +1377,7 @@ public class BgpConfigurationManager {
 
         @Override
         protected synchronized void add(InstanceIdentifier<Bgp> iid, Bgp val) {
-            LOG.error("received add Bgp config");
+            LOG.debug("received add Bgp config");
 
             try {
                 initer.await();
index 6187884d3fb66f4a91b1f496da0702814cbdbd9a..155e499053321b3b211a7d6a7f61b57a73e5ba01 100644 (file)
@@ -406,7 +406,7 @@ public class NatUtil {
                 return networkId.getValue();
             }
         }
-        LOG.error("getAssociatedExternalNetwork : External Network missing for routerid : {}", routerId);
+        LOG.info("getAssociatedExternalNetwork : External Network missing for routerid : {}", routerId);
         return null;
     }
 
index 1e96e9e9ef6358c84dece51d0837f229e3bf3ff7..42a44d61ac5bcc784f7f576f81646b4878e08387 100644 (file)
@@ -231,7 +231,7 @@ public class NeutronFloatingToFixedIpMappingChangeListener extends AsyncDataTree
                 }
                 LOG.debug("Deletion from FloatingIpInfo DS successful for fixedIp {} ", fixedIpAddress);
             } else {
-                LOG.error("routerPorts for router {} - fixedIp {} not found", routerName, fixedIpAddress);
+                LOG.warn("routerPorts for router {} - fixedIp {} not found", routerName, fixedIpAddress);
             }
         } catch (Exception e) {
             LOG.error("Failed to delete internal-to-external-port-map from FloatingIpInfo DS for fixed Ip {}",
index 7d0400341bc4ec4c663884310c3cba1b303947ab..277ae145c4a78761ae5557e107fcabd9cd884f30 100644 (file)
@@ -453,7 +453,7 @@ public class NeutronPortChangeListener extends AsyncDataTreeChangeListenerBase<P
             return;
         }
         if (portupdateIps == null || portupdateIps.isEmpty()) {
-            LOG.error("Ignoring portUpdate (fixed_ip removal) for port {} as this case is handled "
+            LOG.info("Ignoring portUpdate (fixed_ip removal) for port {} as this case is handled "
                       + "during subnet deletion event.", portupdate.getUuid().getValue());
             return;
         }
index c4908a56ed1da4d5a4984f08f234bbcb888aafa9..2059c5d23d20ac8a0b8a1051378bb0967f5be114 100644 (file)
@@ -435,7 +435,7 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even
                     SingleTransactionDataBroker.syncWrite(dataBroker, LogicalDatastoreType.CONFIGURATION, id,
                             subnetmap);
                 } else {
-                    LOG.error("Trying to remove port from non-existing subnetmap node {}", subnetId.getValue());
+                    LOG.info("Trying to remove port from non-existing subnetmap node {}", subnetId.getValue());
                 }
             }
         } catch (ReadFailedException | TransactionCommitFailedException e) {
index 21d8153cd02f24eff1f968136062741c37c693dc..6f222a604a053a5855af808208df09476477f8ef 100644 (file)
@@ -483,7 +483,7 @@ public class VpnFootprintService implements IVpnFootprintService {
          */
         @Override
         public void onFailure(Throwable throwable) {
-            log.error("onFailure: Failed to establish/clear footprint for vpn {} rd {} on dpn {} ", vpnName, rd, dpnId,
+            log.info("onFailure: Failed to establish/clear footprint for vpn {} rd {} on dpn {} ", vpnName, rd, dpnId,
                     throwable);
         }
     }
index bfe97596860bcb63fb65b112ef397b456a9c74b8..b96e0f5acd5ce01dc741a5f7d160238227d2409d 100755 (executable)
@@ -198,7 +198,7 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
         if (canHandleNewVpnInterface(identifier, vpnInterface)) {
             addVpnInterface(identifier, vpnInterface, null, null);
         } else {
-            LOG.error("add: VpnInstance {} for vpnInterface {} not ready, holding on ",
+            LOG.warn("add: VpnInstance {} for vpnInterface {} not ready, holding on ",
                     vpnInterface.getVpnInstanceName(), vpnInterface.getName());
         }
     }
@@ -316,7 +316,7 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
                     interfaceName, dpId, vpnName);
             long vpnId = VpnUtil.getVpnId(dataBroker, vpnName);
             if (vpnId == VpnConstants.INVALID_ID) {
-                LOG.error("processVpnInterfaceUp: VpnInstance to VPNId mapping not available for VpnName {}"
+                LOG.warn("processVpnInterfaceUp: VpnInstance to VPNId mapping not available for VpnName {}"
                         + " processing vpninterface {} on dpn {}, bailing out now.", vpnName, interfaceName,
                         dpId);
                 return;
@@ -334,7 +334,7 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
                     // However, if the primary VRF Entry for this VPNInterface exists, please continue bailing out !
                     List<Adjacency> adjs = VpnUtil.getAdjacenciesForVpnInterfaceFromConfig(dataBroker, interfaceName);
                     if (adjs == null) {
-                        LOG.error("processVpnInterfaceUp: VPN Interface {} on dpn {} for vpn {} failed as adjacencies"
+                        LOG.warn("processVpnInterfaceUp: VPN Interface {} on dpn {} for vpn {} failed as adjacencies"
                                 + " for this vpn interface could not be obtained", interfaceName, dpId,
                                 vpnName);
                         return;
@@ -346,7 +346,7 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
                         }
                     }
                     if (primaryInterfaceIp == null) {
-                        LOG.error("processVpnInterfaceUp: VPN Interface {} addition on dpn {} for vpn {} failed"
+                        LOG.warn("processVpnInterfaceUp: VPN Interface {} addition on dpn {} for vpn {} failed"
                                 + " as primary adjacency for this vpn interface could not be obtained", interfaceName,
                                 dpId, vpnName);
                         return;
@@ -354,13 +354,13 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
                     // Get the rd of the vpn instance
                     VrfEntry vrf = VpnUtil.getVrfEntry(dataBroker, primaryRd, primaryInterfaceIp);
                     if (vrf != null) {
-                        LOG.error("processVpnInterfaceUp: VPN Interface {} on dpn {} for vpn {} already provisioned ,"
+                        LOG.warn("processVpnInterfaceUp: VPN Interface {} on dpn {} for vpn {} already provisioned ,"
                                 + " bailing out from here.", interfaceName, dpId, vpnName);
                         return;
                     }
                     waitForVpnInterfaceOpRemoval = true;
                 } else {
-                    LOG.error("processVpnInterfaceUp: vpn interface {} to go to configured vpn {} on dpn {},"
+                    LOG.warn("processVpnInterfaceUp: vpn interface {} to go to configured vpn {} on dpn {},"
                             + " but in operational vpn {}", interfaceName, vpnName, dpId, opVpnName);
                 }
             }
@@ -400,7 +400,7 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
 
             opVpnInterface = VpnUtil.getOperationalVpnInterface(dataBroker, interfaceName);
             if (opVpnInterface != null) {
-                LOG.error("processVpnInterfaceUp: VPN Interface {} removal on dpn {} for vpn {}"
+                LOG.warn("processVpnInterfaceUp: VPN Interface {} removal on dpn {} for vpn {}"
                         + " by FIB did not complete on time," + " bailing addition ...", interfaceName,
                         dpId, vpnName);
                 return;
@@ -637,7 +637,7 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
         try {
             nextHopIp = InterfaceUtils.getEndpointIpAddressForDPN(dataBroker, dpnId);
         } catch (Exception e) {
-            LOG.error("processVpnInterfaceAdjacencies: Unable to retrieve enpoint ip address for "
+            LOG.error("processVpnInterfaceAdjacencies: Unable to retrieve endpoint ip address for "
                     + "dpnId {} for vpnInterface {} vpnName {}", dpnId, interfaceName, vpnName);
         }
         List<String> nhList = new ArrayList<>();
@@ -693,14 +693,16 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
                             arpResponderHandler.addArpResponderFlow(dpnId, lportTag, vpnName, vpnId, interfaceName,
                                     subnetId, gatewayIp.get(), gwMac.get());
                         } else {
-                            LOG.error("Gateway MAC for subnet ID {} could not be obtained, cannot create "
-                                            + "ARP responder flow for interface name {}, vpnName {}, gwIp {}",
-                                    interfaceName, vpnName, gatewayIp.get());
+                            LOG.error("processVpnInterfaceAdjacencies: Gateway MAC for subnet ID {} could not be "
+                                + "obtained, cannot create ARP responder flow for interface name {}, vpnName {}, "
+                                + "gwIp {}",
+                                interfaceName, vpnName, gatewayIp.get());
                         }
                     }
                 } else {
-                    LOG.warn("Gateway IP for subnet ID {} could not be obtained, cannot create ARP responder flow "
-                            + "for interface name {}, vpnName {}", subnetId, interfaceName, vpnName);
+                    LOG.warn("processVpnInterfaceAdjacencies: Gateway IP for subnet ID {} could not be obtained, "
+                        + "cannot create ARP responder flow for interface name {}, vpnName {}",
+                        subnetId, interfaceName, vpnName);
                 }
                 LOG.info("processVpnInterfaceAdjacencies: Added prefix {} to interface {} with nextHops {} on dpn {}"
                         + " for vpn {}", prefix, interfaceName, nhList, dpnId, vpnName);
@@ -714,9 +716,10 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
                             prefix, vpnName, nextHop.getNextHopIpList().get(0), dpnId, writeOperTxn);
                     if (rdToAllocate.isPresent()) {
                         rd = rdToAllocate.get();
-                        LOG.info("The rd {} is allocated for the extraroute {}", rd, prefix);
+                        LOG.info("processVpnInterfaceAdjacencies: The rd {} is allocated for the extraroute {}",
+                            rd, prefix);
                     } else {
-                        LOG.error("No rds to allocate extraroute {}", prefix);
+                        LOG.error("processVpnInterfaceAdjacencies: No rds to allocate extraroute {}", prefix);
                         continue;
                     }
                 }
@@ -737,7 +740,8 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
             try {
                 operationalAdjacency = registeredPopulator.createOperationalAdjacency(input);
             } catch (NullPointerException e) {
-                LOG.error(e.getMessage());
+                LOG.error("processVpnInterfaceAdjacencies: failed to create operational adjacency: input: {}, {}",
+                    input, e.getMessage());
                 return;
             }
             if (nextHop.getAdjacencyType() != AdjacencyType.PrimaryAdjacency) {
@@ -1472,8 +1476,8 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
                 try {
                     operFuture.get();
                 } catch (ExecutionException e) {
-                    LOG.error("Exception encountered while submitting operational future for update"
-                            + " VpnInterface {}: {}", vpnInterfaceName, e);
+                    LOG.error("update: Exception encountered while submitting operational future for update"
+                            + " VpnInterface {}", vpnInterfaceName, e);
                     return null;
                 }
                 List<ListenableFuture<Void>> futures = new ArrayList<>();
index 5a6023d0ac7cea4537237367fc548658d48d73f5..5c8bc71e945c8728756f3a4a6dd39b66a3b70675 100644 (file)
@@ -62,7 +62,7 @@ public class InterfaceUtils {
             if (dpIdResult.isSuccessful()) {
                 nodeId = dpIdResult.getResult().getDpid();
             } else {
-                LOG.error("getDpnForInterface: Could not retrieve DPN Id for interface {}", ifName);
+                LOG.info("getDpnForInterface: Could not retrieve DPN Id for interface {}", ifName);
             }
         } catch (NullPointerException | InterruptedException | ExecutionException e) {
             LOG.error("getDpnForInterface: Exception when getting dpn for interface {}", ifName, e);