Fix checkstyle paren and brace whitespace warnings. 97/60297/1
authorDonald Hunter <donaldh@cisco.com>
Thu, 13 Jul 2017 14:55:09 +0000 (15:55 +0100)
committerDonald Hunter <donaldh@cisco.com>
Thu, 13 Jul 2017 16:08:25 +0000 (17:08 +0100)
Change-Id: I223551e4a2592ca6887601540ad2bf06c17591e8
Signed-off-by: Donald Hunter <donaldh@cisco.com>
54 files changed:
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/TopologyDataHandler.java
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/common/helper/BandwidthProfileComposition.java
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/common/helper/BandwidthProfileHelper.java
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/common/helper/InterfaceHelper.java
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/common/util/LoopbackUtils.java
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/common/util/MtuUtils.java
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/l2vpn/activator/AbstractL2vpnActivator.java
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/l2vpn/activator/L2vpnP2pConnectActivator.java
cisco-xr-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/l2vpn/driver/XrDriverBuilder.java
cisco-xr-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/common/helper/BandwidthProfileHelperTest.java
cisco-xr-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/common/util/LoopbackUtilsTest.java
cisco-xr-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/l2vpn/activator/L2vpnLocalConnectionActivatorTest.java
cisco-xr-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/l2vpn/activator/L2vpnP2pConnectionActivatorTest.java
cisco-xr-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/cisco/xr/l2vpn/activator/L2vpnTestUtils.java
cli/src/test/java/org/opendaylight/unimgr/cli/UnimgrConsoleProviderTest.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/common/NrpDao.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/common/ResourceNotAvailableException.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/common/ServicePort.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/impl/AbstractNodeHandler.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/impl/ActivationTransaction.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/impl/NrpInitializer.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/impl/connectivityservice/DeleteConnectivityAction.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/impl/decomposer/DecompositionAction.java
impl/src/main/java/org/opendaylight/unimgr/mef/nrp/impl/ext/UnimgrExtServiceImpl.java
impl/src/main/java/org/opendaylight/unimgr/utils/CapabilitiesService.java
impl/src/main/java/org/opendaylight/unimgr/utils/NullAwareDatastoreGetter.java
impl/src/main/java/org/opendaylight/unimgr/utils/SipHandler.java
impl/src/test/java/org/opendaylight/unimgr/command/EvcAddCommandTest.java
impl/src/test/java/org/opendaylight/unimgr/command/EvcRemoveCommandTest.java
impl/src/test/java/org/opendaylight/unimgr/command/EvcUpdateCommandTest.java
impl/src/test/java/org/opendaylight/unimgr/command/UniAddCommandTest.java
impl/src/test/java/org/opendaylight/unimgr/command/UniRemoveCommandTest.java
impl/src/test/java/org/opendaylight/unimgr/command/UniUpdateCommandTest.java
impl/src/test/java/org/opendaylight/unimgr/mef/nrp/impl/AbstractNodeHandlerTest.java
impl/src/test/java/org/opendaylight/unimgr/mef/nrp/impl/AbstractTestWithTopo.java
impl/src/test/java/org/opendaylight/unimgr/mef/nrp/impl/connectivityservice/TapiConnectivityServiceInplIntTest.java
impl/src/test/java/org/opendaylight/unimgr/mef/nrp/impl/ext/UnimgrExtServiceImplTest.java
impl/src/test/java/org/opendaylight/unimgr/utils/NodeTestUtils.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/activator/OvsActivatorHelper.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/driver/OvsDriver.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/exception/VlanNotSetException.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/exception/VlanPoolExhaustedException.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/tapi/DataObjectModificationQualifier.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/tapi/TopologyDataHandler.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/transaction/TableTransaction.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/transaction/TopologyTransaction.java
ovs-driver/src/main/java/org/opendaylight/unimgr/mef/nrp/ovs/util/VlanUtils.java
ovs-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/ovs/DataStoreTestUtils.java
ovs-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/ovs/FlowTopologyTestUtils.java
ovs-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/ovs/OpenFlowTopologyTestUtils.java
ovs-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/ovs/OvsdbTopologyTestUtils.java
ovs-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/ovs/activator/OvsActivatorTest.java
ovs-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/ovs/tapi/TopologyDataHandlerTest.java
ovs-driver/src/test/java/org/opendaylight/unimgr/mef/nrp/ovs/tapi/TopologyDataHandlerTestUtils.java

index 3eabbb254c7c8c96ad09d82672f0464d4bdf56fc..a7407833ffe257588722c7ac0ae3ef83eb9c5dfd 100644 (file)
@@ -145,7 +145,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
     }
 
     public void close() {
-        if(registration != null) {
+        if (registration != null) {
             LOG.info("closing netconf tree listener");
             registration.close();
         }
@@ -183,7 +183,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
     }
 
     private void onAddedNodes(@Nonnull Collection<Node> added) throws ReadFailedException {
-        if(added.isEmpty()) return;
+        if (added.isEmpty()) return;
         LOG.debug("found {} added XR nodes", added.size());
 
         final ReadWriteTransaction topoTx = dataBroker.newReadWriteTransaction();
@@ -234,7 +234,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
             try {
                 KeyedInstanceIdentifier<Node, NodeKey> id = mountIds.get(key);
                 Optional<MountPoint> mountPoint = mountService.getMountPoint(id);
-                if(mountPoint.isPresent()) {
+                if (mountPoint.isPresent()) {
                     DataBroker deviceBroker = mountPoint.get().getService(DataBroker.class).get();
                     LOG.debug(deviceBroker.toString());
                     List<OwnedNodeEdgePoint> tps;
@@ -273,7 +273,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
 
     private Stream<InterfaceConfiguration> ports(ReadOnlyTransaction tx) throws ReadFailedException {
         Optional<InterfaceConfigurations> interfaces = tx.read(LogicalDatastoreType.OPERATIONAL, InterfaceHelper.getInterfaceConfigurationsId()).checkedGet();
-        if(interfaces.isPresent()) {
+        if (interfaces.isPresent()) {
             return interfaces.get().getInterfaceConfiguration().stream();
         }
 
index 22efeb4e1f8ba117342613bf5ed2b438b074fdd3..ca034d6c3b87d1a61692dc346b5e0eed99e4cd37 100644 (file)
@@ -33,7 +33,7 @@ public class BandwidthProfileComposition {
     }
 
     private static Optional<GNRPBwpFlow> convert(Optional<? extends GNRPBwpFlow> input) {
-        if(input.isPresent()) {
+        if (input.isPresent()) {
             return Optional.of(input.get());
         }
 
index e8add9a5ddcee1354a6c0f90699155b135d91284..24b627decc07f60dbc2abbebdbb2886ee86deee9 100644 (file)
@@ -80,7 +80,7 @@ public class BandwidthProfileHelper {
                 .map(nadg -> nadg.collect(x -> x::getLpSpec))
                 .collect(Collectors.toList());
 
-        for(NullAwareDatastoreGetter<LpSpec> lpSpecNadg : lpSpecNadgs) {
+        for (NullAwareDatastoreGetter<LpSpec> lpSpecNadg : lpSpecNadgs) {
             NullAwareDatastoreGetter<AdapterSpec1> adapterSpecNadg = lpSpecNadg
                     .collect(x -> x::getAdapterSpec)
                     .collect(x -> x::getAugmentation, AdapterSpec1.class);
@@ -118,8 +118,8 @@ public class BandwidthProfileHelper {
     }
 
     public boolean isQosEnabled() {
-        for(BandwidthProfileComposition bandwidthProfileComposition : bandwidthProfiles) {
-            if(bandwidthProfileComposition.hasAnyProfileDefined()) {
+        for (BandwidthProfileComposition bandwidthProfileComposition : bandwidthProfiles) {
+            if (bandwidthProfileComposition.hasAnyProfileDefined()) {
                 return true;
             }
         }
@@ -159,7 +159,7 @@ public class BandwidthProfileHelper {
     }
 
     public BandwidthProfileHelper addPolicyMap(String fcName, BandwidthProfileComposition.BwpDirection direction, BandwidthProfileComposition.BwpApplicability applicability) {
-        if(bandwidthProfiles.size() > 0) {
+        if (bandwidthProfiles.size() > 0) {
             Optional<GNRPBwpFlow> bwProfileOptional = bandwidthProfiles.stream().findFirst().get().get(direction, applicability);
 
             if (bwProfileOptional.isPresent()) {
index bceafb4036b18b076fe3d01ff96dd1bc5f111bfb..20798d579df549b282ef5796f170b696fa9419e5 100644 (file)
@@ -36,7 +36,7 @@ public class InterfaceHelper {
     public static InterfaceName getInterfaceName(ServicePort port) {
         String interfaceName = port.getTp().getValue();
 
-        if(interfaceName.contains(":")) {
+        if (interfaceName.contains(":")) {
             interfaceName = interfaceName.split(":")[1];
         }
 
@@ -63,11 +63,11 @@ public class InterfaceHelper {
             .setActive(new InterfaceActive("act"))
             .setShutdown(Boolean.FALSE);
 
-        if(mtus.isPresent()) {
+        if (mtus.isPresent()) {
             configurationBuilder.setMtus(mtus.get());
         }
 
-        if(setL2Transport) {
+        if (setL2Transport) {
             setL2Configuration(configurationBuilder);
         }
 
index cb894461f080b85a4f816300ff2ae9b47926853d..e95de9190ea825be0ce717074f38c37d86e616ed 100644 (file)
@@ -43,10 +43,10 @@ public class LoopbackUtils {
         TopologyId topologyId = port.getTopology();
         Optional<Node> nodeOpt = MdsalUtils.readOptional(dataBroker, LogicalDatastoreType.CONFIGURATION, getNodeIid(nodeId,topologyId));
 
-        if(nodeOpt.isPresent()) {
+        if (nodeOpt.isPresent()) {
             LoopbackAugmentation la = nodeOpt.get().getAugmentation(LoopbackAugmentation.class);
 
-            if (la != null){
+            if (la != null) {
                 loopback = la.getLoopbackAddress().getIpv4Address().getValue();
             }
         }
@@ -63,7 +63,7 @@ public class LoopbackUtils {
         return DEFAULT_LOOPBACK;
     }
 
-    public static InstanceIdentifier<Node> getNodeIid(NodeId nodeId, TopologyId topologyId){
+    public static InstanceIdentifier<Node> getNodeIid(NodeId nodeId, TopologyId topologyId) {
         InstanceIdentifier<Node> nodeInstanceId = InstanceIdentifier.builder(NetworkTopology.class)
                 .child(Topology.class, new TopologyKey(topologyId))
                 .child(Node.class, new NodeKey(nodeId))
index fe32a3f907ffbf8e72276f0fde04dc693fe63e67..28ea0cd477663967395579f1f85566eabe74fb8b 100644 (file)
@@ -27,7 +27,7 @@ public class MtuUtils {
     public static Mtus generateMtus(List<Long> mtuValues, CiscoIosXrString owner) {
         List<Mtu> mtus = new LinkedList<>();
 
-        for(Long mtuValue : mtuValues) {
+        for (Long mtuValue : mtuValues) {
             mtus.add(generateMtu(mtuValue, owner));
         }
 
index b6066d237804f64448573f8d5bf79d873ed05acf..8690ea7838662b6760be6050304626dee474ba27 100644 (file)
@@ -67,8 +67,8 @@ public abstract class AbstractL2vpnActivator implements ResourceActivator {
         String outerName = getOuterName(serviceId);
         ServicePort port = null;
         ServicePort neighbor = null;
-        for(EndPoint endPoint: endPoints){
-            if(port==null){
+        for (EndPoint endPoint: endPoints) {
+            if (port==null) {
                 port = ServicePort.toServicePort(endPoint, NETCONF_TOPOLODY_NAME);
             } else {
                 neighbor = ServicePort.toServicePort(endPoint, NETCONF_TOPOLODY_NAME);
index 46d706ad9aea54ac5e67378a9d515a05e29bd8f4..caf6f6c383476081b03b98d790d95844667cb8e3 100644 (file)
@@ -110,7 +110,7 @@ public class L2vpnP2pConnectActivator extends AbstractL2vpnActivator {
      * @param serviceId old service id
      * @return new service id
      */
-    private String replaceForbidenCharacters(String serviceId){
+    private String replaceForbidenCharacters(String serviceId) {
         return serviceId.replace(":","_");
     }
 }
index 9638f056913950143abb5b0a89bad4f1832ecab0..0770e24eb36bf0d7b2bd67e056ef0781d5951042 100644 (file)
@@ -41,7 +41,7 @@ public class XrDriverBuilder implements ActivationDriverBuilder {
     private L2vpnLocalConnectActivator localActivator;
     private L2vpnP2pConnectActivator p2pActivator;
 
-    public XrDriverBuilder(DataBroker dataBroker, MountPointService mountPointService){
+    public XrDriverBuilder(DataBroker dataBroker, MountPointService mountPointService) {
         this.dataBroker = dataBroker;
         this.mountPointService = mountPointService;
     }
@@ -86,11 +86,11 @@ public class XrDriverBuilder implements ActivationDriverBuilder {
                 return 0;
             }
 
-            private void handleEndpoints(BiConsumer<List<EndPoint>,AbstractL2vpnActivator> action){
+            private void handleEndpoints(BiConsumer<List<EndPoint>,AbstractL2vpnActivator> action) {
                 endPoints.forEach(endPoint -> connectWithAllNeighbors(action,endPoint,endPoints));
             }
 
-            private void connectWithAllNeighbors(BiConsumer<List<EndPoint>,AbstractL2vpnActivator> action, EndPoint endPoint, List<EndPoint> neighbors){
+            private void connectWithAllNeighbors(BiConsumer<List<EndPoint>,AbstractL2vpnActivator> action, EndPoint endPoint, List<EndPoint> neighbors) {
                 neighbors.stream()
                         .filter(neighbor -> !neighbor.equals(endPoint))
                         .forEach(neighbor -> activateNeighbors(action,endPoint,neighbor));
@@ -99,11 +99,11 @@ public class XrDriverBuilder implements ActivationDriverBuilder {
             private void activateNeighbors(BiConsumer<List<EndPoint>,AbstractL2vpnActivator> action, EndPoint portA, EndPoint portZ) {
                 List<EndPoint> endPointsToActivate = Arrays.asList(portA,portZ);
 
-                if(SipHandler.isTheSameDevice(portA.getEndpoint().getServiceInterfacePoint(),portZ.getEndpoint().getServiceInterfacePoint())){
-                    if(bridgeActivatedPairs==null){
+                if (SipHandler.isTheSameDevice(portA.getEndpoint().getServiceInterfacePoint(),portZ.getEndpoint().getServiceInterfacePoint())) {
+                    if (bridgeActivatedPairs==null) {
                         bridgeActivatedPairs = new ArrayList<>();
                     }
-                    if(isPairActivated(portA,portZ)){
+                    if (isPairActivated(portA,portZ)) {
                         return;
                     }
                     action.accept(endPointsToActivate, localActivator);
@@ -113,11 +113,11 @@ public class XrDriverBuilder implements ActivationDriverBuilder {
                 }
             }
 
-            private boolean isPairActivated(EndPoint a, EndPoint z){
+            private boolean isPairActivated(EndPoint a, EndPoint z) {
                 return bridgeActivatedPairs.stream()
                         .anyMatch( entry -> {
-                            if( (entry.getKey().equals(a) && entry.getValue().equals(z))
-                                    || (entry.getKey().equals(z) && entry.getValue().equals(a))){
+                            if ( (entry.getKey().equals(a) && entry.getValue().equals(z))
+                                    || (entry.getKey().equals(z) && entry.getValue().equals(a))) {
                                 return true;
                             }
                             return false;
index 585478ab27c141f39d629aafdd47b0e2a2d05c0c..46258c819918cb7f1419e635a7a00a09a4bb6ef8 100644 (file)
@@ -168,19 +168,19 @@ public class BandwidthProfileHelperTest {
         when(adapterSpec1.getNrpConnAdaptSpecAttrs()).thenReturn(connAdaptSpecAttrs);
         when(adapterSpec1.getNrpEvcEndpointConnAdaptSpecAttrs()).thenReturn(evcAttrs);
 
-        if(ingressDefaultBwp.isPresent()) {
+        if (ingressDefaultBwp.isPresent()) {
             when(connAdaptSpecAttrs.getIngressBwpFlow()).thenReturn(ingressDefaultBwp.get());
         }
 
-        if(egressDefaultBwp.isPresent()) {
+        if (egressDefaultBwp.isPresent()) {
             when(connAdaptSpecAttrs.getEgressBwpFlow()).thenReturn(egressDefaultBwp.get());
         }
 
-        if(ingressEvcBwp.isPresent()) {
+        if (ingressEvcBwp.isPresent()) {
             when(evcAttrs.getIngressBwpFlow()).thenReturn(ingressEvcBwp.get());
         }
 
-        if(egressEvcBwp.isPresent()) {
+        if (egressEvcBwp.isPresent()) {
             when(evcAttrs.getEgressBwpFlow()).thenReturn(egressEvcBwp.get());
         }
 
@@ -192,11 +192,11 @@ public class BandwidthProfileHelperTest {
         when(terminationSpec.getAugmentation(TerminationSpec1.class)).thenReturn(terminationSpec1);
         when(terminationSpec1.getNrpUniTerminationAttrs()).thenReturn(nrpUniTerminationAttrs);
 
-        if(ingressUniBwp.isPresent()) {
+        if (ingressUniBwp.isPresent()) {
             when(nrpUniTerminationAttrs.getIngressBwpUni()).thenReturn(ingressUniBwp.get());
         }
 
-        if(egressUniBwp.isPresent()) {
+        if (egressUniBwp.isPresent()) {
             when(nrpUniTerminationAttrs.getEgressBwpUni()).thenReturn(egressUniBwp.get());
         }
 
index 725c7a3de9c071e0d5ad3c4f27c64220cad4dfdb..a596732b837f23c9af47d4e483dd2442366b0c71 100644 (file)
@@ -47,17 +47,17 @@ public class LoopbackUtilsTest extends AbstractDataBrokerTest {
     private static String portNumber = "8080";
 
     @Before
-    public void setUp(){
+    public void setUp() {
         broker = getDataBroker();
     }
 
     @After
-    public void clean(){
+    public void clean() {
         deleteNode(LoopbackUtils.getNodeIid(new NodeId(nodeName),new TopologyId(topoName)));
     }
 
     @Test
-    public void testLoopbackAddress(){
+    public void testLoopbackAddress() {
         //given
         ServicePort port = L2vpnTestUtils.port(topoName, nodeName, portNumber);
         createAndPersistNode(true);
@@ -70,7 +70,7 @@ public class LoopbackUtilsTest extends AbstractDataBrokerTest {
     }
 
     @Test
-    public void testAbsenceOfLoopbackAddress(){
+    public void testAbsenceOfLoopbackAddress() {
         //given
         ServicePort port = L2vpnTestUtils.port(topoName, nodeName, portNumber);
         createAndPersistNode(false);
@@ -82,13 +82,13 @@ public class LoopbackUtilsTest extends AbstractDataBrokerTest {
         assertEquals(LoopbackUtils.getDefaultLoopback(),ipv4AddressNoZone.getValue());
     }
 
-    private void createAndPersistNode(boolean ifLoopbackAddress){
+    private void createAndPersistNode(boolean ifLoopbackAddress) {
         NodeId nodeId = new NodeId(nodeName);
         Node node = createNode(nodeId,ifLoopbackAddress);
         InstanceIdentifier<Node> nodeIid = writeNode(node);
     }
 
-    private Node createNode(NodeId nodeId,boolean ifLoopbackAddress){
+    private Node createNode(NodeId nodeId,boolean ifLoopbackAddress) {
         NodeBuilder nodeBuilder = new NodeBuilder();
 
         NodeId nodeIdTopo = new NodeId(topoName);
@@ -96,7 +96,7 @@ public class LoopbackUtilsTest extends AbstractDataBrokerTest {
 
         nodeBuilder.setNodeId(nodeId);
 
-        if(ifLoopbackAddress){
+        if (ifLoopbackAddress) {
             Ipv4Address ipv4Address = new Ipv4Address(loopbackAddress);
             IpAddress ipAddress = new IpAddress(ipv4Address);
             LoopbackAugmentationBuilder loopbackAugmentationBuilder = new LoopbackAugmentationBuilder();
@@ -107,7 +107,7 @@ public class LoopbackUtilsTest extends AbstractDataBrokerTest {
         return nodeBuilder.build();
     }
 
-    private InstanceIdentifier<Node> writeNode(Node node){
+    private InstanceIdentifier<Node> writeNode(Node node) {
         InstanceIdentifier<Node> nodeInstanceId = LoopbackUtils.getNodeIid(node.getNodeId(),new TopologyId(topoName));
         WriteTransaction transaction = broker.newWriteOnlyTransaction();
 
@@ -123,7 +123,7 @@ public class LoopbackUtilsTest extends AbstractDataBrokerTest {
         return null;
     }
 
-    private void deleteNode(InstanceIdentifier<Node> nodeIid){
+    private void deleteNode(InstanceIdentifier<Node> nodeIid) {
         WriteTransaction transaction = broker.newWriteOnlyTransaction();
         transaction.delete(LogicalDatastoreType.CONFIGURATION, nodeIid);
         try {
index 204b27e035b222a1e1606507de167d110456f81c..bb79e0ea3966f21706de4e1c79a64f1823b971e0 100644 (file)
@@ -61,7 +61,7 @@ public class L2vpnLocalConnectionActivatorTest extends AbstractDataBrokerTest{
     private String serviceId = "serviceId";
 
     @Before
-    public void setUp(){
+    public void setUp() {
         //given
         DataBroker broker = getDataBroker();
         optBroker = Optional.of(broker);
@@ -76,7 +76,7 @@ public class L2vpnLocalConnectionActivatorTest extends AbstractDataBrokerTest{
     }
 
     @Test
-    public void testActivateAndDeactivate(){
+    public void testActivateAndDeactivate() {
         //when
         activate();
 
@@ -103,7 +103,7 @@ public class L2vpnLocalConnectionActivatorTest extends AbstractDataBrokerTest{
         L2vpnTestUtils.checkDeactivated(optBroker,portNo1);
     }
 
-    private void deactivate(){
+    private void deactivate() {
         try {
             l2VpnLocalConnectActivator.deactivate(endPoints,serviceId);
         } catch (TransactionCommitFailedException e) {
@@ -111,7 +111,7 @@ public class L2vpnLocalConnectionActivatorTest extends AbstractDataBrokerTest{
         }
     }
 
-    private void activate(){
+    private void activate() {
         LOG.debug("activate L2VPN");
         try {
             l2VpnLocalConnectActivator.activate(endPoints,serviceId);
@@ -121,7 +121,7 @@ public class L2vpnLocalConnectionActivatorTest extends AbstractDataBrokerTest{
     }
 
     private void checkL2vpnTree(CheckedFuture<Optional<L2vpn>, ReadFailedException> driverL2vpn) throws InterruptedException, ExecutionException {
-        if (driverL2vpn.get().isPresent()){
+        if (driverL2vpn.get().isPresent()) {
             L2vpn l2vpn = driverL2vpn.get().get();
             L2vpnTestUtils.checkL2vpn(l2vpn);
 
@@ -147,7 +147,7 @@ public class L2vpnLocalConnectionActivatorTest extends AbstractDataBrokerTest{
     }
 
     private void checkInterfaceConfigurationTree(CheckedFuture<Optional<InterfaceConfigurations>, ReadFailedException> driverInterfaceConfigurations) throws InterruptedException, ExecutionException{
-        if (driverInterfaceConfigurations.get().isPresent()){
+        if (driverInterfaceConfigurations.get().isPresent()) {
             InterfaceConfigurations interfaceConfigurations = driverInterfaceConfigurations.get().get();
             L2vpnTestUtils.checkInterfaceConfigurations(interfaceConfigurations);
 
index ecd4e2402515c0548546cfb7c78be15c2d15dfbb..7d38399817a402f3f8dac9e19ec26ecbb79c103c 100644 (file)
@@ -59,7 +59,7 @@ public class L2vpnP2pConnectionActivatorTest extends AbstractDataBrokerTest {
     private List<EndPoint> endPoints;
 
     @Before
-    public void setUp(){
+    public void setUp() {
         //given
         DataBroker broker = getDataBroker();
         optBroker = Optional.of(broker);
@@ -72,7 +72,7 @@ public class L2vpnP2pConnectionActivatorTest extends AbstractDataBrokerTest {
     }
 
     @Test
-    public void testActivateAndDeactivate(){
+    public void testActivateAndDeactivate() {
         //when
         try {
             l2VpnP2PConnectActivator.activate(endPoints,serviceId);
@@ -103,7 +103,7 @@ public class L2vpnP2pConnectionActivatorTest extends AbstractDataBrokerTest {
         L2vpnTestUtils.checkDeactivated(optBroker,portNo1);
     }
 
-    private void deactivate(){
+    private void deactivate() {
         //when
         try {
             l2VpnP2PConnectActivator.deactivate(endPoints,serviceId);
@@ -113,7 +113,7 @@ public class L2vpnP2pConnectionActivatorTest extends AbstractDataBrokerTest {
     }
 
     private void checkL2vpnTree(CheckedFuture<Optional<L2vpn>, ReadFailedException> driverL2vpn) throws InterruptedException, ExecutionException{
-        if (driverL2vpn.get().isPresent()){
+        if (driverL2vpn.get().isPresent()) {
             L2vpn l2vpn = driverL2vpn.get().get();
             L2vpnTestUtils.checkL2vpn(l2vpn);
 
@@ -140,7 +140,7 @@ public class L2vpnP2pConnectionActivatorTest extends AbstractDataBrokerTest {
     }
 
     private void checkInterfaceConfigurationTree(CheckedFuture<Optional<InterfaceConfigurations>, ReadFailedException> driverInterfaceConfigurations) throws InterruptedException, ExecutionException{
-        if (driverInterfaceConfigurations.get().isPresent()){
+        if (driverInterfaceConfigurations.get().isPresent()) {
             InterfaceConfigurations interfaceConfigurations = driverInterfaceConfigurations.get().get();
             L2vpnTestUtils.checkInterfaceConfigurations(interfaceConfigurations);
 
index e4f4a5c924f42c54f16def74d09bdb114b188678..278643245ed0a370580dbf3e6c371e30747038b0 100644 (file)
@@ -57,26 +57,26 @@ import com.google.common.util.concurrent.CheckedFuture;
  */
 public class L2vpnTestUtils {
 
-    public static MountPointService getMockedMountPointService(Optional<DataBroker> optBroker){
+    public static MountPointService getMockedMountPointService(Optional<DataBroker> optBroker) {
         PowerMockito.mockStatic(MountPointHelper.class);
         PowerMockito.when(MountPointHelper.getDataBroker(Mockito.anyObject(),Mockito.anyString())).thenReturn(optBroker);
         return Mockito.mock(MountPointService.class);
     }
 
-    public static void checkL2vpn(L2vpn l2vpn){
+    public static void checkL2vpn(L2vpn l2vpn) {
         assertNotNull(l2vpn);
         assertNotNull(l2vpn.getDatabase());
         assertNotNull(l2vpn.getDatabase().getXconnectGroups());
     }
 
-    public static void checkXConnectGroup(XconnectGroup xconnectGroup, String outerName){
+    public static void checkXConnectGroup(XconnectGroup xconnectGroup, String outerName) {
         assertNotNull(xconnectGroup);
         assertEquals(outerName,xconnectGroup.getName().getValue());
         assertNotNull(xconnectGroup.getP2pXconnects());
         assertNotNull(xconnectGroup.getP2pXconnects().getP2pXconnect());
     }
 
-    public static void checkP2pXconnect(P2pXconnect p2pXconnect, String innerName){
+    public static void checkP2pXconnect(P2pXconnect p2pXconnect, String innerName) {
         assertNotNull(p2pXconnect);
         assertEquals(innerName,p2pXconnect.getName().getValue());
         assertNotNull(p2pXconnect.getAttachmentCircuits());
@@ -85,49 +85,49 @@ public class L2vpnTestUtils {
         assertNotNull(p2pXconnect.getPseudowires().getPseudowire());
     }
 
-    public static void checkAttachmentCircuit(AttachmentCircuit attachmentCircuit, String port){
+    public static void checkAttachmentCircuit(AttachmentCircuit attachmentCircuit, String port) {
         assertTrue(attachmentCircuit.isEnable());
         assertEquals(port,attachmentCircuit.getName().getValue());
     }
 
-    public static void checkPseudowire(Pseudowire pseudowire){
+    public static void checkPseudowire(Pseudowire pseudowire) {
         assertNotNull(pseudowire);
         assertNotNull(pseudowire.getPseudowireId());
         assertNotNull(pseudowire.getNeighbor());
         assertNotNull(pseudowire.getNeighbor().get(0));
     }
 
-    public static void checkNeighbor(Neighbor neighbor){
+    public static void checkNeighbor(Neighbor neighbor) {
         assertNotNull(neighbor);
         assertNotNull(neighbor.getXmlClass());
         assertNotNull(neighbor.getNeighbor());
         assertNotNull(neighbor.getMplsStaticLabels());
     }
 
-    public static void checkMplsStaticLabels(MplsStaticLabels mplsStaticLabels){
+    public static void checkMplsStaticLabels(MplsStaticLabels mplsStaticLabels) {
         assertNotNull(mplsStaticLabels);
         assertNotNull(mplsStaticLabels.getLocalStaticLabel());
         assertNotNull(mplsStaticLabels.getRemoteStaticLabel());
     }
 
-    public static void checkInterfaceConfigurations(InterfaceConfigurations interfaceConfigurations){
+    public static void checkInterfaceConfigurations(InterfaceConfigurations interfaceConfigurations) {
         assertNotNull(interfaceConfigurations);
         assertNotNull(interfaceConfigurations.getInterfaceConfiguration());
     }
 
-    public static void checkInterfaceConfiguration(InterfaceConfiguration interfaceConfiguration, String portNo, boolean mtu){
+    public static void checkInterfaceConfiguration(InterfaceConfiguration interfaceConfiguration, String portNo, boolean mtu) {
         assertNotNull(interfaceConfiguration);
         assertNotNull(interfaceConfiguration.getActive());
         assertNotNull(interfaceConfiguration.getInterfaceModeNonPhysical());
         assertEquals(portNo,interfaceConfiguration.getInterfaceName().getValue());
         assertTrue(interfaceConfiguration.isShutdown());
-        if(mtu){
+        if (mtu) {
             assertNotNull(interfaceConfiguration.getMtus());
             assertNotNull(interfaceConfiguration.getMtus().getMtu());
         }
     }
 
-    public static void checkMtu(Mtu mtu, Long mtuValue){
+    public static void checkMtu(Mtu mtu, Long mtuValue) {
         assertEquals(mtuValue,mtu.getMtu());
         assertNotNull(mtu.getOwner());
     }
@@ -155,7 +155,7 @@ public class L2vpnTestUtils {
     }
 
     private static void checkL2vpnDeactivation(CheckedFuture<Optional<L2vpn>, ReadFailedException>driverL2vpn) throws ExecutionException, InterruptedException {
-        if (driverL2vpn.get().isPresent()){
+        if (driverL2vpn.get().isPresent()) {
             L2vpn l2vpn = driverL2vpn.get().get();
             L2vpnTestUtils.checkL2vpn(l2vpn);
 
@@ -167,7 +167,7 @@ public class L2vpnTestUtils {
     }
 
     private static void checkInterfaceConfigurationDeactivation(CheckedFuture<Optional<InterfaceConfigurations>, ReadFailedException> driverInterfaceConfigurations, String deactivatedPort) throws InterruptedException, ExecutionException{
-        if (driverInterfaceConfigurations.get().isPresent()){
+        if (driverInterfaceConfigurations.get().isPresent()) {
             InterfaceConfigurations interfaceConfigurations = driverInterfaceConfigurations.get().get();
             L2vpnTestUtils.checkInterfaceConfigurations(interfaceConfigurations);
 
@@ -178,14 +178,14 @@ public class L2vpnTestUtils {
         }
     }
 
-    public static List<EndPoint> mockEndpoints(String device1Name, String device2Name, String portNo1, String portNo2){
+    public static List<EndPoint> mockEndpoints(String device1Name, String device2Name, String portNo1, String portNo2) {
         List<EndPoint> endPoints = new ArrayList<>();
         endPoints.add(mockEndPoint("sip:"+device1Name+":"+portNo1));
         endPoints.add(mockEndPoint("sip:"+device2Name+":"+portNo2));
         return endPoints;
     }
 
-    private static EndPoint mockEndPoint(String portName){
+    private static EndPoint mockEndPoint(String portName) {
         ConnectivityServiceEndPoint connectivityServiceEndPoint = mock(ConnectivityServiceEndPoint.class);
         NrpConnectivityServiceEndPointAttrs attrs = mock(NrpConnectivityServiceEndPointAttrs.class);
         //UNI port mock
index f0a779d66b1c6871f1e562dbc3ddce7fa9215610..44a063a8e6656c16584f3c243c47966308a92377 100644 (file)
@@ -48,7 +48,7 @@ public class UnimgrConsoleProviderTest implements IUnimgrConsoleProvider {
     }
 
     public void setListUnis(int amount, String ipAddress) {
-        for(int i=0; i<amount; i++){
+        for (int i=0; i<amount; i++) {
             final UniAugmentation uniAug = mock(UniAugmentation.class);
             final IpAddress ipAddr = mock(IpAddress.class);
             final Ipv4Address ip4 = mock(Ipv4Address.class);
index 22fdf5fbfbaa06ca855f07a8261775baf607b0c4..a0be5d6799c64ecd9c9fac9b56f199f3916c96bc 100644 (file)
@@ -75,7 +75,7 @@ public class NrpDao  {
     }
 
     private void verifyTx() {
-        if(tx == null) throw new IllegalStateException("Top perform write operation read write transaction is needed");
+        if (tx == null) throw new IllegalStateException("Top perform write operation read write transaction is needed");
     }
 
     /**
@@ -97,9 +97,9 @@ public class NrpDao  {
         InstanceIdentifier<OwnedNodeEdgePoint> nepIdent = node(nodeId).child(OwnedNodeEdgePoint.class, new OwnedNodeEdgePointKey(new Uuid(nepId)));
         try {
             Optional<OwnedNodeEdgePoint> opt = tx.read(LogicalDatastoreType.OPERATIONAL, nepIdent).checkedGet();
-            if(opt.isPresent()) {
+            if (opt.isPresent()) {
                 tx.delete(LogicalDatastoreType.OPERATIONAL,nepIdent);
-                if(removeSips){
+                if (removeSips) {
                     List<Uuid> sips = opt.get().getMappedServiceInterfacePoint();
                     removeSips(sips == null ? null : sips.stream());
                 }
@@ -165,7 +165,7 @@ public class NrpDao  {
 
     public void removeSips(Stream<Uuid>  uuids) {
         verifyTx();
-        if(uuids == null) return ;
+        if (uuids == null) return ;
         uuids.forEach(sip -> {
             LOG.debug("removing ServiceInterfacePoint with id {}", sip);
             tx.delete(LogicalDatastoreType.OPERATIONAL, ctx().child(ServiceInterfacePoint.class, new ServiceInterfacePointKey(sip)));
@@ -174,10 +174,10 @@ public class NrpDao  {
 
     public void removeNode(String nodeId, boolean removeSips) {
         verifyTx();
-        if(removeSips) {
+        if (removeSips) {
             try {
                 Optional<Node> opt = tx.read(LogicalDatastoreType.OPERATIONAL, node(nodeId)).checkedGet();
-                if(opt.isPresent()) {
+                if (opt.isPresent()) {
                     removeSips(opt.get().getOwnedNodeEdgePoint().stream().flatMap(nep -> nep.getMappedServiceInterfacePoint() == null ?
                             Stream.empty() : nep.getMappedServiceInterfacePoint().stream()
                     ));
@@ -190,13 +190,13 @@ public class NrpDao  {
         tx.delete(LogicalDatastoreType.OPERATIONAL, node(nodeId));
     }
 
-    public void updateAbstractNep(OwnedNodeEdgePoint nep){
+    public void updateAbstractNep(OwnedNodeEdgePoint nep) {
         verifyTx();
         InstanceIdentifier<OwnedNodeEdgePoint> nodeIdent = abstractNode().child(OwnedNodeEdgePoint.class, new OwnedNodeEdgePointKey(nep.getUuid()));
         tx.merge(LogicalDatastoreType.OPERATIONAL, nodeIdent, nep);
     }
 
-    public void deleteAbstractNep(OwnedNodeEdgePoint nep){
+    public void deleteAbstractNep(OwnedNodeEdgePoint nep) {
         verifyTx();
         InstanceIdentifier<OwnedNodeEdgePoint> nodeIdent = abstractNode().child(OwnedNodeEdgePoint.class, new OwnedNodeEdgePointKey(nep.getUuid()));
         tx.delete(LogicalDatastoreType.OPERATIONAL, nodeIdent);
index 2a6213abb1f5cacd213599ce5e630a87516ae3f2..b5ad39a634286ce2909350daca32b9ff44b39550 100644 (file)
@@ -11,11 +11,11 @@ package org.opendaylight.unimgr.mef.nrp.common;
  * Created by marek.ryznar@amartus.com.
  */
 public class ResourceNotAvailableException extends ResourceActivatorException {
-    public ResourceNotAvailableException(){
+    public ResourceNotAvailableException() {
         super();
     }
 
-    public ResourceNotAvailableException(String message){
+    public ResourceNotAvailableException(String message) {
         super(message);
     }
 }
index d754d182b97bac12c3a6bdf5f81ebb475d6d1189..2dd34a7950789e1b4ffc9fab981b6d8074ab5ed0 100644 (file)
@@ -37,7 +37,7 @@ public class ServicePort {
     //defines cTag VLAN ID
     private Long vlanId=null;
 
-    public ServicePort(TopologyId topoId, NodeId nodeId, TpId tpId){
+    public ServicePort(TopologyId topoId, NodeId nodeId, TpId tpId) {
         this.topoId = topoId;
         this.nodeId = nodeId;
         this.tpId = tpId;
@@ -75,25 +75,25 @@ public class ServicePort {
         this.vlanId = vlanId;
     }
 
-    public static ServicePort toServicePort(EndPoint endPoint, String topologyName){
+    public static ServicePort toServicePort(EndPoint endPoint, String topologyName) {
         Uuid sip = endPoint.getEndpoint().getServiceInterfacePoint();
         TopologyId topologyId = new TopologyId(topologyName);
         NodeId nodeId = new NodeId(SipHandler.getDeviceName(sip));
         TpId tpId = new TpId(SipHandler.getPortName(sip));
         ServicePort servicePort = new ServicePort(topologyId,nodeId,tpId);
-        if(hasVlan(endPoint)){
+        if (hasVlan(endPoint)) {
             servicePort.setVlanId(Long.valueOf(getVlan(endPoint)));
         }
         return servicePort;
     }
 
-    public static boolean hasVlan(EndPoint endPoint){
-        if( (endPoint.getAttrs() != null)
+    public static boolean hasVlan(EndPoint endPoint) {
+        if ( (endPoint.getAttrs() != null)
                 && (endPoint.getAttrs().getNrpCarrierEthConnectivityEndPointResource() != null) ) {
             NrpCarrierEthConnectivityEndPointResource attr =
                     endPoint.getAttrs().getNrpCarrierEthConnectivityEndPointResource();
             if ( (attr.getCeVlanIdListAndUntag() != null)
-                    && !(attr.getCeVlanIdListAndUntag().getVlanId().isEmpty()) ){
+                    && !(attr.getCeVlanIdListAndUntag().getVlanId().isEmpty()) ) {
                 return true;
             } else {
                 return false;
@@ -103,12 +103,12 @@ public class ServicePort {
         }
     }
 
-    private static int getVlan(EndPoint endPoint){
+    private static int getVlan(EndPoint endPoint) {
         return endPoint.getAttrs().getNrpCarrierEthConnectivityEndPointResource()
                 .getCeVlanIdListAndUntag().getVlanId().get(0).getVlanId().getValue().intValue();
     }
 
-    public String getInterfaceName(){
+    public String getInterfaceName() {
         TpId tpId = this.getTp();
         Matcher matcher = interface_name_pattern.matcher(tpId.getValue());
         return matcher.find() ? matcher.group() : default_interface_name;
index af22b3de6e90e6e875cb1711d72e7d3d8a56b403..8a4070bc3026b77ff0243c669f22eeecb5d5c2b5 100644 (file)
@@ -53,17 +53,17 @@ public class AbstractNodeHandler implements DataTreeChangeListener<Topology> {
 
     private final DataBroker dataBroker;
 
-    public AbstractNodeHandler(DataBroker dataBroker){
+    public AbstractNodeHandler(DataBroker dataBroker) {
         Objects.requireNonNull(dataBroker);
         this.dataBroker = dataBroker;
     }
 
-    public void init(){
+    public void init() {
         registration = dataBroker.registerDataTreeChangeListener(new DataTreeIdentifier<>(LogicalDatastoreType.OPERATIONAL, NRP_TOPOLOGY_SYSTEM_IID), this);
     }
 
-    public void close(){
-        if (registration!=null){
+    public void close() {
+        if (registration!=null) {
             registration.close();
         }
     }
@@ -116,9 +116,9 @@ public class AbstractNodeHandler implements DataTreeChangeListener<Topology> {
         OwnedNodeEdgePoint b = (OwnedNodeEdgePoint) dataObjectModificationNep.getDataBefore();
         OwnedNodeEdgePoint a = (OwnedNodeEdgePoint) dataObjectModificationNep.getDataAfter();
 
-        if(b != null) {
-            if(a == null) return true;
-            if(hasSip(b)) {
+        if (b != null) {
+            if (a == null) return true;
+            if (hasSip(b)) {
               return ! hasSip(a);
             }
         }
@@ -126,12 +126,12 @@ public class AbstractNodeHandler implements DataTreeChangeListener<Topology> {
         return false;
     }
 
-    private boolean checkIfUpdated(DataObjectModification dataObjectModificationNep){
+    private boolean checkIfUpdated(DataObjectModification dataObjectModificationNep) {
         OwnedNodeEdgePoint before = (OwnedNodeEdgePoint) dataObjectModificationNep.getDataBefore();
         OwnedNodeEdgePoint after = (OwnedNodeEdgePoint) dataObjectModificationNep.getDataAfter();
-        if(after == null) return false;
+        if (after == null) return false;
         //added
-        if(before == null) {
+        if (before == null) {
             return hasSip(after);
         }
         //updated
index 7e634942e340d9391813c013bd55e7235bf134bd..1ca10670178e5293a3469310ea675cb31c2e15ca 100644 (file)
@@ -37,7 +37,7 @@ public class ActivationTransaction {
      * @return result
      */
     public Result activate() {
-        if(drivers.isEmpty()) throw new IllegalStateException("at least one driver required");
+        if (drivers.isEmpty()) throw new IllegalStateException("at least one driver required");
         sortDrivers();
         try {
             for (ActivationDriver d: drivers) {
@@ -61,7 +61,7 @@ public class ActivationTransaction {
      * @return result
      */
     public Result deactivate() {
-        if(drivers.isEmpty()) throw new IllegalStateException("at least one driver required");
+        if (drivers.isEmpty()) throw new IllegalStateException("at least one driver required");
         sortDrivers();
         try {
             for (ActivationDriver d: drivers) {
@@ -117,11 +117,11 @@ public class ActivationTransaction {
             return message;
         }
 
-        public static Result success(){
+        public static Result success() {
             return new Result(true, Optional.empty(), Optional.empty());
         }
 
-        public static Result fail(String message, Throwable cause){
+        public static Result fail(String message, Throwable cause) {
             return new Result(false, Optional.of(message), Optional.of(cause));
         }
     }
index 0df43b44594b0af785a9867f1eff62725c4c0088..887e7343fa980b7eca6a4f46a23d5d6b0bbd3c90 100644 (file)
@@ -58,7 +58,7 @@ public class NrpInitializer {
 
         Optional<? extends DataObject> context = result.checkedGet();
 
-        if(! context.isPresent()) {
+        if (! context.isPresent()) {
             LOG.info("initialize Presto NRP context");
             Context ctx = new ContextBuilder()
                     .setUuid(new Uuid(PRESTO_CTX))
index 8ef75b575282516b95898daf1f0102d38f75cb77..8e86bcbfe344c0c2129e2c0786eaeca8f180945c 100644 (file)
@@ -69,7 +69,7 @@ public class DeleteConnectivityAction implements Callable<RpcResult<DeleteConnec
 
         ConnectivityService cs =
                 nrpDao.getConnectivityService(serviceId);
-        if(cs == null) {
+        if (cs == null) {
             return RpcResultBuilder
                     .<DeleteConnectivityServiceOutput>failed()
                     .withError(RpcError.ErrorType.APPLICATION, MessageFormat.format("Service {0} does not exist", input.getServiceIdOrName()))
@@ -163,7 +163,7 @@ public class DeleteConnectivityAction implements Callable<RpcResult<DeleteConnec
                     Uuid nodeId = c.getContainerNode();
                     return c.getConnectionEndPoint().stream().map(cep -> {
                         Optional<org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.connectivity.rev170712.connectivity.service.EndPoint> optEndPoint = Optional.empty();
-                        if(cs.getEndPoint() != null){
+                        if (cs.getEndPoint() != null) {
                             optEndPoint = cs.getEndPoint().stream()
                                     .filter(endPoint1 -> endPoint1.getServiceInterfacePoint().getValue().contains(cep.getServerNodeEdgePoint().getValue()))
                                     .findFirst();
index 37f128b3ed29b0eb79a754f59cc6dbb9ba5b4cb6..b31fb1a736fb47a13cea0a1ae8a2c2415d6880d7 100644 (file)
@@ -47,7 +47,7 @@ public class DecompositionAction {
     public DecompositionAction(List<EndPoint> endpoints, DataBroker broker) {
         Objects.requireNonNull(endpoints);
         Objects.requireNonNull(broker);
-        if(endpoints.size() < 2) throw new IllegalArgumentException("there should be at least two endpoints defined");
+        if (endpoints.size() < 2) throw new IllegalArgumentException("there should be at least two endpoints defined");
         this.endpoints = endpoints;
         this.broker = broker;
     }
@@ -59,11 +59,11 @@ public class DecompositionAction {
 
         assert vertexes.size() > 1;
 
-        if(vertexes.size() > 2) throw new IllegalStateException("currently only point to point is supported");
+        if (vertexes.size() > 2) throw new IllegalStateException("currently only point to point is supported");
 
         GraphPath<Vertex, DefaultEdge> path = DijkstraShortestPath.findPathBetween(graph, vertexes.get(0), vertexes.get(1));
 
-        if(path == null) return null;
+        if (path == null) return null;
 
         return path.getVertexList().stream().collect(Collectors.groupingBy(v -> v.getNodeUuid()))
                 .entrySet().stream().map(e -> {
@@ -79,11 +79,11 @@ public class DecompositionAction {
     }
 
     private void connected(Graph<Vertex, DefaultEdge> graph, List<Vertex> vertices) {
-        for(int i = 0; i < vertices.size(); ++i) {
+        for (int i = 0; i < vertices.size(); ++i) {
             Vertex f = vertices.get(i);
             //its OK if the vertex is added in internal loop nothing will happen
             graph.addVertex(f);
-            for(int j = i + 1; j < vertices.size(); ++j) {
+            for (int j = i + 1; j < vertices.size(); ++j) {
                 Vertex t = vertices.get(j);
                 graph.addVertex(t);
                 graph.addEdge(f,t);
@@ -106,7 +106,7 @@ public class DecompositionAction {
                 connected(graph, vertices);
             });
 
-            if(topo.getLink() != null) {
+            if (topo.getLink() != null) {
                 topo.getLink().stream()
                         .filter(l -> l.getState() != null && OperationalState.Enabled == l.getState().getOperationalState())
                         .forEach(l -> {
@@ -127,10 +127,10 @@ public class DecompositionAction {
         Uuid nodeUuid = n.getUuid();
         return n.getOwnedNodeEdgePoint().stream().map(nep -> {
             List<Uuid> sips = nep.getMappedServiceInterfacePoint();
-            if(sips == null || sips.isEmpty()) {
+            if (sips == null || sips.isEmpty()) {
                 return  new Vertex(nodeUuid, nep.getUuid(), null);
             }
-            if(sips.size() > 1) LOG.warn("NodeEdgePoint {} have multiple ServiceInterfacePoint mapped, selecting first one", nep.getUuid());
+            if (sips.size() > 1) LOG.warn("NodeEdgePoint {} have multiple ServiceInterfacePoint mapped, selecting first one", nep.getUuid());
             return new Vertex(nodeUuid, nep.getUuid(), sips.get(0));
 
         });
@@ -177,7 +177,7 @@ public class DecompositionAction {
 
         @Override
         public int compareTo(Vertex o) {
-            if(o == null) return -1;
+            if (o == null) return -1;
             return uuid.getValue().compareTo(o.uuid.getValue());
         }
 
index 59bd04b3b32005283c3cde9d20ea944504c22e3e..c7cf643ef7c295ef40ba25988f4e310b8c7e1883 100644 (file)
@@ -79,12 +79,12 @@ public class UnimgrExtServiceImpl implements UnimgrExtService {
                     .child(Node.class, new NodeKey(nodeId))
                     .child(OwnedNodeEdgePoint.class, new OwnedNodeEdgePointKey(nepId))
             ).checkedGet();
-            if(!nep.isPresent()) return withError("NEP with id {0} for node {1} not found", nepId, nodeId);
+            if (!nep.isPresent()) return withError("NEP with id {0} for node {1} not found", nepId, nodeId);
 
             Uuid sipId = new Uuid("sip:" + nepId.getValue());
 
             List<Uuid> sips = nep.get().getMappedServiceInterfacePoint();
-            if(sips != null && !sips.isEmpty()) return withError("sip for NEP with id {0} for node {1} already defined", nepId, nodeId);
+            if (sips != null && !sips.isEmpty()) return withError("sip for NEP with id {0} for node {1} already defined", nepId, nodeId);
 
             NrpDao nrpDao = new NrpDao(tx);
 
@@ -118,19 +118,19 @@ public class UnimgrExtServiceImpl implements UnimgrExtService {
 
         LayerProtocol1 lp = null;
 
-        if(sipType instanceof InniSpec) {
+        if (sipType instanceof InniSpec) {
             org.opendaylight.yang.gen.v1.urn.odl.unimgr.yang.unimgr.ext.rev700101.add.sip.input.sip.type.inni.spec.InniSpec spec = ((InniSpec) sipType).getInniSpec();
-            if(spec != null) lp = new LayerProtocol1Builder()
+            if (spec != null) lp = new LayerProtocol1Builder()
                     .setNrpCarrierEthInniNResource(new NrpCarrierEthInniNResourceBuilder(spec).build()).build();
 
         } else if (sipType instanceof EnniSpec) {
             org.opendaylight.yang.gen.v1.urn.odl.unimgr.yang.unimgr.ext.rev700101.add.sip.input.sip.type.enni.spec.EnniSpec spec = ((EnniSpec) sipType).getEnniSpec();
-            if(spec != null) lp = new LayerProtocol1Builder()
+            if (spec != null) lp = new LayerProtocol1Builder()
                     .setNrpCarrierEthEnniNResource(new NrpCarrierEthEnniNResourceBuilder(spec).build()).build();
 
-        } else if(sipType instanceof UniSpec) {
+        } else if (sipType instanceof UniSpec) {
             org.opendaylight.yang.gen.v1.urn.odl.unimgr.yang.unimgr.ext.rev700101.add.sip.input.sip.type.uni.spec.UniSpec spec = ((UniSpec) sipType).getUniSpec();
-            if(spec != null) lp = new LayerProtocol1Builder()
+            if (spec != null) lp = new LayerProtocol1Builder()
                     .setNrpCarrierEthUniNResource(new NrpCarrierEthUniNResourceBuilder(spec).build()).build();
         }
 
@@ -144,8 +144,8 @@ public class UnimgrExtServiceImpl implements UnimgrExtService {
 
     private static RpcResult<Void> withError(String error, Object ... params) {
         RpcResultBuilder<Void> failed = RpcResultBuilder.<Void>failed();
-        if(error != null) {
-            if(params.length > 0) {
+        if (error != null) {
+            if (params.length > 0) {
                error = MessageFormat.format(error, params);
             }
             failed.withError(RpcError.ErrorType.APPLICATION, error);
index d6833f9a1803298cff6da9728e27354ee46e5a7b..677c64c5d399eb26b4148fbe11ae627dc23be104 100644 (file)
@@ -66,11 +66,11 @@ public class CapabilitiesService {
                 return condition;
             }
 
-            private static boolean checkForNetconfCapability(Node node, String netconf_capability){
+            private static boolean checkForNetconfCapability(Node node, String netconf_capability) {
                 NetconfNode netconf = node.getAugmentation(NetconfNode.class);
-                if(netconf == null) return false;
-                if(netconf.getAvailableCapabilities() == null) return false;
-                if(netconf.getAvailableCapabilities().getAvailableCapability() == null) return false;
+                if (netconf == null) return false;
+                if (netconf.getAvailableCapabilities() == null) return false;
+                if (netconf.getAvailableCapabilities().getAvailableCapability() == null) return false;
 
                 return netconf
                         .getAvailableCapabilities()
@@ -108,7 +108,7 @@ public class CapabilitiesService {
                 boolean isSupporting = isSupporting(capability);
                 result = (mode == Capability.Mode.AND ? result && isSupporting: result || isSupporting);
 
-                if(result ^ (mode == Capability.Mode.AND)) {
+                if (result ^ (mode == Capability.Mode.AND)) {
                     break;
                 }
             }
index 1aeba88023547c103d0888ae384a2189ecd2ac61..fa2d3ea2429383afb954d1f6b6c46536b475cc1b 100644 (file)
@@ -62,7 +62,7 @@ public class NullAwareDatastoreGetter<T> {
 
         Optional<C> dataCollectionOptional = dataOptional.isPresent() ? Optional.ofNullable(function.apply(dataOptional.get()).get()) : Optional.empty();
 
-        if(dataCollectionOptional.isPresent()) {
+        if (dataCollectionOptional.isPresent()) {
             dataCollectionOptional.get().forEach(dataObject -> result.add(new NullAwareDatastoreGetter<R>(dataObject)));
         }
 
@@ -74,7 +74,7 @@ public class NullAwareDatastoreGetter<T> {
     }
 
     private void logDataOptionalStatus(Function <?, ?> function) {
-        if(dataOptional.isPresent()) {
+        if (dataOptional.isPresent()) {
             LOG.trace("Before collection of: " + function.toString() + ", currently collected data is non-null: " + dataOptional.get().toString());
         } else {
             LOG.debug("Null value encountered during collection of: " + function.toString());
index 2fdb45aea0920918db404490465b5c2445ec6411..4788f4f9215b89db90defd531a471150c4297919 100644 (file)
@@ -14,17 +14,17 @@ import org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.common.rev170712.Uuid;
  */
 public class SipHandler {
 
-    public static String getDeviceName(Uuid sip){
+    public static String getDeviceName(Uuid sip) {
         String[] sipTab = sip.getValue().split(":");
         return sipTab[sipTab.length-2];
     }
 
-    public static String getPortName(Uuid sip){
+    public static String getPortName(Uuid sip) {
         String[] sipTab = sip.getValue().split(":");
         return sipTab[sipTab.length-1];
     }
 
-    public static boolean isTheSameDevice(Uuid sip1, Uuid sip2){
+    public static boolean isTheSameDevice(Uuid sip1, Uuid sip2) {
         return getDeviceName(sip1).equals(getDeviceName(sip2));
     }
 }
index 7e125017ede54f67b72c3fb36a0ccf4443b52701..3c444eeab19d89cadc091e2ef08ee232e6a76def 100644 (file)
@@ -61,7 +61,7 @@ public class EvcAddCommandTest {
 
     @SuppressWarnings("unchecked")
     @Before
-    public void setUp(){
+    public void setUp() {
         PowerMockito.mockStatic(MdsalUtils.class);
         PowerMockito.mockStatic(EvcUtils.class);
         PowerMockito.mockStatic(OvsdbUtils.class);
index 659955e64f12742407f3f1e95293c3f5f67f234c..fac12422452514191f3c14e02cbf66d681528af8 100644 (file)
@@ -46,7 +46,7 @@ public class EvcRemoveCommandTest {
     private DataBroker dataBroker;
 
     @Before
-    public void setUp(){
+    public void setUp() {
         PowerMockito.mockStatic(MdsalUtils.class);
         PowerMockito.mockStatic(EvcUtils.class);
         PowerMockito.mockStatic(OvsdbUtils.class);
index 0a32e55142f1f3102a0781adfb6add4555a3cc55..98db57a7f0bc689909a4e92666065095cff9501b 100644 (file)
@@ -61,7 +61,7 @@ public class EvcUpdateCommandTest {
     private DataBroker dataBroker;
 
     @Before
-    public void setUp(){
+    public void setUp() {
         PowerMockito.mockStatic(UniUtils.class);
         PowerMockito.mockStatic(MdsalUtils.class);
         PowerMockito.mockStatic(EvcUtils.class);
@@ -170,7 +170,7 @@ public class EvcUpdateCommandTest {
     }
 
     @SuppressWarnings("unchecked")
-    private void verifyExecute(int getUniTimes, int deleteTimes, int readNodeTimes, int updateEvcTime){
+    private void verifyExecute(int getUniTimes, int deleteTimes, int readNodeTimes, int updateEvcTime) {
         evcUpdateCommand.execute();
         PowerMockito.verifyStatic(times(getUniTimes));
         UnimgrMapper.getUniIid(any(DataBroker.class), any(IpAddress.class),
index 53f6396486ca1a6d002f6e7f3b939326500d31bb..f4e2f229cde247a494bfa830a364dd86b64d6ef5 100644 (file)
@@ -59,7 +59,7 @@ public class UniAddCommandTest {
 
     @SuppressWarnings("unchecked")
     @Before
-    public void setUp(){
+    public void setUp() {
         PowerMockito.mockStatic(UniUtils.class);
         PowerMockito.mockStatic(OvsdbUtils.class);
         PowerMockito.mockStatic(MdsalUtils.class);
@@ -151,7 +151,7 @@ public class UniAddCommandTest {
     }
 
     @SuppressWarnings("unchecked")
-    private void verifyExecute(int qosTimes, int bridgeTimes, int updateNodeTime, int updateIIDTimes){
+    private void verifyExecute(int qosTimes, int bridgeTimes, int updateNodeTime, int updateIIDTimes) {
         uniAddCommand.execute();
         PowerMockito.verifyStatic(times(qosTimes));
         OvsdbUtils.createQoSForOvsdbNode(any(DataBroker.class), any(UniAugmentation.class));
index 5577fa6527b1a6fb7154616767aaed6a8d877924..38e01542a4b4800090887ca1eacbb05555cb1019 100644 (file)
@@ -59,7 +59,7 @@ public class UniRemoveCommandTest {
     private Node uniNode;
 
     @Before
-    public void setUp(){
+    public void setUp() {
         PowerMockito.mockStatic(UniUtils.class);
         PowerMockito.mockStatic(OvsdbUtils.class);
         PowerMockito.mockStatic(MdsalUtils.class);
index 110ecbbd52cedd8f5dd2053fdebcc1c39ae499d3..6a336ae3f3a24b8f4c2e87065b9766f56a267ed7 100644 (file)
@@ -59,7 +59,7 @@ public class UniUpdateCommandTest {
     private Node uniNode;
 
     @Before
-    public void setUp(){
+    public void setUp() {
         PowerMockito.mockStatic(UniUtils.class);
         PowerMockito.mockStatic(MdsalUtils.class);
         PowerMockito.mockStatic(OvsdbUtils.class);
@@ -129,7 +129,7 @@ public class UniUpdateCommandTest {
         verifyExecute(2, 2);
     }
 
-    private void verifyExecute(int qosTimes, int updateNodeTime){
+    private void verifyExecute(int qosTimes, int updateNodeTime) {
         uniUpdateCommand.execute();
         PowerMockito.verifyStatic(times(qosTimes));
         OvsdbUtils.createQoSForOvsdbNode(any(DataBroker.class), any(UniAugmentation.class));
index e7c97aca9c0447ff74d71bf678913e6affd3decd..afa01070d53745bc3c2043b6d808269b1809dff1 100644 (file)
@@ -61,7 +61,7 @@ public class AbstractNodeHandlerTest extends AbstractTestWithTopo {
     private static final int init_neps_count = 4;
 
     @Before
-    public void setUp(){
+    public void setUp() {
         //given
         dataBroker = getDataBroker();
 
@@ -77,7 +77,7 @@ public class AbstractNodeHandlerTest extends AbstractTestWithTopo {
     }
 
     @Test
-    public void testNodeAddition(){
+    public void testNodeAddition() {
         //when
         performNrpDaoAction(addNode,null);
 
@@ -87,7 +87,7 @@ public class AbstractNodeHandlerTest extends AbstractTestWithTopo {
     }
 
     @Test
-    public void testNepAddition(){
+    public void testNepAddition() {
         //given
         String newNepName = "newNep";
         performNrpDaoAction(addNode,null);
@@ -102,7 +102,7 @@ public class AbstractNodeHandlerTest extends AbstractTestWithTopo {
     }
 
     @Test
-    public void testNepUpdate(){
+    public void testNepUpdate() {
         //given
         performNrpDaoAction(addNode,null);
 
@@ -170,7 +170,7 @@ public class AbstractNodeHandlerTest extends AbstractTestWithTopo {
     }
 
     @Test
-    public void testNodeRemoval(){
+    public void testNodeRemoval() {
         //given
         performNrpDaoAction(addNode,null);
 
@@ -183,7 +183,7 @@ public class AbstractNodeHandlerTest extends AbstractTestWithTopo {
     }
 
     @Test
-    public void testNepRemoval(){
+    public void testNepRemoval() {
         //given
         performNrpDaoAction(addNode,null);
         String nepNameToRemove = testNepName+"0";
@@ -203,41 +203,41 @@ public class AbstractNodeHandlerTest extends AbstractTestWithTopo {
     BiConsumer<NrpDao,String> addNode = (dao,nepId) -> dao.createSystemNode(testSystemNodeName,createTestOwnedNodeEdgePointList());
     BiConsumer<NrpDao,OwnedNodeEdgePoint> update = (dao,nep) -> dao.updateNep(testSystemNodeName,nep);
 
-    private <T extends Object> void performNrpDaoAction(BiConsumer<NrpDao,T> action, T attr){
+    private <T extends Object> void performNrpDaoAction(BiConsumer<NrpDao,T> action, T attr) {
         ReadWriteTransaction tx = dataBroker.newReadWriteTransaction();
         nrpDao = new NrpDao(tx);
         action.accept(nrpDao,attr);
         tx.submit();
     }
 
-    private List<OwnedNodeEdgePoint> createTestOwnedNodeEdgePointList(){
+    private List<OwnedNodeEdgePoint> createTestOwnedNodeEdgePointList() {
         return IntStream.range(0,init_neps_count).
                 mapToObj(i -> createNep(testNepName + i, TerminationDirection.Bidirectional))
                 .collect(Collectors.toList());
     }
 
-    private OwnedNodeEdgePoint createNep(String nepName, TerminationDirection td){
+    private OwnedNodeEdgePoint createNep(String nepName, TerminationDirection td) {
         return createNep(nepName, true, td);
     }
 
-    private OwnedNodeEdgePoint createNep(String nepName, boolean associateSip, TerminationDirection td){
+    private OwnedNodeEdgePoint createNep(String nepName, boolean associateSip, TerminationDirection td) {
         Uuid uuid = new Uuid(nepName);
         OwnedNodeEdgePointBuilder builder = new OwnedNodeEdgePointBuilder()
                 .setKey(new OwnedNodeEdgePointKey(uuid))
                 .setUuid(uuid);
                 // TODO donaldh .setTerminationDirection(td);
 
-        if(associateSip) builder.setMappedServiceInterfacePoint(Arrays.asList(new Uuid(sipPrefix + nepName)));
+        if (associateSip) builder.setMappedServiceInterfacePoint(Arrays.asList(new Uuid(sipPrefix + nepName)));
 
         return builder.build();
     }
 
-    private Node getAbstractNode(){
+    private Node getAbstractNode() {
         ReadOnlyTransaction tx = dataBroker.newReadOnlyTransaction();
         try {
             Optional<Node> opt =
                     (Optional<Node>) tx.read(LogicalDatastoreType.OPERATIONAL,NRP_ABSTRACT_NODE_IID).checkedGet();
-            if(opt.isPresent()){
+            if (opt.isPresent()) {
                 return opt.get();
             } else {
                 return null;
index 0d7d279b8b0e9756cd144501a1fdf7e58c699b1b..4af79eaa166a0acd3598157db73db8294d1b3222 100644 (file)
@@ -83,7 +83,7 @@ public abstract class AbstractTestWithTopo extends AbstractDataBrokerTest {
 
     protected Node n(ReadWriteTransaction tx, boolean addSips, String node, String ... endpoints) {
         NrpDao nrpDao = new NrpDao(tx);
-        if(addSips) Arrays.stream(endpoints).map(e -> new ServiceInterfacePointBuilder()
+        if (addSips) Arrays.stream(endpoints).map(e -> new ServiceInterfacePointBuilder()
                 .setUuid(new Uuid("sip:" + e))
                 .build())
                 .forEach(nrpDao::addSip);
@@ -92,7 +92,7 @@ public abstract class AbstractTestWithTopo extends AbstractDataBrokerTest {
         return nrpDao.createSystemNode(node, Arrays.stream(endpoints)
                 .map(e-> {
                     OwnedNodeEdgePointBuilder builder = new OwnedNodeEdgePointBuilder().setUuid(new Uuid(e));
-                    if(addSips) {
+                    if (addSips) {
                         builder.setMappedServiceInterfacePoint(Collections.singletonList(new Uuid("sip:"+e)));
                     }
                     return builder.build();
index f7a3f19bbbf42b2163fa0cdc372f478619fdacc9..6c1b695c1575a66670f946071b3e376945df5b39 100644 (file)
@@ -352,7 +352,7 @@ public class TapiConnectivityServiceInplIntTest extends AbstractTestWithTopo {
                 .setContainerNode(new Uuid(nodeUuid))
                 .setConnectionEndPoint(ceps(neps));
 
-        if(!route.isEmpty()) {
+        if (!route.isEmpty()) {
             builder.setRoute(Collections.singletonList(new RouteBuilder()
                     .setConnectionEndPoint(route)
                     .setLocalId("route")
index 78fbd2970149b4ad734c49bcb3859c4b43b71425..505f1c2730c204bd0ce11fdc00143ecc64d5cd93 100644 (file)
@@ -96,7 +96,7 @@ public class UnimgrExtServiceImplTest extends AbstractTestWithTopo {
         boolean hasSip = nep.getMappedServiceInterfacePoint().get(0).getValue().equals("sip:" + nepId);
         ServiceInterfacePoint sip = nrpDao.getSip("sip:" + nepId);
         assertTrue(hasSip && sip != null);
-        if(verifySip != null) verifySip.accept(sip);
+        if (verifySip != null) verifySip.accept(sip);
 
     }
 
@@ -117,7 +117,7 @@ public class UnimgrExtServiceImplTest extends AbstractTestWithTopo {
                 .setNepId(new Uuid(nepId))
                 .setNodeId(new Uuid(nodeId));
 
-        if(type == null) return sipBuilder.build();
+        if (type == null) return sipBuilder.build();
 
         switch (type) {
             case uni: sipBuilder.setSipType(
index 68167aaa80b63ce2ff397e754a621d288ba5d849..4494ff11effa0ce40ad964f675f0cc83ba429696 100644 (file)
@@ -59,7 +59,7 @@ public class NodeTestUtils {
         FcPort mockedFcPort = mock(FcPort.class);
         StringBuilder nodeIdBuilder = new StringBuilder(DEVICE_ID);
 
-        if(nodeNo > 0) {
+        if (nodeNo > 0) {
             nodeIdBuilder.append("_").append(Integer.toString(nodeNo));
         }
 
@@ -84,7 +84,7 @@ public class NodeTestUtils {
         Optional<Node> mockedNodeOptional = mockNode();
 
         List<AvailableCapability> netconfCapabilityList = new ArrayList<>();
-        if(withNetconfCapabilities) {
+        if (withNetconfCapabilities) {
             netconfCapabilityList = Arrays.asList(createAvailableCapability(NetconfConstants.CAPABILITY_IOX_L2VPN),
                     createAvailableCapability(NetconfConstants.CAPABILITY_IOX_IFMGR),
                             createAvailableCapability(NetconfConstants.CAPABILITY_IOX_ASR9K_POLICYMGR));
@@ -102,7 +102,7 @@ public class NodeTestUtils {
         return mockedNodeOptional;
     }
 
-    private static AvailableCapability createAvailableCapability(String name){
+    private static AvailableCapability createAvailableCapability(String name) {
         AvailableCapabilityBuilder availableCapabilityBuilder = new AvailableCapabilityBuilder();
         availableCapabilityBuilder.setCapability(name);
         return availableCapabilityBuilder.build();
index d34fdd562c821d4fdf1e9464808655e7b16f77f0..0eb86cd812fc4f097ca70ab047093c7f93cb71f3 100644 (file)
@@ -55,9 +55,9 @@ class OvsActivatorHelper {
      */
     int getCeVlanId() throws ResourceNotAvailableException {
 
-        if( (endPoint.getAttrs() != null) && (endPoint.getAttrs().getNrpCarrierEthConnectivityEndPointResource() != null) ) {
+        if ( (endPoint.getAttrs() != null) && (endPoint.getAttrs().getNrpCarrierEthConnectivityEndPointResource() != null) ) {
             NrpCarrierEthConnectivityEndPointResource attr = endPoint.getAttrs().getNrpCarrierEthConnectivityEndPointResource();
-            if( (attr.getCeVlanIdListAndUntag()!=null) && !(attr.getCeVlanIdListAndUntag().getVlanId().isEmpty()) ){
+            if ( (attr.getCeVlanIdListAndUntag()!=null) && !(attr.getCeVlanIdListAndUntag().getVlanId().isEmpty()) ) {
                 //for now we support only one CE VLAN
                 return attr.getCeVlanIdListAndUntag().getVlanId().get(0).getVlanId().getValue().intValue();
             } else {
@@ -101,7 +101,7 @@ class OvsActivatorHelper {
     private Map<String, String> createPortMap(List<NullAwareDatastoreGetter<Node>> nodes) {
         Map<String, String> portMap = new HashMap<>();
         for (NullAwareDatastoreGetter<Node> node : nodes) {
-            if (node.get().isPresent()){
+            if (node.get().isPresent()) {
                 for (NodeConnector nodeConnector : node.get().get().getNodeConnector()) {
                     String ofName = nodeConnector.getId().getValue();
                     FlowCapableNodeConnector flowCapableNodeConnector = nodeConnector.getAugmentation(FlowCapableNodeConnector.class);
@@ -113,7 +113,7 @@ class OvsActivatorHelper {
         return portMap;
     }
 
-    protected static String getPortName(String sip){
+    protected static String getPortName(String sip) {
         String[] tab = sip.split(":");
         return tab[tab.length-1];
     }
index db9b82fb526d913a274fdae6c2ea8dc31f9ef6d2..da98150342d1af100080cef3fd3b54cf2b008801 100644 (file)
@@ -28,7 +28,7 @@ public class OvsDriver implements ActivationDriverBuilder {
 
     private OvsActivator activator;
 
-    public OvsDriver(DataBroker dataBroker){
+    public OvsDriver(DataBroker dataBroker) {
         activator = new OvsActivator(dataBroker);
     }
 
index 3e8a7cec3cc0ac198d64c3678ddb8248de83a921..82a45ae95deea5fa90ae772ffdfacf34a9921fbf 100644 (file)
@@ -15,7 +15,7 @@ import org.opendaylight.unimgr.mef.nrp.common.ResourceNotAvailableException;
  * @author jakub.niezgoda@amartus.com
  */
 public class VlanNotSetException extends ResourceNotAvailableException {
-    public VlanNotSetException(String message){
+    public VlanNotSetException(String message) {
         super(message);
     }
 }
\ No newline at end of file
index a8947a995f608b69daaf24cd720949241c3b9a9f..23c891bcd76f3aacd1e1f15148322b8296bbd40e 100644 (file)
@@ -15,7 +15,7 @@ import org.opendaylight.unimgr.mef.nrp.common.ResourceNotAvailableException;
  * @author marek.ryznar@amartus.com
  */
 public class VlanPoolExhaustedException extends ResourceNotAvailableException {
-    public VlanPoolExhaustedException(String message){
+    public VlanPoolExhaustedException(String message) {
         super(message);
     }
 }
\ No newline at end of file
index c5d0abe773499c354eb9ac6e2134a9a0d449662c..ba120829ab0c34a62b0fc51aff9fa78e4e5474ff 100644 (file)
@@ -27,20 +27,20 @@ public class DataObjectModificationQualifier {
     private static final Logger LOG = LoggerFactory.getLogger(DataObjectModificationQualifier.class);
     private CapabilitiesService capabilitiesService;
 
-    public DataObjectModificationQualifier(DataBroker dataBroker){
+    public DataObjectModificationQualifier(DataBroker dataBroker) {
         capabilitiesService = new CapabilitiesService(dataBroker);
     }
 
     private Function<Node,Boolean> isOvs = node -> capabilitiesService.node(node).isSupporting(AND, OVSDB);
 
-    protected void checkNodes(List<DataObjectModification> nodes, Map<TerminationPoint,String> toAddMap, Map<TerminationPoint,String> toUpdateMap, Map<TerminationPoint,String> toDeleteMap){
+    protected void checkNodes(List<DataObjectModification> nodes, Map<TerminationPoint,String> toAddMap, Map<TerminationPoint,String> toUpdateMap, Map<TerminationPoint,String> toDeleteMap) {
         Node n;
-        for(DataObjectModification node: nodes){
-            switch(node.getModificationType()){
+        for (DataObjectModification node: nodes) {
+            switch(node.getModificationType()) {
                 //new ovs node
                 case WRITE :{
                     n = (Node) node.getDataAfter();
-                    if(!isOvs.apply(n) || n.getTerminationPoint()==null)
+                    if (!isOvs.apply(n) || n.getTerminationPoint()==null)
                         break;
                     String bridgeName = n.getAugmentation(OvsdbBridgeAugmentation.class).getBridgeName().getValue();
                     n.getTerminationPoint().forEach(tp -> toAddMap.put(tp,bridgeName));
@@ -51,7 +51,7 @@ public class DataObjectModificationQualifier {
                 //whole ovs-node eg. s1 deleted
                 case DELETE:{
                     n = (Node) node.getDataBefore();
-                    if(!isOvs.apply(n) || n.getTerminationPoint()==null)
+                    if (!isOvs.apply(n) || n.getTerminationPoint()==null)
                         break;
                     String bridgeName = n.getAugmentation(OvsdbBridgeAugmentation.class).getBridgeName().getValue();
                     n.getTerminationPoint().forEach(tp -> toDeleteMap.put(tp,bridgeName));
@@ -63,16 +63,16 @@ public class DataObjectModificationQualifier {
         }
     }
 
-    private void checkTerminationPoints(DataObjectModification node, Map<TerminationPoint,String> toAddMap, Map<TerminationPoint,String> toUpdateMap, Map<TerminationPoint,String> toDeleteMap){
+    private void checkTerminationPoints(DataObjectModification node, Map<TerminationPoint,String> toAddMap, Map<TerminationPoint,String> toUpdateMap, Map<TerminationPoint,String> toDeleteMap) {
         Node n = (Node) node.getDataAfter();
-        if(!isOvs.apply(n))
+        if (!isOvs.apply(n))
             return ;
         String bridgeName = n.getAugmentation(OvsdbBridgeAugmentation.class).getBridgeName().getValue();
         Collection<DataObjectModification<? extends DataObject>> modifiedChildren = node.getModifiedChildren();
 
         TerminationPoint terminationPoint;
-        for(DataObjectModification tp: modifiedChildren) {
-            if(!tp.getDataType().equals(TerminationPoint.class))
+        for (DataObjectModification tp: modifiedChildren) {
+            if (!tp.getDataType().equals(TerminationPoint.class))
                 continue;
             switch (tp.getModificationType()) {
                 //new port added eg. s1-eth7
index 55ce3731f38e6a2c97a08209414bab09599d69df..ea7cd043273e1e29b31f7f8178337277f85fbe7d 100644 (file)
@@ -103,7 +103,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
         registerOvsdbTreeListener();
     }
 
-    private void registerOvsdbTreeListener(){
+    private void registerOvsdbTreeListener() {
         InstanceIdentifier<Node> nodeId = OVSDB_TOPO_IID.child(Node.class);
         registration = dataBroker.registerDataTreeChangeListener(new DataTreeIdentifier<>(LogicalDatastoreType.OPERATIONAL, nodeId), this);
     }
@@ -126,7 +126,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
             }
         });
 
-        if(registration != null) {
+        if (registration != null) {
             LOG.info("closing netconf tree listener");
             registration.close();
         }
@@ -154,7 +154,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
                 .forEach(entry -> {
                     String nepId = OVS_NODE + DELIMETER + getFullPortName(entry.getValue(), entry.getKey().getTpId().getValue());
                     OwnedNodeEdgePoint nep;
-                    if(dao.hasSip(nepId)){
+                    if (dao.hasSip(nepId)) {
                         nep = createNep(nepId);
                         dao.updateNep(OVS_NODE,nep);
                     } else {
@@ -176,8 +176,8 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
         newNeps.forEach(nep -> addEndpoint(dao,nep.getKey().getUuid().getValue()));
     };
 
-    private void executeDbAction(BiConsumer<Map<TerminationPoint,String>,NrpDao> action,Map<TerminationPoint,String> map){
-        if(map.isEmpty())
+    private void executeDbAction(BiConsumer<Map<TerminationPoint,String>,NrpDao> action,Map<TerminationPoint,String> map) {
+        if (map.isEmpty())
             return ;
         final ReadWriteTransaction topoTx = dataBroker.newReadWriteTransaction();
         NrpDao dao = new NrpDao(topoTx);
@@ -198,7 +198,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
         });
     }
 
-    private String getFullPortName(String switchName, String portName){
+    private String getFullPortName(String switchName, String portName) {
         return switchName + DELIMETER + portName;
     }
 
@@ -228,7 +228,7 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
                 .build();
     }
 
-    private OwnedNodeEdgePoint createNep(String nepId){
+    private OwnedNodeEdgePoint createNep(String nepId) {
         OwnedNodeEdgePointBuilder tpBuilder = new OwnedNodeEdgePointBuilder();
         Uuid tpId = new Uuid(OVS_NODE + DELIMETER + nepId);
         return tpBuilder
@@ -237,20 +237,20 @@ public class TopologyDataHandler implements DataTreeChangeListener<Node> {
                 .build();
     }
 
-    private List<OwnedNodeEdgePoint> getNewNeps(Map<TerminationPoint,String> toAddMap){
+    private List<OwnedNodeEdgePoint> getNewNeps(Map<TerminationPoint,String> toAddMap) {
         return toAddMap.entrySet().stream()
                 .map(entry -> createNep(getFullPortName(entry.getValue(),entry.getKey().getTpId().getValue())) )
                 .collect(Collectors.toList());
     }
 
     //TODO: write better implementation
-    private boolean isNep(TerminationPoint terminationPoint){
+    private boolean isNep(TerminationPoint terminationPoint) {
         OvsdbTerminationPointAugmentation ovsdbTerminationPoint = terminationPoint.getAugmentation(OvsdbTerminationPointAugmentation.class);
-        if( ovsdbTerminationPoint==null || (ovsdbTerminationPoint.getInterfaceType()!=null && ovsdbTerminationPoint.getInterfaceType().equals(InterfaceTypeInternal.class))) {
+        if ( ovsdbTerminationPoint==null || (ovsdbTerminationPoint.getInterfaceType()!=null && ovsdbTerminationPoint.getInterfaceType().equals(InterfaceTypeInternal.class))) {
             return false;
         }
 
-        if( ovsdbTerminationPoint.getOfport() == null )
+        if ( ovsdbTerminationPoint.getOfport() == null )
             return false;
 
         String ofPortNumber = ovsdbTerminationPoint.getOfport().toString();
index 84de4763de00b0cb876cbe397da58bf2e4db03e4..2ccd610ca444a9be5d5a08f96cb9fd56dbf4f5a9 100644 (file)
@@ -104,7 +104,7 @@ public class TableTransaction {
         deleteTransaction.submit().checkedGet();
     }
 
-    private InstanceIdentifier<Table> getTableIid(NodeKey nodeKey, TableKey tableKey){
+    private InstanceIdentifier<Table> getTableIid(NodeKey nodeKey, TableKey tableKey) {
         return InstanceIdentifier.builder(Nodes.class)
                                  .child(Node.class, nodeKey)
                                  .augmentation(FlowCapableNode.class)
@@ -112,7 +112,7 @@ public class TableTransaction {
                                  .build();
     }
 
-    private InstanceIdentifier<Flow> getFlowIid(Flow flow){
+    private InstanceIdentifier<Flow> getFlowIid(Flow flow) {
         return tableInstanceId.child(Flow.class, flow.getKey());
     }
 }
index 1f27b69261cb8a2c41be9d90445ef5ff8ac621ff..ce3a8023121824dde10cfe9fdfbeab0cbf606166 100644 (file)
@@ -70,9 +70,9 @@ public class TopologyTransaction {
      * @throws ResourceNotAvailableException if node for the specified port name was not found
      */
     public Node readNode(String portName) throws ResourceNotAvailableException {
-        for(NullAwareDatastoreGetter<Node> node : readNodes()) {
-            if(node.get().isPresent()){
-                for(NodeConnector nodeConnector:node.get().get().getNodeConnector()) {
+        for (NullAwareDatastoreGetter<Node> node : readNodes()) {
+            if (node.get().isPresent()) {
+                for (NodeConnector nodeConnector:node.get().get().getNodeConnector()) {
                     FlowCapableNodeConnector flowCapableNodeConnector
                             = nodeConnector.getAugmentation(FlowCapableNodeConnector.class);
                     if (portName.equals(flowCapableNodeConnector.getName())) {
@@ -89,9 +89,9 @@ public class TopologyTransaction {
     public Node readNodeOF(String ofportName) throws ResourceNotAvailableException {
         String ofNodeName = ofportName.split(":")[0]+":"+ofportName.split(":")[1];
         Nodes nodes = readOpenFLowTopology(dataBroker);
-        if(nodes != null){
-            for(Node node: nodes.getNode()){
-                if(node.getId().getValue().equals(ofNodeName)){
+        if (nodes != null) {
+            for (Node node: nodes.getNode()) {
+                if (node.getId().getValue().equals(ofNodeName)) {
                     return node;
                 }
             }
@@ -151,7 +151,7 @@ public class TopologyTransaction {
         return InstanceIdentifier.builder(Nodes.class).build();
     }
 
-    public static Nodes readOpenFLowTopology(DataBroker dataBroker){
+    public static Nodes readOpenFLowTopology(DataBroker dataBroker) {
         InstanceIdentifier instanceIdentifier = InstanceIdentifier.builder(Nodes.class).build();
         return (Nodes) MdsalUtils.read(dataBroker, LogicalDatastoreType.CONFIGURATION,instanceIdentifier);
     }
index 0ea0ae5424f3d5e1d20673ba443ee0cecef3535a..9699e241c17545106112bc101fdefe589d370d8d 100644 (file)
@@ -101,7 +101,7 @@ public class VlanUtils {
         if (flow.getInstructions() != null &&
             !flow.getInstructions().getInstruction().isEmpty())
         {
-            for(Instruction instruction : flow.getInstructions().getInstruction()) {
+            for (Instruction instruction : flow.getInstructions().getInstruction()) {
                 ApplyActionsCase applyActionsCase = (ApplyActionsCase) instruction.getInstruction();
                 ApplyActions applyActions = applyActionsCase.getApplyActions();
                 List<Action> actions = applyActions.getAction();
@@ -111,13 +111,13 @@ public class VlanUtils {
     }
 
     private void checkActions(List<Action> actions) {
-        for( Action action:actions ) {
+        for ( Action action:actions ) {
             org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.Action concreteAction = action.getAction();
-            if( concreteAction instanceof SetField ) {
+            if ( concreteAction instanceof SetField ) {
                 SetField setField = (SetField) concreteAction;
-                if( setField.getVlanMatch() != null ) {
+                if ( setField.getVlanMatch() != null ) {
                     Integer vid = getVlanFromMatch(setField.getVlanMatch());
-                    if( vid != null && !usedVlans.contains(vid)) {
+                    if ( vid != null && !usedVlans.contains(vid)) {
                         usedVlans.add(vid);
                     }
                 }
index 513bd7a4005af439ca6ec3f26815e14743a1ce7b..de3378a7f6798b45e68777933f325f86dba9f70c 100644 (file)
@@ -29,15 +29,15 @@ import static org.junit.Assert.fail;
 public class DataStoreTestUtils {
     private static final Logger LOG = LoggerFactory.getLogger(DataStoreTestUtils.class);
 
-    public static <T extends DataObject> T read(InstanceIdentifier instanceIdentifier, DataBroker dataBroker){
+    public static <T extends DataObject> T read(InstanceIdentifier instanceIdentifier, DataBroker dataBroker) {
         return read(instanceIdentifier,dataBroker,LogicalDatastoreType.OPERATIONAL);
     }
 
-    public static <T extends DataObject> T readConfig(InstanceIdentifier instanceIdentifier, DataBroker dataBroker){
+    public static <T extends DataObject> T readConfig(InstanceIdentifier instanceIdentifier, DataBroker dataBroker) {
         return read(instanceIdentifier,dataBroker,LogicalDatastoreType.CONFIGURATION);
     }
 
-    public static <T extends DataObject> void write(T object, InstanceIdentifier<T> instanceIdentifier, DataBroker dataBroker){
+    public static <T extends DataObject> void write(T object, InstanceIdentifier<T> instanceIdentifier, DataBroker dataBroker) {
         ReadWriteTransaction transaction = dataBroker.newReadWriteTransaction();
         transaction.put(LogicalDatastoreType.OPERATIONAL,instanceIdentifier,object,true);
 
@@ -55,7 +55,7 @@ public class DataStoreTestUtils {
         });
     }
 
-    public static void delete(InstanceIdentifier instanceIdentifier, DataBroker dataBroker){
+    public static void delete(InstanceIdentifier instanceIdentifier, DataBroker dataBroker) {
         ReadWriteTransaction transaction = dataBroker.newReadWriteTransaction();
         transaction.delete(LogicalDatastoreType.OPERATIONAL, instanceIdentifier);
 
@@ -73,11 +73,11 @@ public class DataStoreTestUtils {
         });
     }
 
-    private static <T extends DataObject> T read(InstanceIdentifier instanceIdentifier, DataBroker dataBroker, LogicalDatastoreType type){
+    private static <T extends DataObject> T read(InstanceIdentifier instanceIdentifier, DataBroker dataBroker, LogicalDatastoreType type) {
         ReadOnlyTransaction transaction = dataBroker.newReadOnlyTransaction();
         try {
             Optional<T> opt = (Optional<T>) transaction.read(type,instanceIdentifier).checkedGet();
-            if (opt.isPresent()){
+            if (opt.isPresent()) {
                 return opt.get();
             } else {
                 fail("Could not find object");
index 547db4977cc9b5197d3c28e25b547061303b8c27..08ba7dd62b18479b9bb5a3bf70169d1c353b3192 100644 (file)
@@ -34,7 +34,7 @@ public class FlowTopologyTestUtils {
     /**
      * Creates flow topology with link nodes (Links between ovs).
      */
-    public static void createFlowTopology(DataBroker dataBroker, List<Link> links){
+    public static void createFlowTopology(DataBroker dataBroker, List<Link> links) {
         TopologyBuilder topologyBuilder = new TopologyBuilder();
         topologyBuilder.setTopologyId(flowTopologyId);
         topologyBuilder.setLink(links);
@@ -42,7 +42,7 @@ public class FlowTopologyTestUtils {
         DataStoreTestUtils.write(topology,FLOW_TOPO_IID,dataBroker);
     }
 
-    public static Link createLink(String sourceNode, Long sourcePort, String destNode, Long destPort){
+    public static Link createLink(String sourceNode, Long sourcePort, String destNode, Long destPort) {
         LinkBuilder linkBuilder = new LinkBuilder();
         String sourcePortName = prefix + sourceNode + ":" + sourcePort.toString();
         String destPortName =  prefix + destNode + ":" + destPort;
index 581c4735838e8c0c9094d6beaa465458405b205d..ac982742047abeb73b4864933b81e0d600e02b50 100644 (file)
@@ -35,7 +35,7 @@ import java.util.List;
  */
 public class OpenFlowTopologyTestUtils {
 
-    public static void createOpenFlowNodes(List<Node> nodeList, DataBroker dataBroker){
+    public static void createOpenFlowNodes(List<Node> nodeList, DataBroker dataBroker) {
         NodesBuilder nodesBuilder = new NodesBuilder();
         nodesBuilder.setNode(nodeList);
         Nodes nodes = nodesBuilder.build();
@@ -43,7 +43,7 @@ public class OpenFlowTopologyTestUtils {
         DataStoreTestUtils.write(nodes,nodesIId,dataBroker);
     }
 
-    public static org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node createOpenFlowNode(String oFName, List<NodeConnector> nodeConnectorList){
+    public static org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node createOpenFlowNode(String oFName, List<NodeConnector> nodeConnectorList) {
         org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeBuilder nodeBuilder =
                 new org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeBuilder();
         org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId nodeId =
@@ -55,7 +55,7 @@ public class OpenFlowTopologyTestUtils {
         return nodeBuilder.build();
     }
 
-    public static NodeConnector createNodeConnector(String ofBridgeName, Long portNumber, String ovsdbPortName){
+    public static NodeConnector createNodeConnector(String ofBridgeName, Long portNumber, String ovsdbPortName) {
         NodeConnectorBuilder nodeConnectorBuilder = new NodeConnectorBuilder();
         String ofPortName = ofBridgeName + ":" + portNumber.toString();
         NodeConnectorId nodeConnectorId = new NodeConnectorId(ofPortName);
@@ -65,21 +65,21 @@ public class OpenFlowTopologyTestUtils {
         return nodeConnectorBuilder.build();
     }
 
-    private static FlowCapableNodeConnector createFlowCapableNodeConnector(String ovsdbName, Long portNumber){
+    private static FlowCapableNodeConnector createFlowCapableNodeConnector(String ovsdbName, Long portNumber) {
         FlowCapableNodeConnectorBuilder flowCapableNodeConnectorBuilder = new FlowCapableNodeConnectorBuilder();
         flowCapableNodeConnectorBuilder.setName(ovsdbName);
         flowCapableNodeConnectorBuilder.setPortNumber(new PortNumberUni(portNumber));
         return flowCapableNodeConnectorBuilder.build();
     }
 
-    public static FlowCapableNode createFlowCapableNode(){
+    public static FlowCapableNode createFlowCapableNode() {
         FlowCapableNodeBuilder flowCapableNodeBuilder = new FlowCapableNodeBuilder();
 
         flowCapableNodeBuilder.setTable(createOfTable());
         return flowCapableNodeBuilder.build();
     }
 
-    private static List<Table> createOfTable(){
+    private static List<Table> createOfTable() {
         List<Table> tables = new ArrayList<>();
         TableBuilder tableBuilder = new TableBuilder();
         tableBuilder.setId(Short.valueOf("0"));
@@ -89,7 +89,7 @@ public class OpenFlowTopologyTestUtils {
         return tables;
     }
 
-    public static InstanceIdentifier<NodeConnector> getNodeConnectorInstanceIdentifier(String ofBridgeName, String nodeConnectorId){
+    public static InstanceIdentifier<NodeConnector> getNodeConnectorInstanceIdentifier(String ofBridgeName, String nodeConnectorId) {
         return InstanceIdentifier.builder(Nodes.class)
                 .child(org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node.class,
                         new org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey(
index be69813a765f723387685c8d70a2a394455bdaaf..7421422a7c49a943d38b62a79ff56af75ca05503 100644 (file)
@@ -40,19 +40,19 @@ public class OvsdbTopologyTestUtils {
     /**
      * Ovsdb topology initializator.
      */
-    public static void createOvsdbTopology(DataBroker dataBroker){
+    public static void createOvsdbTopology(DataBroker dataBroker) {
         TopologyBuilder topologyBuilder = new TopologyBuilder();
         topologyBuilder.setTopologyId(ovsdbTopologyId);
         Topology topology = topologyBuilder.build();
         DataStoreTestUtils.write(topology,ovsdbTopology, dataBroker);
     }
 
-    public static void writeBridge(Node node, DataBroker dataBroker){
+    public static void writeBridge(Node node, DataBroker dataBroker) {
         InstanceIdentifier bridgeIid = getNodeInstanceIdentifier(node.getNodeId());
         DataStoreTestUtils.write(node,bridgeIid,dataBroker);
     }
 
-    public static Node createBridge(String nodeId, List<TerminationPoint> tps){
+    public static Node createBridge(String nodeId, List<TerminationPoint> tps) {
         NodeBuilder nodeBuilder = new NodeBuilder();
         nodeBuilder.setNodeId(new NodeId(nodeId));
         nodeBuilder.setTerminationPoint(tps);
@@ -60,7 +60,7 @@ public class OvsdbTopologyTestUtils {
         return nodeBuilder.build();
     }
 
-    public static InstanceIdentifier getNodeInstanceIdentifier(NodeId nodeId){
+    public static InstanceIdentifier getNodeInstanceIdentifier(NodeId nodeId) {
         return InstanceIdentifier
                 .builder(NetworkTopology.class)
                 .child(Topology.class,
@@ -70,13 +70,13 @@ public class OvsdbTopologyTestUtils {
                 .build();
     }
 
-    public static InstanceIdentifier getPortInstanceIdentifier(String nodeName, String portName){
+    public static InstanceIdentifier getPortInstanceIdentifier(String nodeName, String portName) {
         return getNodeInstanceIdentifier(new NodeId(nodeName))
                 .child(TerminationPoint.class,
                         new TerminationPointKey(new TpId(portName)));
     }
 
-    private static OvsdbBridgeAugmentation createOvsdbBridgeAugmentation(String ovsdbBridgeName){
+    private static OvsdbBridgeAugmentation createOvsdbBridgeAugmentation(String ovsdbBridgeName) {
         OvsdbBridgeAugmentationBuilder ovsdbBridgeAugmentationBuilder = new OvsdbBridgeAugmentationBuilder();
         ovsdbBridgeAugmentationBuilder.setBridgeName(new OvsdbBridgeName(ovsdbBridgeName));
         return ovsdbBridgeAugmentationBuilder.build();
index 9eec7bdefd5b8a5a337034f48b5bf01f90181d10..3bc5fcd821b606ecfd173b618d892a7c9e77f6d6 100644 (file)
@@ -74,7 +74,7 @@ public class OvsActivatorTest extends AbstractDataBrokerTest{
     List<String> of2InterwitchPorts = Arrays.asList("openflow:5:3", "openflow:5:4");
 
     @Before
-    public void setUp(){
+    public void setUp() {
         //given
         dataBroker = getDataBroker();
         ovsActivator = new OvsActivator(dataBroker);
@@ -84,7 +84,7 @@ public class OvsActivatorTest extends AbstractDataBrokerTest{
     }
 
     @Test
-    public void testActivate(){
+    public void testActivate() {
         //given
         List<EndPoint> endPoints = prepareEndpoints();
 
@@ -143,21 +143,21 @@ public class OvsActivatorTest extends AbstractDataBrokerTest{
         assertFalse(hasVlanFlows);
     };
 
-    private boolean hasVlanMatch(Flow flow){
-        if(flow.getMatch().getVlanMatch().getVlanId().getVlanId().getValue().equals(expectedVlanId)){
+    private boolean hasVlanMatch(Flow flow) {
+        if (flow.getMatch().getVlanMatch().getVlanId().getVlanId().getValue().equals(expectedVlanId)) {
             return true;
         }
         return false;
     }
 
-    private void checkTable(Nodes nodes, BiConsumer<Table,List<String>> checkTable){
+    private void checkTable(Nodes nodes, BiConsumer<Table,List<String>> checkTable) {
         nodes.getNode()
                 .forEach(node -> {
                     try {
                         Table t = OpenFlowUtils.getTable(node);
-                        if(node.getKey().getId().getValue().equals(ofPort1Name)){
+                        if (node.getKey().getId().getValue().equals(ofPort1Name)) {
                             checkTable.accept(t,of1InterwitchPorts);
-                        } else if(node.getKey().getId().getValue().equals(ofPort2Name)){
+                        } else if (node.getKey().getId().getValue().equals(ofPort2Name)) {
                             checkTable.accept(t,of2InterwitchPorts);
                         }
                     } catch (ResourceNotAvailableException e) {
@@ -166,14 +166,14 @@ public class OvsActivatorTest extends AbstractDataBrokerTest{
                 });
     }
 
-    private List<EndPoint> prepareEndpoints(){
+    private List<EndPoint> prepareEndpoints() {
         List<EndPoint> endPoints = new ArrayList<>();
         endPoints.add(mockEndPoint(port1Name));
         endPoints.add(mockEndPoint(port2Name));
         return endPoints;
     }
 
-    private EndPoint mockEndPoint(String portName){
+    private EndPoint mockEndPoint(String portName) {
         ConnectivityServiceEndPoint connectivityServiceEndPoint = mock(ConnectivityServiceEndPoint.class);
         NrpConnectivityServiceEndPointAttrs attrs = mock(NrpConnectivityServiceEndPointAttrs.class);
         //UNI port mock
@@ -206,7 +206,7 @@ public class OvsActivatorTest extends AbstractDataBrokerTest{
     /**
      * Add 5 ovsdb bridges and suitable openflow nodes
      */
-    private void initTopologies(){
+    private void initTopologies() {
         List<Node> bridges = new ArrayList<>();
         List<org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node> ofNodes = new ArrayList<>();
         bridges.add(createBridge("s1",5));
@@ -223,14 +223,14 @@ public class OvsActivatorTest extends AbstractDataBrokerTest{
         OpenFlowTopologyTestUtils.createOpenFlowNodes(ofNodes,dataBroker);
     }
 
-    private Node createBridge(String name, int portCount){
+    private Node createBridge(String name, int portCount) {
         List<TerminationPoint> tps = new ArrayList<>();
         IntStream.range(1,portCount+1)
                 .forEach(i -> tps.add(OvsdbTopologyTestUtils.createTerminationPoint(name+"-eth"+i,Long.valueOf(i))));
         return OvsdbTopologyTestUtils.createBridge(name, tps);
     }
 
-    private org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node createOpenFlowNode(Node node){
+    private org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node createOpenFlowNode(Node node) {
         String ovsdbName = node.getKey().getNodeId().getValue();
         String ofBridgeName = getOfName(ovsdbName);
 
@@ -241,12 +241,12 @@ public class OvsActivatorTest extends AbstractDataBrokerTest{
         return OpenFlowTopologyTestUtils.createOpenFlowNode(ofBridgeName,nodeConnectors);
     }
 
-    private String getOfName(String ovsdbName){
+    private String getOfName(String ovsdbName) {
         String bridgeNumber = ovsdbName.substring(1,ovsdbName.length());
         return "openflow:"+bridgeNumber;
     }
 
-    public static Nodes readOpenFLowTopology(DataBroker dataBroker){
+    public static Nodes readOpenFLowTopology(DataBroker dataBroker) {
         InstanceIdentifier instanceIdentifier = InstanceIdentifier.builder(Nodes.class).build();
         return (Nodes) MdsalUtils.read(dataBroker,LogicalDatastoreType.CONFIGURATION,instanceIdentifier);
     }
@@ -254,7 +254,7 @@ public class OvsActivatorTest extends AbstractDataBrokerTest{
     /**
      * @return List of links between ovswitches
      */
-    private static List<Link> getLinkList(){
+    private static List<Link> getLinkList() {
         List<Link> linkList = new ArrayList<>();
 
         //openflow nodes
index 860de5c562b57942377d54a5cd578731526934d0..480066588d5a21e1639a046b4f9a254ccb44c347 100644 (file)
@@ -45,7 +45,7 @@ public class TopologyDataHandlerTest extends AbstractDataBrokerTest{
     private static int initialBridgePortCount = 3;
 
     @Before
-    public void setUp(){
+    public void setUp() {
         //given
         dataBroker = getDataBroker();
         helper = new TopologyDataHandlerTestUtils(dataBroker);
@@ -61,7 +61,7 @@ public class TopologyDataHandlerTest extends AbstractDataBrokerTest{
     }
 
     @Test
-    public void testBridgeAddition(){
+    public void testBridgeAddition() {
         //when
         helper.createTestBridge();
 
@@ -73,7 +73,7 @@ public class TopologyDataHandlerTest extends AbstractDataBrokerTest{
     }
 
     @Test
-    public void testPortAddition(){
+    public void testPortAddition() {
         //given
         String newPortName = "br1-eth4";
         Long ofPortNumber = 4L;
@@ -92,7 +92,7 @@ public class TopologyDataHandlerTest extends AbstractDataBrokerTest{
     }
 
     @Test
-    public void testBridgeRemoval(){
+    public void testBridgeRemoval() {
         //given
         helper.createTestBridge();
         Node ovsNode = helper.readOvsNode();
@@ -107,7 +107,7 @@ public class TopologyDataHandlerTest extends AbstractDataBrokerTest{
     }
 
     @Test
-    public void testPortRemoval(){
+    public void testPortRemoval() {
         //given
         String fullPortNameToRemove = bridgeName+tp1Name;
         //helper.createTestBridge();
@@ -131,7 +131,7 @@ public class TopologyDataHandlerTest extends AbstractDataBrokerTest{
                                 && ownedNep.getUuid().getValue().equals(ovs_nep_prefix + nepName)
                     );
 
-    private void checkNeps(Node node,String ... neps){
+    private void checkNeps(Node node,String ... neps) {
         Arrays.stream(neps)
                 .forEach(nep -> assertTrue(checkNep.apply(node,nep)));
     }
@@ -140,12 +140,12 @@ public class TopologyDataHandlerTest extends AbstractDataBrokerTest{
             (sips, nep) -> sips.stream()
                 .anyMatch(sip -> sip.getUuid().getValue().equals(sip_prefix + ovs_nep_prefix + nep));
 
-    private void checkSips(List<ServiceInterfacePoint> sips, String ... neps){
+    private void checkSips(List<ServiceInterfacePoint> sips, String ... neps) {
         Arrays.stream(neps)
                 .forEach(nep -> assertTrue(checkSip.apply(sips,nep)));
     }
 
-    private List<Link> getLinkList(){
+    private List<Link> getLinkList() {
         List<Link> linkList = new ArrayList<>();
 
         //For testing purposes only - can't be find anywhere else in DataStore
index 1482895caa5b5fb9b3d64de608369731b798c7f3..54f4023dfd26b74f796c60692daf597235a517c4 100644 (file)
@@ -57,7 +57,7 @@ public class TopologyDataHandlerTestUtils {
 
     private final DataBroker dataBroker;
 
-    protected TopologyDataHandlerTestUtils(DataBroker dataBroker){
+    protected TopologyDataHandlerTestUtils(DataBroker dataBroker) {
         this.dataBroker = dataBroker;
     }
 
@@ -67,7 +67,7 @@ public class TopologyDataHandlerTestUtils {
      *  2. tp2 - nep
      *  3. tp3 - not nep, becouse it is connected to other switch
      */
-    public void createTestBridge(){
+    public void createTestBridge() {
         List<TerminationPoint> tps = new LinkedList<>();
 
         tps.add(OvsdbTopologyTestUtils.createTerminationPoint(tp1Name,tp1OFport));
@@ -79,17 +79,17 @@ public class TopologyDataHandlerTestUtils {
         DataStoreTestUtils.write(node,instanceIdentifier,dataBroker);
     }
 
-    protected void deleteTestBridge(){
+    protected void deleteTestBridge() {
         InstanceIdentifier instanceIdentifier = OvsdbTopologyTestUtils.getNodeInstanceIdentifier(new NodeId(bridgeName));
         DataStoreTestUtils.delete(instanceIdentifier,dataBroker);
     }
 
-    protected void deletePort(String port){
+    protected void deletePort(String port) {
         InstanceIdentifier<TerminationPoint> tpIid = OvsdbTopologyTestUtils.getPortInstanceIdentifier(bridgeName,port);
         DataStoreTestUtils.delete(tpIid,dataBroker);
     }
 
-    protected void addPort(String bridgeName, String portName, Long ofNumber){
+    protected void addPort(String bridgeName, String portName, Long ofNumber) {
         String bridgeId = bridgeName;
         //openflow init
         NodeConnector nodeConnector = OpenFlowTopologyTestUtils.createNodeConnector(ofBridgeName,ofNumber,portName);
@@ -108,7 +108,7 @@ public class TopologyDataHandlerTestUtils {
      *  2. id:"openflow:1:2", name: "br1-eth2", portNumber: "2"
      *  3. id:"openflow:1:3", name: "br1-eth3", portNumber: "3"
      */
-    protected void createOpenFlowNodes(){
+    protected void createOpenFlowNodes() {
         NodesBuilder nodesBuilder = new NodesBuilder();
         List<org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node> nodeList = new ArrayList<>();
         nodeList.add(createOpenFlowNode(ofBridgeName));
@@ -121,7 +121,7 @@ public class TopologyDataHandlerTestUtils {
         transaction.submit();
     }
 
-    private org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node createOpenFlowNode(String oFName){
+    private org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node createOpenFlowNode(String oFName) {
         org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeBuilder nodeBuilder =
                 new org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeBuilder();
         org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId nodeId =
@@ -136,7 +136,7 @@ public class TopologyDataHandlerTestUtils {
         return nodeBuilder.build();
     }
 
-    private NodeConnector createNodeConnector(String ofBridgeName, Long portNumber, String ovsdbPortName){
+    private NodeConnector createNodeConnector(String ofBridgeName, Long portNumber, String ovsdbPortName) {
         NodeConnectorBuilder nodeConnectorBuilder = new NodeConnectorBuilder();
         String ofPortName = ofBridgeName + ":" + portNumber.toString();
         NodeConnectorId nodeConnectorId = new NodeConnectorId(ofPortName);
@@ -146,14 +146,14 @@ public class TopologyDataHandlerTestUtils {
         return nodeConnectorBuilder.build();
     }
 
-    private FlowCapableNodeConnector createFlowCapableNodeConnector(String ovsdbName, Long portNumber){
+    private FlowCapableNodeConnector createFlowCapableNodeConnector(String ovsdbName, Long portNumber) {
         FlowCapableNodeConnectorBuilder flowCapableNodeConnectorBuilder = new FlowCapableNodeConnectorBuilder();
         flowCapableNodeConnectorBuilder.setName(ovsdbName);
         flowCapableNodeConnectorBuilder.setPortNumber(new PortNumberUni(portNumber));
         return flowCapableNodeConnectorBuilder.build();
     }
 
-    protected void createPrestoSystemTopology(){
+    protected void createPrestoSystemTopology() {
         NrpInitializer nrpInitializer = new NrpInitializer(dataBroker);
         try {
             nrpInitializer.init();
@@ -162,15 +162,15 @@ public class TopologyDataHandlerTestUtils {
         }
     }
 
-    protected org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.topology.rev170712.topology.Node readOvsNode(){
+    protected org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.topology.rev170712.topology.Node readOvsNode() {
         return DataStoreTestUtils.read(getNodeIid(),dataBroker);
     }
 
-    protected List<org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.common.rev170712.context.attrs.ServiceInterfacePoint> readSips(){
+    protected List<org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.common.rev170712.context.attrs.ServiceInterfacePoint> readSips() {
         ReadWriteTransaction readWriteTransaction = dataBroker.newReadWriteTransaction();
         try {
             Optional<Context> opt = readWriteTransaction.read(LogicalDatastoreType.OPERATIONAL, InstanceIdentifier.create(Context.class)).checkedGet();
-            if(opt.isPresent()){
+            if (opt.isPresent()) {
                 return opt.get().getServiceInterfacePoint();
             } else {
                 fail("There are no sips.");
@@ -181,13 +181,13 @@ public class TopologyDataHandlerTestUtils {
         return null;
     }
 
-    private static InstanceIdentifier getNodeIid(){
+    private static InstanceIdentifier getNodeIid() {
         return getTopoIid()
                 .child(org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.topology.rev170712.topology.Node.class,
                         new org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.topology.rev170712.topology.NodeKey(new Uuid(ovsNodeId)));
     }
 
-    private static InstanceIdentifier getTopoIid(){
+    private static InstanceIdentifier getTopoIid() {
         return InstanceIdentifier.create(Context.class)
                 .augmentation(Context1.class)
                 .child(org.opendaylight.yang.gen.v1.urn.mef.yang.tapi.topology.rev170712.topology.context.Topology.class,