Fix WARNING when port is updated with allowed_address_pairs

When a port is updated with allowed_address_pairs, a WARNING message is
logged in karaf eventhough the necessary ACL flows are programmed on
the port. This patch fixes this issue.

Warning logs seen in karaf:
Acl action UPDATE invoking listener org.opendaylight.netvirt.
aclservice.StatefulIngressAclServiceImpl failed

Change-Id: I5e3b20032ecd32b52d55995bad98253990e2858a
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

diff --git a/vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java b/vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java
index 743f84d431f9a62222513e9ef40f930b8f7b9cbf..c67d1559c036c81c8c63463bb848785688241adc 100644 (file)
--- a/vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java
+++ b/vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java
@@ -84,7 +84,7 @@ public abstract class AbstractAclServiceImpl implements AclServiceListener {
 
     @Override
     public boolean updateAcl(AclInterface portBefore, AclInterface portAfter) {
-        boolean result = false;
+        boolean result = true;
         boolean isPortSecurityEnable = portAfter.getPortSecurityEnabled();
         boolean isPortSecurityEnableBefore = portBefore.getPortSecurityEnabled();
         // if port security is changed, apply/remove Acls