Improve performance of XmlElement.getName
authorMaros Marsalek <mmarsale@cisco.com>
Sat, 18 Apr 2015 18:41:15 +0000 (20:41 +0200)
committerMaros Marsalek <mmarsale@cisco.com>
Sat, 18 Apr 2015 18:44:30 +0000 (20:44 +0200)
getLocalName on a DOM element was called 3x instead of 1.

Change-Id: Ibc758bd440f601adc76d8f62972950d30906610b
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/xml/XmlElement.java

index 4529f81e575e9245013319ab75fd43a9974c5a16..3d46bf6ab43f8cb353fa1a33009581a16af32f51 100644 (file)
@@ -143,8 +143,9 @@ public final class XmlElement {
     }
 
     public String getName() {
-        if (element.getLocalName()!=null && !element.getLocalName().equals(DEFAULT_NAMESPACE_PREFIX)){
-            return element.getLocalName();
+        final String localName = element.getLocalName();
+        if (!Strings.isNullOrEmpty(localName)){
+            return localName;
         }
         return element.getTagName();
     }