Remove deprecated ExperimenterActionSerializerKey constructor 66/92666/2
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 24 Sep 2020 11:15:02 +0000 (13:15 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 24 Sep 2020 14:50:32 +0000 (16:50 +0200)
This constructor is using widened Long argument and is not used
anywhere, remove it.

Change-Id: I41ef92b1957657c50d1bb5be7a0ca985851b5bf0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
openflowjava/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/keys/ExperimenterActionSerializerKey.java
openflowjava/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/connection/SwitchConnectionProviderImpl02Test.java

index e3397235cadaa572eff3bb7f0f87d8fe7e020d51..908bd983a204fd42eda480c581cfad2e2c858e81 100644 (file)
@@ -5,7 +5,6 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowjava.protocol.api.keys;
 
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.augments.rev150225.action.container.action.choice.ExperimenterIdCase;
@@ -34,20 +33,6 @@ public final class ExperimenterActionSerializerKey extends ActionSerializerKey<E
         this.actionSubType = actionSubType;
     }
 
-    /**
-     * Constructor.
-     *
-     * @param msgVersion protocol wire version
-     * @param experimenterId experimenter / vendor ID
-     * @param actionSubType vendor defined subtype
-     */
-    @Deprecated(forRemoval = true)
-    public ExperimenterActionSerializerKey(final short msgVersion, final Long experimenterId,
-            final Class<? extends ExperimenterActionSubType> actionSubType) {
-        super(msgVersion, ExperimenterIdCase.class, experimenterId);
-        this.actionSubType = actionSubType;
-    }
-
     @Override
     public int hashCode() {
         final int prime = 31;
index fcfc1a461f8e670bba017009c766862c3a0d2df1..c33289bd5110ef13cdc7f8beb49f90475bb0f248 100755 (executable)
@@ -51,6 +51,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.meter.band.header.meter.band.MeterBandExperimenterCase;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.queue.property.header.QueueProperty;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.table.features.properties.grouping.TableFeatureProperties;
+import org.opendaylight.yangtools.yang.common.Uint32;
 
 /**
  * Unit tests for SwitchConnectionProviderImpl02.
@@ -149,7 +150,8 @@ public class SwitchConnectionProviderImpl02Test {
         startUp(TransportProtocol.TCP);
         // -- registerActionSerializer
         final ExperimenterActionSerializerKey key1
-            = new ExperimenterActionSerializerKey(EncodeConstants.OF10_VERSION_ID, 42L, TestSubType.class);
+            = new ExperimenterActionSerializerKey(EncodeConstants.OF10_VERSION_ID, Uint32.valueOf(42),
+                TestSubType.class);
         provider.registerActionSerializer(key1, serializer);
         Assert.assertTrue("Wrong -- unregister ActionSerializer", provider.unregisterSerializer(key1));
         Assert.assertFalse("Wrong -- unregister ActionSerializer by not existing key",