Access ServiceReference bundle only once

Cache the result of getBundle(), as we will be needing it anyway.

JIRA: ODLPARENT-262
Change-Id: Ic3f12503ec2b81ac20165a9555900ff783e48a0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/features-test-plugin/src/main/java/org/opendaylight/odlparent/features/test/plugin/TestProbe.java b/features-test-plugin/src/main/java/org/opendaylight/odlparent/features/test/plugin/TestProbe.java
index 7385307548765bd44aab24c940590794a16c14d4..8733f6d0cf1f068fbb326c99c26823accb3fb17a 100644 (file)
--- a/features-test-plugin/src/main/java/org/opendaylight/odlparent/features/test/plugin/TestProbe.java
+++ b/features-test-plugin/src/main/java/org/opendaylight/odlparent/features/test/plugin/TestProbe.java
@@ -211,8 +211,8 @@ public final class TestProbe {
         // log services of NOK bundles
         try {
             for (var serviceRef : bundleContext.getAllServiceReferences(null, null)) {
-                if (serviceRef.getBundle() != null && nokBundles.contains(serviceRef.getBundle().getBundleId())) {
-                    final var bundle = serviceRef.getBundle();
+                final var bundle = serviceRef.getBundle();
+                if (bundle != null && nokBundles.contains(bundle.getBundleId())) {
                     final var usingBundles = serviceRef.getUsingBundles() == null ? List.of() :
                         Arrays.stream(serviceRef.getUsingBundles()).map(Bundle::getSymbolicName).toList();
                     final var propKeys = serviceRef.getPropertyKeys();