Do not shuffle PathArguments needlessly 43/100243/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 24 Mar 2022 12:30:16 +0000 (13:30 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 24 Mar 2022 13:48:39 +0000 (14:48 +0100)
There is no point in creating a separate collection if we are not
doing anything with it.

Change-Id: I3199c7232c63464b315eff8f69aac98181946ebd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 28b2c230f2277d53dd80892e95122d82276ec871)

restconf/restconf-common/src/main/java/org/opendaylight/restconf/common/serializer/AbstractWebsocketSerializer.java

index 369e3c97afb0c21eb7ce01745c61116a7d64d2e1..8dfcdef775fc23774d512dec6ec603405673aef5 100644 (file)
@@ -41,14 +41,13 @@ public abstract class AbstractWebsocketSerializer<T extends Exception> {
 
     public final void serialize(final DataTreeCandidate candidate, final boolean leafNodesOnly, final boolean skipData)
             throws T {
-        final Deque<PathArgument> path = new ArrayDeque<>();
-        path.addAll(candidate.getRootPath().getPathArguments());
         if (leafNodesOnly) {
+            final Deque<PathArgument> path = new ArrayDeque<>();
+            path.addAll(candidate.getRootPath().getPathArguments());
             serializeLeafNodesOnly(path, candidate.getRootNode(), skipData);
-            return;
+        } else {
+            serializeData(candidate.getRootPath().getPathArguments(), candidate.getRootNode(), skipData);
         }
-
-        serializeData(path, candidate.getRootNode(), skipData);
     }
 
     void serializeLeafNodesOnly(final Deque<PathArgument> path, final DataTreeCandidateNode candidate,