Enable checkstyle enforcement for the project

This patch enables checkstyle enforcements.
Also some checkstyle issues are not yet addressed
and those are added to the suppress file for now.
As some of those issues are addressed those will
be removed for the suppress file. The checkstyle
issues suppressed show as warnings during
compile.

Change-Id: I1c64aa426de7d29002e66c50367bbe84f23d885c
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

diff --git a/integration/test/pom.xml b/integration/test/pom.xml
index 0d98360d57595984e33f1ccd24c41b5380a80ede..39b39956ab84a53f2557297d6b22f33ee44e05cb 100644 (file)
--- a/integration/test/pom.xml
+++ b/integration/test/pom.xml
@@ -47,6 +47,24 @@
   <build>
     <pluginManagement>
       <plugins>
+         <plugin>
+          <artifactId>maven-checkstyle-plugin</artifactId>
+          <configuration>
+            <suppressionsLocation>../../parent/checkstyle-suppressions.xml</suppressionsLocation>
+            <suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression>
+            <excludes>org/opendaylight/yang/gen/**,**/yang/**</excludes>
+            <consoleOutput>true</consoleOutput>
+             <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
+          </configuration>
+          <executions>
+            <execution>
+              <goals>
+                <goal>check</goal>
+              </goals>
+              <phase>process-sources</phase>
+            </execution>
+          </executions>
+        </plugin>
         <plugin>
           <groupId>org.jacoco</groupId>
           <artifactId>jacoco-maven-plugin</artifactId>

diff --git a/parent/checkstyle-suppressions.xml b/parent/checkstyle-suppressions.xml
new file mode 100644 (file)
index 0000000..97c1ffe
--- /dev/null
+++ b/parent/checkstyle-suppressions.xml
@@ -0,0 +1,42 @@
+<?xml version="1.0"?>
+
+<!DOCTYPE suppressions PUBLIC
+     "-//Puppy Crawl//DTD Suppressions 1.0//EN"
+     "http://www.puppycrawl.com/dtds/suppressions_1_0.dtd">
+
+<suppressions>
+  <suppress checks="JavadocStyleCheck"
+            files="."
+             />
+  <suppress checks="SummaryJavadoc"
+            files="."
+             />
+  <suppress checks="JavadocParagraph"
+            files="."
+             />
+  <suppress checks="JavadocTagContinuationIndentation"
+            files="."
+             />
+  <suppress checks="AbbreviationAsWordInName"
+            files="."
+             />
+  <suppress checks="ParameterName"
+            files="."
+             />
+  <suppress checks="LocalVariableName"
+            files="."
+             />
+  <suppress checks="ConstantName"
+            files="."
+             />
+  <suppress checks="TypeName"
+            files="."
+             />
+  <suppress checks="IllegalCatch"
+            files="."
+             />
+  <suppress checks="RegexpSinglelineJava"
+            files="."
+             />
+</suppressions>
+

diff --git a/parent/pom.xml b/parent/pom.xml
index 77d28287441d993fcfa8bf2ac9dc4baf24f600bc..d73accafe851cf171aa4222500abff7229a33ef6 100644 (file)
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -73,6 +73,9 @@
           <configuration>
             <excludes>org/opendaylight/yang/gen/**,**/yang/**</excludes>
             <consoleOutput>true</consoleOutput>
+            <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+            <suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression>
+            <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
           </configuration>
           <executions>
             <execution>

diff --git a/transcriber/pom.xml b/transcriber/pom.xml
index a2f1931633fb044697d8653f8a37c5798577b8aa..4c112f35e2627e8d52a1942f08a8c19011cacb40 100644 (file)
--- a/transcriber/pom.xml
+++ b/transcriber/pom.xml
@@ -17,6 +17,24 @@
   </properties>
   <build>
     <plugins>
+      <plugin>
+          <artifactId>maven-checkstyle-plugin</artifactId>
+          <configuration>
+            <suppressionsLocation>../parent/checkstyle-suppressions.xml</suppressionsLocation>
+            <suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression>
+            <excludes>org/opendaylight/yang/gen/**,**/yang/**</excludes>
+            <consoleOutput>true</consoleOutput>
+             <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
+          </configuration>
+          <executions>
+            <execution>
+              <goals>
+                <goal>check</goal>
+              </goals>
+              <phase>process-sources</phase>
+            </execution>
+          </executions>
+      </plugin>
       <plugin>
         <groupId>org.apache.felix</groupId>
         <artifactId>maven-bundle-plugin</artifactId>