Bug 4713: Handle "missing-element" in RESTCONF.

RESTCONF should return HTTP status 400 (Bad Request) if "missing-element"
is found in RPC error tag.

Change-Id: Iaca7d219b656e86f43f1a7f297ea3c10d24ed410
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

diff --git a/opendaylight/restconf/sal-rest-connector/src/main/java/org/opendaylight/netconf/sal/restconf/impl/RestconfError.java b/opendaylight/restconf/sal-rest-connector/src/main/java/org/opendaylight/netconf/sal/restconf/impl/RestconfError.java
index aeed5ffe703804e7c4ebef990654bc25c7de16d5..c86706cedd705163060ffcbebaa5a29e03199812 100644 (file)
--- a/opendaylight/restconf/sal-rest-connector/src/main/java/org/opendaylight/netconf/sal/restconf/impl/RestconfError.java
+++ b/opendaylight/restconf/sal-rest-connector/src/main/java/org/opendaylight/netconf/sal/restconf/impl/RestconfError.java
@@ -54,6 +54,7 @@ public class RestconfError {
         MISSING_ATTRIBUTE("missing-attribute", 400 /* Bad Request */),
         BAD_ATTRIBUTE("bad-attribute", 400 /* Bad Request */),
         UNKNOWN_ATTRIBUTE("unknown-attribute", 400 /* Bad Request */),
+        MISSING_ELEMENT("missing-element", 400 /* Bad Request */),
         BAD_ELEMENT("bad-element", 400 /* Bad Request */),
         UNKNOWN_ELEMENT("unknown-element", 400 /* Bad Request */),
         UNKNOWN_NAMESPACE("unknown-namespace", 400 /* Bad Request */),

diff --git a/opendaylight/restconf/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/RestconfErrorTest.java b/opendaylight/restconf/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/RestconfErrorTest.java
index 8c98e2b25046193562891e924a5208eeadc7b00f..2fc629f686ebcc02f8e7cefca6a603129e5cfbb6 100644 (file)
--- a/opendaylight/restconf/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/RestconfErrorTest.java
+++ b/opendaylight/restconf/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/RestconfErrorTest.java
@@ -82,6 +82,7 @@ public class RestconfErrorTest {
         lookUpMap.put("missing-attribute", 400);
         lookUpMap.put("bad-attribute", 400);
         lookUpMap.put("unknown-attribute", 400);
+        lookUpMap.put("missing-element", 400);
         lookUpMap.put("bad-element", 400);
         lookUpMap.put("unknown-element", 400);
         lookUpMap.put("unknown-namespace", 400);