Remove findbugs support

FindBugs is obsolete, does not work with JDK9+ and replaced by
SpotBugs. Remove it from all declarations.

JIRA: ODLPARENT-186
Change-Id: Id8237ac38f8291954d041b0d4ca3becb5aea89ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/findbugs/pom.xml b/findbugs/pom.xml
deleted file mode 100644 (file)
index ece7c90..0000000
--- a/findbugs/pom.xml
+++ /dev/null
@@ -1,36 +0,0 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-  <modelVersion>4.0.0</modelVersion>
-
-  <parent>
-    <groupId>org.opendaylight.odlparent</groupId>
-    <artifactId>odlparent-lite</artifactId>
-    <version>5.0.0-SNAPSHOT</version>
-    <relativePath>../odlparent-lite</relativePath>
-  </parent>
-
-  <artifactId>findbugs</artifactId>
-  <name>ODL :: odlparent :: ${project.artifactId}</name>
-
-  <build>
-    <pluginManagement>
-      <plugins>
-        <plugin>
-          <artifactId>maven-jar-plugin</artifactId>
-          <version>3.1.1</version>
-        </plugin>
-        <plugin>
-          <artifactId>maven-resources-plugin</artifactId>
-          <version>3.1.0</version>
-        </plugin>
-      </plugins>
-    </pluginManagement>
-  </build>
-
-  <scm>
-    <connection>scm:git:ssh://git.opendaylight.org:29418/odlparent.git</connection>
-    <developerConnection>scm:git:ssh://git.opendaylight.org:29418/odlparent.git</developerConnection>
-    <tag>HEAD</tag>
-    <url>https://wiki.opendaylight.org/view/ODL_Root_Parent:Main</url>
-  </scm>
-
-</project>

diff --git a/findbugs/src/main/resources/findbugs-exclude.xml b/findbugs/src/main/resources/findbugs-exclude.xml
deleted file mode 100644 (file)
index f2be8a8..0000000
--- a/findbugs/src/main/resources/findbugs-exclude.xml
+++ /dev/null
@@ -1,30 +0,0 @@
-<FindBugsFilter>
-  <Match>
-    <Or>
-      <Package name="~.*protobuff\.messages.*" />
-      <Package name="~org\.opendaylight\.yang\.gen\..*" />
-    </Or>
-  </Match>
-
-  <Match>
-    <Or>
-      <!-- Anonymous inner classes are very common in ODL. -->
-      <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
-
-      <!-- We use static slf4j Logger (this rule is from KengoTODA/findbugs-slf4j jp.skypencil.findbugs.slf4:bug-pattern) -->
-      <Bug pattern="SLF4J_LOGGER_SHOULD_BE_NON_STATIC" />
-
-      <!-- Guava 23.6+ uses @NullableDecl which FindBugs doesn't know about; fixed in SpotBugs 3.1.2+ -->
-      <Bug pattern="NP_NONNULL_PARAM_VIOLATION" />
-      <Bug pattern="NP_NULL_PARAM_DEREF" />
-      <Bug pattern="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE" />
-      <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
-
-      <!-- https://github.com/spotbugs/spotbugs/issues/511. Strict reading of Object.equals() contract means that
-           evenever equals() behaviour is defined, all implementations need to adhere to it. The only reason
-           to override the method (assuming correct API design, of course) is to provide a more efficient
-           implementation. This rule would be forcing a @SuppressFBWarnings on perfectly compliant classes. -->
-      <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
-    </Or>
-  </Match>
-</FindBugsFilter>

diff --git a/odlparent-lite/pom.xml b/odlparent-lite/pom.xml
index b6f41486041457e818dc6d67166261613a31476c..9a0f6178506486c1168972bdbd44bb2f57db49bc 100644 (file)
--- a/odlparent-lite/pom.xml
+++ b/odlparent-lite/pom.xml
@@ -367,7 +367,6 @@
         <maven.javadoc.skip>true</maven.javadoc.skip>
         <maven.source.skip>true</maven.source.skip>
         <checkstyle.skip>true</checkstyle.skip>
-        <findbugs.skip>true</findbugs.skip>
         <spotbugs.skip>true</spotbugs.skip>
         <pmd.skip>true</pmd.skip>
         <cpd.skip>true</cpd.skip>

diff --git a/odlparent/pom.xml b/odlparent/pom.xml
index 827022de726f1f4a5814c709eca94285ec0a2220..4fe4405ab4b8814e4a216227f9f4ebf53d4dfa55 100644 (file)
--- a/odlparent/pom.xml
+++ b/odlparent/pom.xml
@@ -1528,57 +1528,6 @@
           <artifactId>build-helper-maven-plugin</artifactId>
           <version>3.0.0</version>
         </plugin>
-        <plugin>
-          <groupId>org.codehaus.mojo</groupId>
-          <artifactId>findbugs-maven-plugin</artifactId>
-          <version>3.0.5</version>
-          <dependencies>
-            <dependency>
-              <groupId>org.opendaylight.odlparent</groupId>
-              <artifactId>findbugs</artifactId>
-              <version>5.0.0-SNAPSHOT</version>
-            </dependency>
-          </dependencies>
-          <configuration>
-            <plugins>
-              <plugin>
-                <groupId>jp.skypencil.findbugs.slf4j</groupId>
-                <artifactId>bug-pattern</artifactId>
-                <!-- NOTE: This version SHOULD be kept in sync with the same version in the new spotbugs-maven-plugin below,
-                     but 1.4.1 broke compability with (the version we use of) FindBugs, so must keep this at 1.4.0. -->
-                <version>1.4.0</version>
-              </plugin>
-            </plugins>
-            <!--
-              Enables analysis which takes more memory but finds more bugs.
-              If you run out of memory, changes the value of the effort element
-              to 'Low'.
-            -->
-            <effort>Max</effort>
-            <!-- Reports all bugs (other values are medium and max) -->
-            <threshold>Low</threshold>
-            <!-- Build doesn't fail if problems are found -->
-            <failOnError>false</failOnError>
-            <!-- References the excluded rules -->
-            <excludeFilterFile>findbugs-exclude.xml</excludeFilterFile>
-            <!-- Produces XML report -->
-            <xmlOutput>true</xmlOutput>
-            <!-- Configures the directory in which the XML report is created -->
-            <findbugsXmlOutputDirectory>${project.build.directory}/findbugs</findbugsXmlOutputDirectory>
-          </configuration>
-          <executions>
-              <!--
-                Ensures that FindBugs inspects source code when project is compiled.
-              -->
-              <execution>
-                <id>analyze-compile</id>
-                <phase>compile</phase>
-                <goals>
-                  <goal>check</goal>
-                </goals>
-              </execution>
-          </executions>
-        </plugin>
         <plugin>
           <groupId>com.github.spotbugs</groupId>
           <artifactId>spotbugs-maven-plugin</artifactId>
@@ -2037,19 +1986,5 @@
       </plugin>
     </plugins>
   </reporting>
-
-  <profiles>
-    <profile>
-      <!-- On JDK9-and-later findbugs fails -->
-      <id>jdk9-findbugs</id>
-      <activation>
-        <jdk>[9,)</jdk>
-      </activation>
-      <properties>
-        <findbugs.skip>true</findbugs.skip>
-      </properties>
-    </profile>
-  </profiles>
-
 </project>
 

diff --git a/pom.xml b/pom.xml
index efe08d877d3272e6fd602e15e15f3e3716739276..d9b8b4697e1c589066a8d906bafff5188cf34336 100644 (file)
--- a/pom.xml
+++ b/pom.xml
@@ -34,7 +34,6 @@
     <modules>
         <!-- odlparent tools -->
         <module>checkstyle</module>
-        <module>findbugs</module>
         <module>spotbugs</module>
         <module>license</module>