This fixes up minor code smells reported by sonar.
Change-Id: Ic7abd5e431f2fc5e91ebc251d5a1e65d3c26c2bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
b4d93f9051c1847656a1e097c4409e3c92c2a274)
throw new UnsupportedOperationException("Utility class should not be instantiated");
}
- // FIXME: THis method does not search in case augmentations.
+ // FIXME: This method does not search in case augmentations.
public static Optional<DataNodeContainer> findDataNodeContainer(final SchemaContext ctx,
final InstanceIdentifier<?> path) {
Iterator<PathArgument> pathArguments = path.getPathArguments().iterator();
}
} else if (child instanceof DataNodeContainer && child.getQName().equals(targetQName)) {
return Optional.of((DataNodeContainer) child);
- } else if (child instanceof DataNodeContainer //
- && child.isAddedByUses() //
+ } else if (child instanceof DataNodeContainer && child.isAddedByUses()
&& child.getQName().getLocalName().equals(targetQName.getLocalName())) {
return Optional.of((DataNodeContainer) child);
}
// Configuration which we could tune as we use this more
private static final int MAX_DIFFS = 1;
- private static final int CONTEXT_LINES = 3; // number of lines of context output around each difference
+ // number of lines of context output around each difference
+ private static final int CONTEXT_LINES = 3;
private static final Splitter SPLITTER = Splitter.on(System.getProperty("line.separator"));
private static final Joiner JOINER = Joiner.on(System.getProperty("line.separator"));
// NB: The RetryingManagedNewTransactionRunnerTest is in mdsalutil-testutils's src/test, not this project's
- private static final int DEFAULT_RETRIES = 3; // duplicated in SingleTransactionDataBroker
+ // duplicated in SingleTransactionDataBroker
+ private static final int DEFAULT_RETRIES = 3;
private final int maxRetries;
private static final int STACK_TRACE_FIRST_RELEVANT_FRAME = 2;
- private final String type; // "default" VS "pingpong"
+ // "default" VS "pingpong"
+ private final String type;
private final BindingNormalizedNodeSerializer codec;
private final DOMDataBroker delegate;
private final List<Watch> registrationWatches = new ArrayList<>();