Remove trailing comments 03/84403/1
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 16 Aug 2019 11:20:53 +0000 (13:20 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 13 Sep 2019 14:39:15 +0000 (16:39 +0200)
This fixes up minor code smells reported by sonar.

Change-Id: Ic7abd5e431f2fc5e91ebc251d5a1e65d3c26c2bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b4d93f9051c1847656a1e097c4409e3c92c2a274)

binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/impl/BindingSchemaContextUtils.java
binding/mdsal-binding-test-utils/src/main/java/org/opendaylight/mdsal/binding/testutils/DiffUtil.java
binding/mdsal-binding-util/src/main/java/org/opendaylight/mdsal/binding/util/RetryingManagedNewTransactionRunnerImpl.java
trace/mdsal-trace-impl/src/main/java/org/opendaylight/mdsal/trace/impl/TracingBroker.java

index 8a371e332b499fe4af0d1d9cf8caccd13feb9611..70345d0e6bb213b7eac8eb8e7412359bfc5ac1de 100644 (file)
@@ -42,7 +42,7 @@ public final class BindingSchemaContextUtils {
         throw new UnsupportedOperationException("Utility class should not be instantiated");
     }
 
-    // FIXME: THis method does not search in case augmentations.
+    // FIXME: This method does not search in case augmentations.
     public static Optional<DataNodeContainer> findDataNodeContainer(final SchemaContext ctx,
             final InstanceIdentifier<?> path) {
         Iterator<PathArgument> pathArguments = path.getPathArguments().iterator();
@@ -99,8 +99,7 @@ public final class BindingSchemaContextUtils {
                 }
             } else if (child instanceof DataNodeContainer && child.getQName().equals(targetQName)) {
                 return Optional.of((DataNodeContainer) child);
-            } else if (child instanceof DataNodeContainer //
-                    && child.isAddedByUses() //
+            } else if (child instanceof DataNodeContainer && child.isAddedByUses()
                     && child.getQName().getLocalName().equals(targetQName.getLocalName())) {
                 return Optional.of((DataNodeContainer) child);
             }
index 232b02961ae4ff09aae4942157272ea1e992bf34..167b885c20cc17b29a53fb9e94bd9aaf20addcc8 100644 (file)
@@ -25,7 +25,8 @@ final class DiffUtil {
 
     // Configuration which we could tune as we use this more
     private static final int MAX_DIFFS = 1;
-    private static final int CONTEXT_LINES = 3; // number of lines of context output around each difference
+    // number of lines of context output around each difference
+    private static final int CONTEXT_LINES = 3;
 
     private static final Splitter SPLITTER = Splitter.on(System.getProperty("line.separator"));
     private static final Joiner JOINER = Joiner.on(System.getProperty("line.separator"));
index 412bcbea68d574a820663b0dc2019169fadd9429..9146a2ce9d00da43777465a700cc91137107beb9 100644 (file)
@@ -31,7 +31,8 @@ class RetryingManagedNewTransactionRunnerImpl implements ManagedNewTransactionRu
 
     // NB: The RetryingManagedNewTransactionRunnerTest is in mdsalutil-testutils's src/test, not this project's
 
-    private static final int DEFAULT_RETRIES = 3; // duplicated in SingleTransactionDataBroker
+    // duplicated in SingleTransactionDataBroker
+    private static final int DEFAULT_RETRIES = 3;
 
     private final int maxRetries;
 
index 5b02713a050a124007b33a8c8ba1f90fcba58009..1593e09d3796052dbe5aa0cd8300516221c3e3a3 100644 (file)
@@ -102,7 +102,8 @@ public class TracingBroker implements TracingDOMDataBroker {
 
     private static final int STACK_TRACE_FIRST_RELEVANT_FRAME = 2;
 
-    private final String type; // "default" VS "pingpong"
+    // "default" VS "pingpong"
+    private final String type;
     private final BindingNormalizedNodeSerializer codec;
     private final DOMDataBroker delegate;
     private final List<Watch> registrationWatches = new ArrayList<>();