OpenAPI: Delete no-op methods

Delete no-op methods which are not used or make them abstract
in case they are going to be implemented in child classes.

These methods are remnants from NETCONF-938 reimplementation.

Change-Id: I072717c5ef66329a5b202dc8804f51fdefad2c78
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

diff --git a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/DeleteEntity.java b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/DeleteEntity.java
index d0fb02342e6499845f7534cc3a4cbf0ca5621062..a53f6731fcb957fcbdbaa034f0bb691fd3dd8e32 100644 (file)
--- a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/DeleteEntity.java
+++ b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/DeleteEntity.java
@@ -36,6 +36,11 @@ public final class DeleteEntity extends OperationEntity {
         return SUMMARY_TEMPLATE.formatted(HttpMethod.DELETE, deviceName(), moduleName(), nodeName());
     }
 
+    @Override
+    void generateRequestBody(@NonNull JsonGenerator generator) throws IOException {
+        // no-op
+    }
+
     @Override
     void generateResponses(final @NonNull JsonGenerator generator) throws IOException {
         generator.writeObjectFieldStart(RESPONSES);

diff --git a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/GetEntity.java b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/GetEntity.java
index d6b662753448440a4f1811d173ec21aba22480a5..23baaba8f2e489e84247a1a6f636474e692f6a9c 100644 (file)
--- a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/GetEntity.java
+++ b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/GetEntity.java
@@ -40,6 +40,11 @@ public final class GetEntity extends OperationEntity {
         return SUMMARY_TEMPLATE.formatted(HttpMethod.GET, deviceName(), moduleName(), nodeName());
     }
 
+    @Override
+    void generateRequestBody(@NonNull JsonGenerator generator) throws IOException {
+        // no-op
+    }
+
     @Override
     void generateResponses(final @NonNull JsonGenerator generator) throws IOException {
         final var ref = COMPONENTS_PREFIX + moduleName() + "_" + refPath();

diff --git a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/OperationEntity.java b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/OperationEntity.java
index 58a0cb406e08d5fb40c623870ff7c09a383c80af..442958f7897bf30206d089c7c63b91660d5a36d1 100644 (file)
--- a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/OperationEntity.java
+++ b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/OperationEntity.java
@@ -110,13 +110,9 @@ public abstract sealed class OperationEntity extends OpenApiEntity permits Delet
 
     @NonNull abstract String summary();
 
-    void generateRequestBody(final @NonNull JsonGenerator generator) throws IOException {
-        // No-op
-    }
+    abstract void generateRequestBody(@NonNull JsonGenerator generator) throws IOException;
 
-    void generateResponses(final @NonNull JsonGenerator generator) throws IOException {
-        // No-op
-    }
+    abstract void generateResponses(@NonNull JsonGenerator generator) throws IOException;
 
     void generateTags(final @NonNull JsonGenerator generator) throws IOException {
         generator.writeArrayFieldStart("tags");

diff --git a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/SchemaEntity.java b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/SchemaEntity.java
index d651560773035c4b4d12c5b21934154b9b08e7b3..84c1d6f3ece4afa25b2b83564aca7a3c36d9c988 100644 (file)
--- a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/SchemaEntity.java
+++ b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/SchemaEntity.java
@@ -67,14 +67,6 @@ public final class SchemaEntity extends OpenApiEntity {
         if (description != null) {
             generator.writeStringField("description", description);
         }
-        final var reference = reference();
-        if (reference != null) {
-            generator.writeStringField("$ref", reference);
-        }
-        generateEnum(generator);
-        generateDiscriminator(generator);
-        generateExamples(generator);
-        generateExternalDocs(generator);
         generateProperties(generator);
         generateXml(generator);
         generator.writeEndObject();
@@ -94,14 +86,6 @@ public final class SchemaEntity extends OpenApiEntity {
             .orElse(value instanceof InputSchemaNode || value instanceof OutputSchemaNode ? null : "");
     }
 
-    private @Nullable String reference() {
-        return null;
-    }
-
-    private void generateEnum(final @NonNull JsonGenerator generator) throws IOException {
-        // No-op
-    }
-
     private void generateRequired(final @NonNull JsonGenerator generator, final List<String> required)
             throws IOException {
         if (!required.isEmpty()) {
@@ -113,18 +97,6 @@ public final class SchemaEntity extends OpenApiEntity {
         }
     }
 
-    private void generateDiscriminator(final @NonNull JsonGenerator generator) throws IOException {
-        // No-op
-    }
-
-    private void generateExamples(final @NonNull JsonGenerator generator) throws IOException {
-        // No-op
-    }
-
-    private void generateExternalDocs(final @NonNull JsonGenerator generator) throws IOException {
-        // No-op
-    }
-
     private void generateProperties(final @NonNull JsonGenerator generator) throws IOException {
         final var required = new ArrayList<String>();
         generator.writeObjectFieldStart("properties");