This patch revises yang model for neutron lbaasv2 and the related codes.
- drops decr for consistency, which isn't very useful
- fixes range of port/weight to match neutron lbaasv2 api
- eliminates deprecated methods in neutron-spi
Change-Id: Ic50d1c420dc22d19e6e2878f44d5624dc7d6bc88
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
grouping loadbalancer-attributes {
description "LBaaSV2.0 load balancer attributes.";
- leaf descr {
- type string;
- description "Load balancer description.";
- default "";
- }
leaf vip-address {
type inet:ip-address;
description "The IP address of the VIP.";
down (false).";
default "true";
}
- leaf descr {
- type string;
- description "Detailed description of the listener.";
- }
leaf protocol {
description "The protocol the front end listens for.";
type identityref {
leaf protocol-port {
description "The port on which the front end listens.";
type uint16 {
- range 1..65535;
+ range 0..65535;
}
}
leaf-list loadbalancers {
description "The administrative state of the pool, which is up (true) or
down (false).";
}
- leaf descr {
- type string;
- description "Detailed description of the listener.";
- }
leaf protocol {
description "The protocol the front end listens for.";
type identityref {
leaf protocol-port {
description "The port on which the application is hosted.";
type uint16 {
- range 1..65535;
+ range 0..65535;
}
}
leaf weight {
description "Weight of member.";
type uint16 {
- range 1..65535;
+ range 0..256;
}
default "1";
}
* id uuid-str
* tenant_id uuid-str
* name String
- * description String
* status String
* vip_address IP address
* vip_subnet uuid-str
@XmlElement (name = "name")
String loadBalancerName;
- @XmlElement (name = "description")
- String loadBalancerDescription;
-
@XmlElement (name = "status")
String loadBalancerStatus;
@XmlElement (name = "vip_subnet_id")
String loadBalancerVipSubnetID;
- // @deprecated use getID()
- public String getLoadBalancerID() {
- return getID();
- }
-
- // @deprecated use setID()
- public void setLoadBalancerID(String uuid) {
- setID(uuid);
- }
-
- @Deprecated
- public String getLoadBlancerTenantID() {
- return getTenantID();
- }
-
- @Deprecated
- public void setLoadBalancerTenantID(String tenantID) {
- setTenantID(tenantID);
- }
-
public String getLoadBalancerName() {
return loadBalancerName;
}
this.loadBalancerName = loadBalancerName;
}
- public String getLoadBalancerDescription() {
- return loadBalancerDescription;
- }
-
- public void setLoadBalancerDescription(String loadBalancerDescription) {
- this.loadBalancerDescription = loadBalancerDescription;
- }
-
public String getLoadBalancerStatus() {
return loadBalancerStatus;
}
if (s.equals("name")) {
ans.setLoadBalancerName(this.getLoadBalancerName());
}
- if(s.equals("description")) {
- ans.setLoadBalancerDescription(this.getLoadBalancerDescription());
- }
if (s.equals("vip_address")) {
ans.setLoadBalancerVipAddress(this.getLoadBalancerVipAddress());
}
"loadBalancerID='" + uuid + '\'' +
", loadBalancerTenantID='" + tenantID + '\'' +
", loadBalancerName='" + loadBalancerName + '\'' +
- ", loadBalancerDescription='" + loadBalancerDescription + '\'' +
", loadBalancerStatus='" + loadBalancerStatus + '\'' +
", loadBalancerAdminStateUp='" + loadBalancerAdminStateUp + '\'' +
", loadBalancerVipAddress='" + loadBalancerVipAddress + '\'' +
@XmlElement (name = "pools")
List<Neutron_ID> loadBalancerHealthMonitorPools;
- // @deprecated use getID()
- public String getLoadBalancerHealthMonitorID() {
- return getID();
- }
-
- // @deprecated use setID()
- public void setLoadBalancerHealthMonitorID(String uuid) {
- setID(uuid);
- }
-
- @Deprecated
- public String getLoadBalancerHealthMonitorTenantID() {
- return getTenantID();
- }
-
- @Deprecated
- public void setLoadBalancerHealthMonitorTenantID(String tenantID) {
- setTenantID(tenantID);
- }
-
public String getLoadBalancerHealthMonitorType() {
return loadBalancerHealthMonitorType;
}
* default_pool_id String
* tenant_id uuid-str
* name String
- * description String
* shared Bool
* protocol String
* protocol_port String
@XmlElement (name = "name")
String loadBalancerListenerName;
- @XmlElement (name = "description")
- String loadBalancerListenerDescription;
-
@XmlElement (defaultValue = "true", name = "admin_state_up")
Boolean loadBalancerListenerAdminStateIsUp;
@XmlElement (name = "load_balancers")
List<Neutron_ID> neutronLoadBalancerListenerLoadBalancerIDs;
- // @deprecated use getID()
- public String getLoadBalancerListenerID() {
- return getID();
- }
-
- // @deprecated use setID()
- public void setLoadBalancerListenerID(String uuid) {
- setID(uuid);
- }
-
- @Deprecated
- public String getLoadBalancerListenerTenantID() {
- return getTenantID();
- }
-
- @Deprecated
- public void setLoadBalancerListenerTenantID(String tenantID) {
- setTenantID(tenantID);
- }
-
public String getLoadBalancerListenerName() {
return loadBalancerListenerName;
}
this.loadBalancerListenerName = loadBalancerListenerName;
}
- public String getLoadBalancerListenerDescription() {
- return loadBalancerListenerDescription;
- }
-
- public void setLoadBalancerListenerDescription(String loadBalancerListenerDescription) {
- this.loadBalancerListenerDescription = loadBalancerListenerDescription;
- }
-
public Boolean getLoadBalancerListenerAdminStateIsUp() {
return loadBalancerListenerAdminStateIsUp;
}
if (s.equals("name")) {
ans.setLoadBalancerListenerName(this.getLoadBalancerListenerName());
}
- if(s.equals("description")) {
- ans.setLoadBalancerListenerDescription(this.getLoadBalancerListenerDescription());
- }
if (s.equals("protocol")) {
ans.setNeutronLoadBalancerListenerProtocol(this.getNeutronLoadBalancerListenerProtocol());
}
", neutronLoadBalancerListenerConnectionLimit='" + neutronLoadBalancerListenerConnectionLimit + '\'' +
", loadBalancerListenerTenantID='" + tenantID + '\'' +
", loadBalancerListenerName='" + loadBalancerListenerName + '\'' +
- ", loadBalancerListenerDescription='" + loadBalancerListenerDescription + '\'' +
", loadBalancerListenerAdminStateIsUp=" + loadBalancerListenerAdminStateIsUp +
", neutronLoadBalancerListenerProtocol='" + neutronLoadBalancerListenerProtocol + '\'' +
", neutronLoadBalancerListenerProtocolPort='" + neutronLoadBalancerListenerProtocolPort + '\'' +
* id uuid-str
* tenant_id uuid-str
* name String
- * description String
* protocol String
* lb_algorithm String
* healthmonitor_id String
@XmlElement (name = "name")
String loadBalancerPoolName;
- @XmlElement (name = "description")
- String loadBalancerPoolDescription;
-
@XmlElement (name = "protocol")
String loadBalancerPoolProtocol;
loadBalancerPoolMembers = new ArrayList<NeutronLoadBalancerPoolMember>();
}
- // @deprecated use getID()
- public String getLoadBalancerPoolID() {
- return getID();
- }
-
- // @deprecated use setID()
- public void setLoadBalancerPoolID(String uuid) {
- setID(uuid);
- }
-
- @Deprecated
- public String getLoadBalancerPoolTenantID() {
- return getTenantID();
- }
-
- @Deprecated
- public void setLoadBalancerPoolTenantID(String tenantID) {
- setTenantID(tenantID);
- }
-
public String getLoadBalancerPoolName() {
return loadBalancerPoolName;
}
this.loadBalancerPoolName = loadBalancerPoolName;
}
- public String getLoadBalancerPoolDescription() {
- return loadBalancerPoolDescription;
- }
-
- public void setLoadBalancerPoolDescription(String loadBalancerPoolDescription) {
- this.loadBalancerPoolDescription = loadBalancerPoolDescription;
- }
-
public String getLoadBalancerPoolProtocol() {
return loadBalancerPoolProtocol;
}
if (s.equals("name")) {
ans.setLoadBalancerPoolName(this.getLoadBalancerPoolName());
}
- if(s.equals("description")) {
- ans.setLoadBalancerPoolDescription(this.getLoadBalancerPoolDescription());
- }
if(s.equals("protocol")) {
ans.setLoadBalancerPoolProtocol(this.getLoadBalancerPoolProtocol());
}
"id='" + uuid + '\'' +
", tenantID='" + tenantID + '\'' +
", name='" + loadBalancerPoolName + '\'' +
- ", description='" + loadBalancerPoolDescription + '\'' +
", protocol=" + loadBalancerPoolProtocol +'\''+
", lbAlgorithm='" + loadBalancerPoolLbAlgorithm + '\'' +
", healthmonitorID=" + neutronLoadBalancerPoolHealthMonitorID +
this.poolID = poolID;
}
- // @deprecated use getID()
- public String getPoolMemberID() {
- return getID();
- }
-
- // @deprecated use setID()
- public void setPoolMemberID(String uuid) {
- setID(uuid);
- }
-
- @Deprecated
- public String getPoolMemberTenantID() {
- return getTenantID();
- }
-
- @Deprecated
- public void setPoolMemberTenantID(String tenantID) {
- setTenantID(tenantID);
- }
-
public String getPoolMemberAddress() {
return poolMemberAddress;
}
Assert.assertEquals("NeutronLoadBalancer JAXB Test 2: Testing LoadBalancer Name failed",
"NeutronLoadBalancer", testObject.getLoadBalancerName());
- Assert.assertEquals("NeutronLoadBalancer JAXB Test 3: Testing LoadBalancer Description failed",
- "NeutronLoadBalancer_Description", testObject.getLoadBalancerDescription());
-
Assert.assertEquals("NeutronLoadBalancer JAXB Test 4: Testing status failed", "ACTIVE",
testObject.getLoadBalancerStatus());
Assert.assertEquals("NeutronLoadBalancerListener JAXB Test 4: Testing LoadBalancer listener name failed",
"LoadBalancerListener", testObject.getLoadBalancerListenerName());
- Assert.assertEquals(
- "NeutronLoadBalancerListener JAXB Test 5: Testing LoadBalancer listener Description failed",
- "NeutronLoadBalancerListener_Description", testObject.getLoadBalancerListenerDescription());
-
Assert.assertFalse(
"NeutronLoadBalancerListener JAXB Test 6: Testing LoadBalancer listener admin_state_up failed",
testObject.getLoadBalancerListenerAdminStateIsUp());
Assert.assertTrue("NeutronLoadBalancerPool JAXB Test 3: Testing admin_state_up failed",
testObject.getLoadBalancerPoolAdminIsStateIsUp());
- Assert.assertEquals("NeutronLoadBalancerPool JAXB Test 4: Testing Description failed",
- "simple pool", testObject.getLoadBalancerPoolDescription());
-
Assert.assertEquals("NeutronLoadBalancerPool JAXB Test 5: Testing LbAlgorithm failed", "ROUND_ROBIN",
testObject.getLoadBalancerPoolLbAlgorithm());
@QueryParam("default_pool_id") String queryLoadBalancerListenerDefaultPoolID,
@QueryParam("tenant_id") String queryLoadBalancerListenerTenantID,
@QueryParam("name") String queryLoadBalancerListenerName,
- @QueryParam("description") String queryLoadBalancerListenerDescription,
@QueryParam("protocol") String queryLoadBalancerListenerProtocol,
@QueryParam("protocol_port") String queryLoadBalancerListenerProtocolPort,
@QueryParam("admin_state_up") Boolean queryLoadBalancerListenerAdminIsUp,
queryLoadBalancerListenerTenantID.equals(nsg.getTenantID())) &&
(queryLoadBalancerListenerName == null ||
queryLoadBalancerListenerName.equals(nsg.getLoadBalancerListenerName())) &&
- (queryLoadBalancerListenerDescription == null ||
- queryLoadBalancerListenerDescription.equals(nsg.getLoadBalancerListenerDescription())) &&
(queryLoadBalancerListenerProtocol == null ||
queryLoadBalancerListenerProtocol.equals(nsg.getNeutronLoadBalancerListenerProtocol())) &&
(queryLoadBalancerListenerProtocolPort == null ||
@QueryParam("id") String queryLoadBalancerID,
@QueryParam("tenant_id") String queryLoadBalancerTenantID,
@QueryParam("name") String queryLoadBalancerName,
- @QueryParam("description") String queryLoadBalancerDescription,
@QueryParam("status") String queryLoadBalancerStatus,
@QueryParam("vip_address") String queryLoadBalancerVipAddress,
@QueryParam("vip_subnet") String queryLoadBalancerVipSubnet,
queryLoadBalancerTenantID.equals(nsg.getTenantID())) &&
(queryLoadBalancerName == null ||
queryLoadBalancerName.equals(nsg.getLoadBalancerName())) &&
- (queryLoadBalancerDescription == null ||
- queryLoadBalancerDescription.equals(nsg.getLoadBalancerDescription())) &&
(queryLoadBalancerVipAddress == null ||
queryLoadBalancerVipAddress.equals(nsg.getLoadBalancerVipAddress())) &&
(queryLoadBalancerVipSubnet == null ||
@QueryParam("id") String queryLoadBalancerPoolID,
@QueryParam("tenant_id") String queryLoadBalancerPoolTenantID,
@QueryParam("name") String queryLoadBalancerPoolName,
- @QueryParam("description") String queryLoadBalancerDescription,
@QueryParam("protocol") String queryLoadBalancerProtocol,
@QueryParam("lb_algorithm") String queryLoadBalancerPoolLbAlgorithm,
@QueryParam("healthmonitor_id") String queryLoadBalancerPoolHealthMonitorID,
queryLoadBalancerPoolTenantID.equals(nsg.getTenantID())) &&
(queryLoadBalancerPoolName == null ||
queryLoadBalancerPoolName.equals(nsg.getLoadBalancerPoolName())) &&
- (queryLoadBalancerDescription == null ||
- queryLoadBalancerDescription.equals(nsg.getLoadBalancerPoolDescription())) &&
(queryLoadBalancerPoolLbAlgorithm == null ||
queryLoadBalancerPoolLbAlgorithm.equals(nsg.getLoadBalancerPoolLbAlgorithm())) &&
(queryLoadBalancerPoolHealthMonitorID == null ||
if (loadBalancer.isAdminStateUp() != null) {
answer.setLoadBalancerAdminStateUp(loadBalancer.isAdminStateUp());
}
- if (loadBalancer.getDescr() != null) {
- answer.setLoadBalancerDescription(loadBalancer.getDescr());
- }
if (loadBalancer.getName() != null) {
answer.setLoadBalancerName(loadBalancer.getName());
}
protected Loadbalancer toMd(NeutronLoadBalancer loadBalancer) {
final LoadbalancerBuilder loadBalancerBuilder = new LoadbalancerBuilder();
loadBalancerBuilder.setAdminStateUp(loadBalancer.getLoadBalancerAdminStateUp());
- if (loadBalancer.getLoadBalancerDescription() != null) {
- loadBalancerBuilder.setDescr(loadBalancer.getLoadBalancerDescription());
- }
if (loadBalancer.getLoadBalancerName() != null) {
loadBalancerBuilder.setName(loadBalancer.getLoadBalancerName());
}
if (listener.getNeutronLoadBalancerListenerDefaultPoolID() != null) {
listenerBuilder.setDefaultPoolId(toUuid(listener.getNeutronLoadBalancerListenerDefaultPoolID()));
}
- if (listener.getLoadBalancerListenerDescription() != null) {
- listenerBuilder.setDescr(listener.getLoadBalancerListenerDescription());
- }
if (listener.getNeutronLoadBalancerListenerLoadBalancerIDs() != null) {
final List<Uuid> listLoadBalancers = new ArrayList<Uuid>();
for (final Neutron_ID neutron_id : listener.getNeutronLoadBalancerListenerLoadBalancerIDs()) {
if (listener.getDefaultPoolId() != null) {
answer.setNeutronLoadBalancerListenerDefaultPoolID(listener.getDefaultPoolId().getValue());
}
- if (listener.getDescr() != null) {
- answer.setLoadBalancerListenerDescription(listener.getDescr());
- }
if (listener.getLoadbalancers() != null) {
final List<Neutron_ID> list = new ArrayList<Neutron_ID>();
for (final Uuid id : listener.getLoadbalancers()) {
protected Pool toMd(NeutronLoadBalancerPool pool) {
final PoolBuilder poolBuilder = new PoolBuilder();
poolBuilder.setAdminStateUp(pool.getLoadBalancerPoolAdminIsStateIsUp());
- if (pool.getLoadBalancerPoolDescription() != null) {
- poolBuilder.setDescr(pool.getLoadBalancerPoolDescription());
- }
if (pool.getNeutronLoadBalancerPoolHealthMonitorID() != null) {
poolBuilder.setHealthmonitorId(toUuid(pool.getNeutronLoadBalancerPoolHealthMonitorID()));
}
if (pool.isAdminStateUp() != null) {
answer.setLoadBalancerPoolAdminStateIsUp(pool.isAdminStateUp());
}
- if (pool.getDescr() != null) {
- answer.setLoadBalancerPoolDescription(pool.getDescr());
- }
if (pool.getHealthmonitorId() != null) {
answer.setNeutronLoadBalancerPoolHealthMonitorID(pool.getHealthmonitorId().getValue());
}