Merge "Update comment and remove unwanted FIXME in SchemaSetup"
authorTomas Cere <tcere@cisco.com>
Fri, 6 May 2016 10:26:49 +0000 (10:26 +0000)
committerGerrit Code Review <gerrit@opendaylight.org>
Fri, 6 May 2016 10:26:49 +0000 (10:26 +0000)
netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/NetconfDevice.java

index cc6e666980a1cf34dcfbb0f96735e612327ec379..a590c10850643ca26e7ba3596922fc475cd7943d 100644 (file)
@@ -402,10 +402,9 @@ public class NetconfDevice implements RemoteDevice<NetconfSessionPreferences, Ne
                     if (t instanceof MissingSchemaSourceException){
                         requiredSources = handleMissingSchemaSourceException(requiredSources, (MissingSchemaSourceException) t);
                     } else if (t instanceof SchemaResolutionException) {
-                        // FIXME do not wrap MissingSchemaSourceException in a
-                        // SchemaResolutionException. Somewhere this exception
-                        // is wrapped thus the instanceod isn't seeing the root
-                        // the cause of the exception.
+                        // schemaBuilderFuture.checkedGet() throws only SchemaResolutionException
+                        // that might be wrapping a MissingSchemaSourceException so we need to look
+                        // at the cause of the exception to make sure we don't misinterpret it.
                         if (t.getCause() instanceof MissingSchemaSourceException) {
                             requiredSources = handleMissingSchemaSourceException(requiredSources, (MissingSchemaSourceException) t.getCause());
                             continue;