LOG.debug("error on flat batch chain occurred -> skipping step {}", planStep.getStepType());
return FlatBatchUtil.createEmptyRpcBatchResultFuture(false);
}
-
- LOG.trace("batch progressing on step type {}", planStep.getStepType());
- LOG.trace("batch progressing previous steps result: {}", chainInput.isSuccessful());
-
+ LOG.trace("batch progressing on step type {}, previous steps result: {}", planStep.getStepType(),
+ chainInput.isSuccessful());
return getChainOutput(node, planStep, currentOffset);
}));
stepOffset += planStep.getTaskBag().size();
import org.slf4j.LoggerFactory;
/**
- * default implementation of {@link SalFlowsBatchService} - delegates work to {@link SalFlowService}
+ * Default implementation of {@link SalFlowsBatchService} - delegates work to {@link SalFlowService}.
*/
public class SalFlowsBatchServiceImpl implements SalFlowsBatchService {
private static final Logger LOG = LoggerFactory.getLogger(SalFlowsBatchServiceImpl.class);
import org.slf4j.LoggerFactory;
/**
- * default implementation of {@link SalGroupsBatchService} - delegates work to {@link SalGroupService}
+ * Default implementation of {@link SalGroupsBatchService} - delegates work to {@link SalGroupService}.
*/
public class SalGroupsBatchServiceImpl implements SalGroupsBatchService {
import org.slf4j.LoggerFactory;
/**
- * default implementation of {@link SalMetersBatchService} - delegates work to {@link SalMeterService}
+ * Default implementation of {@link SalMetersBatchService} - delegates work to {@link SalMeterService}.
*/
public class SalMetersBatchServiceImpl implements SalMetersBatchService {
import org.opendaylight.yang.gen.v1.urn.opendaylight.service.batch.common.rev160322.BatchOrderGrouping;
/**
- * Container of CRUD actions for one type of object (flow, group, meter, ..) of same type (add, remove, update)
+ * Container of CRUD actions for one type of object (flow, group, meter, ..) of same type (add, remove, update).
*/
public class BatchPlanStep {
private final List<? extends BatchOrderGrouping> taskBag;
import org.opendaylight.yangtools.yang.common.RpcResult;
/**
- * Wrapper for batch step jobs (type + function).
+ * Wrapper for batch step jobs ({@link BatchPlanStep} and corresponding transform function).
*/
public class BatchStepJob {
return stepFunction;
}
-
}
package org.opendaylight.openflowplugin.impl.services.batch;
/**
- * batch step types - holding combinations of target object type and action type (e.g.: flow + update)
+ * Batch step types - holding combinations of target object type and action type.
*/
public enum BatchStepType {
- /** flow -> add operation */FLOW_ADD,
- /** flow -> remove operation */FLOW_REMOVE,
- /** flow -> update operation */FLOW_UPDATE,
+ /** flow add operation */FLOW_ADD,
+ /** flow remove operation */FLOW_REMOVE,
+ /** flow update operation */FLOW_UPDATE,
- /** group -> add operation */GROUP_ADD,
- /** group -> remove operation */GROUP_REMOVE,
- /** group -> update operation */GROUP_UPDATE,
+ /** group add operation */GROUP_ADD,
+ /** group remove operation */GROUP_REMOVE,
+ /** group update operation */GROUP_UPDATE,
- /** meter -> add operation */METER_ADD,
- /** meter -> remove operation */METER_REMOVE,
- /** meter -> update operation */METER_UPDATE
+ /** meter add operation */METER_ADD,
+ /** meter remove operation */METER_REMOVE,
+ /** meter update operation */METER_UPDATE
}
import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
/**
- * transform between FlatBatch API and flow batch API
+ * Transform between FlatBatch API and flow batch API.
*/
public class FlatBatchFlowAdapters {
import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
/**
- * transform between FlatBatch API and group batch API
+ * Transform between FlatBatch API and group batch API.
*/
public class FlatBatchGroupAdapters {
import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
/**
- * transform between FlatBatch API and meter batch API
+ * Transform between FlatBatch API and meter batch API.
*/
public class FlatBatchMeterAdapters {
import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
/**
- * provides flat batch util methods
+ * Provides flat batch util methods.
*/
public final class FlatBatchUtil {
return type;
}
- /**
- * @return RPC result incorporating partial results (state, errors, batch failures)
- */
@VisibleForTesting
static Function<List<RpcResult<ProcessFlatBatchOutput>>, RpcResult<ProcessFlatBatchOutput>> mergeRpcResults() {
return jobsResults -> {
/**
* Merge list of Futures with partial results into one ListenableFuture with single result.
- * shortcut for {@link #mergeRpcResults()}
* @param firedJobs list of ListenableFutures with RPC results {@link ProcessFlatBatchOutput}
* @return ListenableFuture of RPC result with combined status and all errors + batch failures
*/
}
/**
- *
+ * Creates empty result future for flat batch service.
* @param status RPC result status
* @return ListenableFuture of RPC result with empty list of errors and batch failures
*/
Code Review / openflowplugin.git / commitdiff