Bug 5623 - BGP-LS Topology provider is not able to handle MPLS TE LSP NLRI Type 45/36945/2
authorMilos Fabian <milfabia@cisco.com>
Thu, 31 Mar 2016 10:56:01 +0000 (12:56 +0200)
committerRobert Varga <nite@hq.sk>
Fri, 1 Apr 2016 20:57:17 +0000 (20:57 +0000)
BGP-LS topology provider was throwing exception in a case of
unsupported NLRI types processing.
Soften a behaviour to debug message logging, as new BGP-LS
NLRI types are expected not to be exposed to the
topology (at least not now).

Change-Id: If2b6c2d5344fe39d78992a93ed969e1e1219f7ec
Signed-off-by: Milos Fabian <milfabia@cisco.com>
bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/LinkstateTopologyBuilder.java

index 96bae30be829884d0cf02b77be3f1c644f447dee..a171da1c97beb50906b5ba3be861f0b92560e728 100644 (file)
@@ -120,6 +120,8 @@ import org.slf4j.LoggerFactory;
 
 public final class LinkstateTopologyBuilder extends AbstractTopologyBuilder<LinkstateRoute> {
 
+    private static final String UNHANDLED_OBJECT_CLASS = "Unhandled object class {}";
+
     private static final class TpHolder {
         private final Set<LinkId> local = new HashSet<>();
         private final Set<LinkId> remote = new HashSet<>();
@@ -856,7 +858,7 @@ public final class LinkstateTopologyBuilder extends AbstractTopologyBuilder<Link
         } else if (t instanceof PrefixCase) {
             createPrefix(trans, base, value, (PrefixCase) t, value.getAttributes());
         } else {
-            throw new IllegalStateException("Unhandled object class " + t.getImplementedInterface());
+            LOG.debug(UNHANDLED_OBJECT_CLASS, t.getImplementedInterface());
         }
     }
 
@@ -873,7 +875,7 @@ public final class LinkstateTopologyBuilder extends AbstractTopologyBuilder<Link
         } else if (t instanceof PrefixCase) {
             removePrefix(trans, base, (PrefixCase) t);
         } else {
-            throw new IllegalStateException("Unhandled object class " + t.getImplementedInterface());
+            LOG.debug(UNHANDLED_OBJECT_CLASS, t.getImplementedInterface());
         }
     }