String performance and maintenability

Use StringBuilder for strings built in loops. Use plain concatenation
for string construction not involving loops.

Change-Id: I8299eb54a347d132f0d19dfb39c8fb52366049f2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

diff --git a/java/org/opendaylight/controller/cluster/common/actor/CommonConfig.java b/java/org/opendaylight/controller/cluster/common/actor/CommonConfig.java
index 84ac92e0eddeea5f400e0bd03c6b5488fcecab13..d57134d11dbddbaf051af31cee6cb7f9a3fcfed7 100644 (file)
--- a/java/org/opendaylight/controller/cluster/common/actor/CommonConfig.java
+++ b/java/org/opendaylight/controller/cluster/common/actor/CommonConfig.java
@@ -63,7 +63,7 @@ public class CommonConfig extends AbstractConfig {
             return cachedMailBoxCapacity;
         }
 
-        final String PATH = new StringBuilder(TAG_MAILBOX).append(".").append(TAG_MAILBOX_CAPACITY).toString();
+        final String PATH = TAG_MAILBOX + "." + TAG_MAILBOX_CAPACITY;
         cachedMailBoxCapacity = get().hasPath(PATH)
                 ? get().getInt(PATH)
                 : DEFAULT_MAILBOX_CAPACITY;
@@ -77,7 +77,7 @@ public class CommonConfig extends AbstractConfig {
             return cachedMailBoxPushTimeout;
         }
 
-        final String PATH = new StringBuilder(TAG_MAILBOX).append(".").append(TAG_MAILBOX_PUSH_TIMEOUT).toString();
+        final String PATH = TAG_MAILBOX + "." + TAG_MAILBOX_PUSH_TIMEOUT;
 
         long timeout = get().hasPath(PATH)
                 ? get().getDuration(PATH, TimeUnit.NANOSECONDS)

diff --git a/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java b/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java
index 8a8eed1daa96554c9bb2273cd28f42332e42d21c..63958912c48e8832a4c4b144eab84822e1b24b7a 100644 (file)
--- a/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java
+++ b/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java
@@ -61,8 +61,8 @@ public class MeteringBehavior implements Procedure<Object> {
     }
 
     private void init(final String actorName) {
-        actorQualifiedName = new StringBuilder(meteredActor.getSelf().path().parent().toStringWithoutAddress())
-                .append("/").append(actorName).toString();
+        actorQualifiedName = meteredActor.getSelf().path().parent().toStringWithoutAddress()
+                + "/" + actorName;
 
         final String msgProcessingTime = MetricRegistry.name(actorQualifiedName, MSG_PROCESSING_RATE);
         msgProcessingTimer = metricRegistry.timer(msgProcessingTime);

diff --git a/java/org/opendaylight/controller/cluster/notifications/LeaderStateChanged.java b/java/org/opendaylight/controller/cluster/notifications/LeaderStateChanged.java
index 359e2b221b55105c685c7ce4362b89b9fc86e628..5de794d902d69976aeb0761939aebb4470269d9a 100644 (file)
--- a/java/org/opendaylight/controller/cluster/notifications/LeaderStateChanged.java
+++ b/java/org/opendaylight/controller/cluster/notifications/LeaderStateChanged.java
@@ -42,9 +42,8 @@ public class LeaderStateChanged {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("LeaderStateChanged [memberId=").append(memberId).append(", leaderId=").append(leaderId)
-                .append(", leaderPayloadVersion=").append(leaderPayloadVersion).append("]");
-        return builder.toString();
+        return "LeaderStateChanged [memberId=" + memberId
+                + ", leaderId=" + leaderId
+                + ", leaderPayloadVersion=" + leaderPayloadVersion + "]";
     }
 }