Revert "Added the BufferId value on PacketIn." 74/10074/1
authorMoiz Raja <moraja@cisco.com>
Tue, 19 Aug 2014 17:30:56 +0000 (10:30 -0700)
committerMoiz Raja <moraja@cisco.com>
Tue, 19 Aug 2014 17:31:50 +0000 (10:31 -0700)
This reverts commit 6b45074c71dc31d0f17d06fd2f0885adb56429f7.

Change-Id: If94e01cb4f14305c0116d499f0d80f0e49cceb5b
Signed-off-by: Moiz Raja <moraja@cisco.com>
drop-test/src/main/java/org/opendaylight/openflowplugin/outputtest/OutputTestCommandProvider.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/PacketOutConvertor.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/translator/PacketInTranslator.java

index ed60bb4a198e1576ce5b8b6511f67bffcd39ca44..84d0f17977a020209924004075fbb73069d4e92e 100644 (file)
@@ -23,7 +23,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.acti
 import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.OutputPortValues;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorRef;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.BufferId;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingService;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.TransmitPacketInput;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.TransmitPacketInputBuilder;
@@ -139,7 +138,7 @@ public class OutputTestCommandProvider implements CommandProvider {
             packet_out.setNode(ref);
             packet_out.setIngress(nIngressConRef);
             packet_out.setEgress(nEngressConRef);
-            packet_out.setBufferId(new BufferId(0xffffffffL));
+            packet_out.setBufferId(Long.valueOf(0xffffffffL));
 
             packetProcessingService.transmitPacket(packet_out.build());
         } else {
index 551dbcfe1b98a7459f09c5c756d48db65db3ac03..1201009b101ff657f7c0c3cac6c56609a52b0309 100644 (file)
@@ -68,7 +68,7 @@ public class PacketOutConvertor {
 
         // Build Buffer ID to be NO_OFP_NO_BUFFER
         if (inputPacket.getBufferId() != null) {
-            bufferId = inputPacket.getBufferId().getValue();
+            bufferId = inputPacket.getBufferId();
         }
 
         PortNumber outPort = null;
index 0f3366dea53ce5c4ab142111ad4d6c90239972d2..429da6e31fa367ce2ae62fc0f9b807d77c6e7108 100644 (file)
@@ -32,7 +32,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.general.rev140714.GeneralAugMatchNotifPacketIn;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.general.rev140714.GeneralAugMatchNotifPacketInBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.general.rev140714.GeneralAugMatchNotifUpdateFlowStatsBuilder;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.BufferId;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.ConnectionCookie;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketReceived;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketReceivedBuilder;
@@ -57,10 +56,9 @@ public class PacketInTranslator implements IMDMessageTranslator<OfHeader, List<D
 
         if (sc != null && msg instanceof PacketInMessage) {
             PacketInMessage message = (PacketInMessage)msg;
-            LOG.trace("PacketIn[v{}]: Cookie: {} Match.type: {}, BufferId: {}",
+            LOG.trace("PacketIn[v{}]: Cookie: {} Match.type: {}",
                     message.getVersion(), message.getCookie(),
-                    message.getMatch() != null ? message.getMatch().getType() : message.getMatch(),
-                    message.getBufferId() != null ? message.getBufferId().toString() : "No buffer Id");
+                    message.getMatch() != null ? message.getMatch().getType() : message.getMatch());
 
            // create a packet received event builder
            PacketReceivedBuilder pktInBuilder = new PacketReceivedBuilder();
@@ -121,9 +119,6 @@ public class PacketInTranslator implements IMDMessageTranslator<OfHeader, List<D
                    pktInBuilder.setPacketInReason(PacketInUtil.getMdSalPacketInReason(message.getReason()));
                    pktInBuilder.setTableId(new org.opendaylight.yang.gen.v1.urn.opendaylight.table.types.rev131026.TableId(message.getTableId().getValue().shortValue()));
                    pktInBuilder.setIngress(InventoryDataServiceUtil.nodeConnectorRefFromDatapathIdPortno(dpid, port, ofVersion));
-                   if (message.getBufferId() != null) {
-                       pktInBuilder.setBufferId(new BufferId(message.getBufferId()));
-                   }
                    PacketReceived pktInEvent = pktInBuilder.build();
                    salPacketIn = Collections.<DataObject>singletonList(pktInEvent);
                }