Optimize ConstantArrayCollection.equals()

Use a single expression return, trimming the resulting method
size.

Change-Id: I5300ed93cc97de9b3b60ce885b6b8a13dd0c6927
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java b/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java
index 25d813c7e0630fe33becf4b9bc191b66862864fc..d843a36ddede5ba1e507d69a9917261084c1c7d2 100644 (file)
--- a/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java
+++ b/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java
@@ -136,14 +136,8 @@ final class ConstantArrayCollection<E> implements Collection<E>, Serializable {
 
     @Override
     public boolean equals(final Object obj) {
-        if (obj == this) {
-            return true;
-        }
-        if (!(obj instanceof ConstantArrayCollection)) {
-            return false;
-        }
-
-        return Arrays.equals(array, ((ConstantArrayCollection<?>) obj).array);
+        return obj == this || obj instanceof ConstantArrayCollection
+                && Arrays.equals(array, ((ConstantArrayCollection<?>) obj).array);
     }
 
     @Override