Access usingBundles only once

Cache the result of getUsingBundles() in a local variable, so we do not
access it twice.

JIRA: ODLPARENT-262
Change-Id: I895b5090783a018e5bbcb7adba0ac5cc672cf600
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/features-test-plugin/src/main/java/org/opendaylight/odlparent/features/test/plugin/TestProbe.java b/features-test-plugin/src/main/java/org/opendaylight/odlparent/features/test/plugin/TestProbe.java
index 8733f6d0cf1f068fbb326c99c26823accb3fb17a..617fd377af64532957b7d984283fbd4c48df7e9b 100644 (file)
--- a/features-test-plugin/src/main/java/org/opendaylight/odlparent/features/test/plugin/TestProbe.java
+++ b/features-test-plugin/src/main/java/org/opendaylight/odlparent/features/test/plugin/TestProbe.java
@@ -213,13 +213,14 @@ public final class TestProbe {
             for (var serviceRef : bundleContext.getAllServiceReferences(null, null)) {
                 final var bundle = serviceRef.getBundle();
                 if (bundle != null && nokBundles.contains(bundle.getBundleId())) {
-                    final var usingBundles = serviceRef.getUsingBundles() == null ? List.of() :
-                        Arrays.stream(serviceRef.getUsingBundles()).map(Bundle::getSymbolicName).toList();
+                    final var usingBundles = serviceRef.getUsingBundles();
+                    final var usingSymbolic = usingBundles == null ? List.of()
+                        : Arrays.stream(usingBundles).map(Bundle::getSymbolicName).toList();
                     final var propKeys = serviceRef.getPropertyKeys();
                     final var serviceProps = Arrays.stream(propKeys)
                         .collect(Collectors.toMap(Function.identity(), serviceRef::getProperty));
                     LOG.warn("NOK Service {} -> of bundle: {}, using: {}, props: {}",
-                        serviceRef.getClass().getName(), bundle.getSymbolicName(), usingBundles, serviceProps);
+                        serviceRef.getClass().getName(), bundle.getSymbolicName(), usingSymbolic, serviceProps);
                 }
             }
         } catch (InvalidSyntaxException e) {