Trim QNameModule.compare() 85/103385/2
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 25 Nov 2022 03:08:37 +0000 (04:08 +0100)
committerRobert Varga <nite@hq.sk>
Fri, 25 Nov 2022 09:28:58 +0000 (09:28 +0000)
Use assign-and-check to save a bit of bytecode.

Change-Id: Ie7bbad84938c824bd7bd427a94e11980538e6efc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QNameModule.java

index fc84ae2814762c1929e04bfb564dd0448c847ea6..0e0ffeb6c1873ee8fc58107d68c8811cb7d6682b 100644 (file)
@@ -124,11 +124,8 @@ public final class QNameModule implements Comparable<QNameModule>, Immutable, Se
     @Override
     @SuppressWarnings("checkstyle:parameterName")
     public int compareTo(final QNameModule o) {
-        int cmp = namespace.compareTo(o.namespace);
-        if (cmp != 0) {
-            return cmp;
-        }
-        return Revision.compare(revision, o.revision);
+        int cmp;
+        return (cmp = namespace.compareTo(o.namespace)) != 0 ? cmp : Revision.compare(revision, o.revision);
     }
 
     /**