Fix for NPE in ArpUtil 46/83046/3
authorNidhi <nidhi.adhvaryu@ericsson.com>
Mon, 15 Jul 2019 12:11:23 +0000 (17:41 +0530)
committerHema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Thu, 1 Aug 2019 09:54:48 +0000 (09:54 +0000)
Change-Id: I9411a1576cf2d74950b685a6bd2d10e5bb3ea0ab
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>
arputil/arputil-impl/src/main/java/org/opendaylight/genius/arputil/internal/ArpUtilImpl.java

index 86128f092afa22f352574df95a69e303a04e2e13..dab61e9b6f9d2afd2b657cc587a3010db3452dec 100644 (file)
@@ -459,8 +459,14 @@ public class ArpUtilImpl extends AbstractLifecycle implements OdlArputilService,
 
         Future<RpcResult<GetInterfaceFromIfIndexOutput>> interfaceFromIfIndex = odlInterfaceRpcService
                 .getInterfaceFromIfIndex(input);
-        GetInterfaceFromIfIndexOutput interfaceFromIfIndexOutput = interfaceFromIfIndex.get().getResult();
-        return interfaceFromIfIndexOutput.getInterfaceName();
+        if (interfaceFromIfIndex.get().isSuccessful()) {
+            GetInterfaceFromIfIndexOutput interfaceFromIfIndexOutput = interfaceFromIfIndex.get().getResult();
+            return interfaceFromIfIndexOutput.getInterfaceName();
+        } else {
+            LOG.error("RPC call to get interface name for if index {} failed with errors {}", lportTag,
+                interfaceFromIfIndex.get().getErrors());
+            return null;
+        }
     }
 
     private class MacResponderTask implements Runnable {