Remove unneeded default branches 73/112173/2
authorRobert Varga <robert.varga@pantheon.tech>
Sat, 15 Jun 2024 12:56:20 +0000 (14:56 +0200)
committerRobert Varga <nite@hq.sk>
Mon, 17 Jun 2024 08:52:28 +0000 (08:52 +0000)
We are using switch expressions which check for exhaustiveness -- hence
the default branches cannot ever be hit. Remove them.

Change-Id: Ib2d6a40e20faf12aa1c89c28180fd892e05624a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
data/yang-data-tree-spi/src/main/java/org/opendaylight/yangtools/yang/data/tree/spi/DataTreeCandidates.java

index d04725cc8af7892ddfc60de0a55558b743244f29..f491fe57a42b02a7e1443cb514b26df7ecc1b8ed 100644 (file)
@@ -264,8 +264,6 @@ public final class DataTreeCandidates {
                         case SUBTREE_MODIFIED ->
                             illegalModification(ModificationType.SUBTREE_MODIFIED, ModificationType.DELETE);
                         case DISAPPEARED -> illegalModification(ModificationType.DISAPPEARED, ModificationType.DELETE);
-                        default ->
-                            throw new IllegalStateException("Unsupported modification type " + secondModification);
                     };
                 }
                 if (secondModification == ModificationType.APPEARED) {
@@ -278,7 +276,6 @@ public final class DataTreeCandidates {
                     case DELETE -> ModificationType.DELETE;
                     case DISAPPEARED -> ModificationType.DISAPPEARED;
                     case APPEARED -> illegalModification(ModificationType.APPEARED, firstModification);
-                    default -> throw new IllegalStateException("Unsupported modification type " + secondModification);
                 };
             case DELETE:
                 return switch (secondModification) {
@@ -287,7 +284,6 @@ public final class DataTreeCandidates {
                     case DELETE -> illegalModification(ModificationType.DELETE, firstModification);
                     case DISAPPEARED -> illegalModification(ModificationType.DISAPPEARED, firstModification);
                     case SUBTREE_MODIFIED -> illegalModification(ModificationType.SUBTREE_MODIFIED, firstModification);
-                    default -> throw new IllegalStateException("Unsupported modification type " + secondModification);
                 };
             case APPEARED:
                 return switch (secondModification) {
@@ -295,7 +291,6 @@ public final class DataTreeCandidates {
                     case DELETE, DISAPPEARED -> ModificationType.UNMODIFIED;
                     case WRITE -> ModificationType.WRITE;
                     case APPEARED -> illegalModification(ModificationType.APPEARED, firstModification);
-                    default -> throw new IllegalStateException("Unsupported modification type " + secondModification);
                 };
             case DISAPPEARED:
                 return switch (secondModification) {
@@ -304,14 +299,12 @@ public final class DataTreeCandidates {
                     case DELETE -> illegalModification(ModificationType.DELETE, firstModification);
                     case DISAPPEARED -> illegalModification(ModificationType.DISAPPEARED, firstModification);
                     case SUBTREE_MODIFIED -> illegalModification(ModificationType.SUBTREE_MODIFIED, firstModification);
-                    default -> throw new IllegalStateException("Unsupported modification type " + secondModification);
                 };
             case SUBTREE_MODIFIED:
                 return switch (secondModification) {
                     case UNMODIFIED, SUBTREE_MODIFIED -> ModificationType.SUBTREE_MODIFIED;
                     case WRITE, DELETE, DISAPPEARED -> secondModification;
                     case APPEARED -> illegalModification(ModificationType.APPEARED, firstModification);
-                    default -> throw new IllegalStateException("Unsupported modification type " + secondModification);
                 };
             default:
                 throw new IllegalStateException("Unsupported modification type " + firstModification);