This patch revises yang model for neutron vpnaas and the related codes.
- remove descr for consistency, which isn't very useful
- pyang warning. unused import
- eliminate deprecated methods in neutron-spi
Change-Id: I04d055d4f3ee4b2232cabfb34722312447880a72
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
prefix neutron-vpnaas;
import ietf-yang-types { prefix "yang"; }
- import ietf-inet-types { prefix "inet"; revision-date 2010-09-24; }
import neutron-attrs { prefix "attrs"; }
organization "OpenDaylight Neutron Group";
}
grouping vpnservice-attributes {
- leaf descr {
- type string;
- description "Detailed description of the vpn service.";
- }
leaf router-id {
description "Contains the Router ID for the vpn service.";
type yang:uuid;
}
grouping ikepolicy-attributes {
- leaf descr {
- type string;
- description "Detailed description of the ike policy.";
- }
leaf auth-algorithm {
type string;
description "Authentication hash algorithm.";
}
grouping ipsecpolicy-attributes {
- leaf descr {
- type string;
- description "Detailed description of the ipsec policy.";
- }
leaf transform-protocol {
type string;
description "Transform protocol.";
}
grouping ipsecconnection-attributes {
- leaf descr {
- type string;
- description "Detailed description of the ipsec policy.";
- }
leaf peer_address {
type string;
description "Peer gateway public IPv4/IPv6 address or FQDN";
@XmlElement (name = "name")
String name;
- @XmlElement (name = "description")
- String description;
-
@XmlElement (name = "auth_algorithm")
String authAlgorithm;
this.name = name;
}
- public String getDescription() {
- return description;
- }
-
- public void setDescription(String description) {
- this.description = description;
- }
-
public String getAuthAlgorithm() {
return authAlgorithm;
}
if (s.equals("tenant_id")) {
ans.setTenantID(this.getTenantID());
}
- if (s.equals("description")) {
- ans.setDescription(this.getDescription());
- }
if (s.equals("auth_algorithm")) {
ans.setAuthAlgorithm(this.getAuthAlgorithm());
}
@XmlElement (name = "name")
String name;
- @XmlElement (name = "description")
- String description;
-
@XmlElement (name = "transform_protocol")
String transformProtocol;
this.name = name;
}
- public String getDescription() {
- return description;
- }
-
- public void setDescription(String description) {
- this.description = description;
- }
-
public String getTransformProtocol() {
return transformProtocol;
}
if (s.equals("name")) {
ans.setName(this.getName());
}
- if (s.equals("description")) {
- ans.setDescription(this.getDescription());
- }
if (s.equals("transform_protocol")) {
ans.setTransformProtocol(this.getTransformProtocol());
}
@XmlElement (name = "name")
String name;
- @XmlElement (name = "description")
- String description;
-
@XmlElement (name = "peer_address")
String peerAddress;
this.name = name;
}
- public String getDescription() {
- return description;
- }
-
- public void setDescription(String description) {
- this.description = description;
- }
-
public String getPeerAddress() {
return peerAddress;
}
if (s.equals("name")) {
ans.setName(this.getName());
}
- if (s.equals("description")) {
- ans.setDescription(this.getDescription());
- }
if (s.equals("peer_address")) {
ans.setPeerAddress(this.getPeerAddress());
}
@Override
public String toString() {
return "NeutronVPNIPSECSiteConnection{" + "id='" + uuid + '\'' + ", tenantID='" + tenantID + '\'' + ", name='"
- + name + '\'' + ", description=" + description + ", peerAddress=" + peerAddress + ", peerID='" + peerID
+ + name + '\'' + ", peerAddress=" + peerAddress + ", peerID='" + peerID
+ '\'' + ", routeMode='" + routeMode + '\'' + ", mtu=" + mtu + ", authMode='" + authMode + '\''
+ ", preSharedKey='" + preSharedKey + '\'' + ", initiator='" + initiator + '\'' + ", adminStateUp="
+ adminStateUp + ", status='" + status + '\'' + ", ikePolicyID='" + ikePolicyID + '\''
@XmlElement (name = "subnet_id")
String subnetUUID;
- @XmlElement (name = "description")
- String description;
-
public NeutronVPNService() {
}
this.subnetUUID = subnetUUID;
}
- public String getDescription() {
- return description;
- }
-
- public void setDescription(String description) {
- this.description = description;
- }
-
public NeutronVPNService extractFields(List<String> fields) {
NeutronVPNService ans = new NeutronVPNService();
Iterator<String> i = fields.iterator();
if (s.equals("admin_state_up")) {
ans.setAdminStateUp(this.getAdminStateUp());
}
- if (s.equals("description")) {
- ans.setDescription(this.getDescription());
- }
if (s.equals("name")) {
ans.setName(this.getName());
}
Assert.assertEquals("NeutronVPNIKEPolicy JAXB Test 3: Testing name failed",
"ikepolicy1", testObject.getName());
- Assert.assertEquals("NeutronVPNIKEPolicy JAXB Test 4: Testing description failed",
- "updated description", testObject.getDescription());
-
Assert.assertEquals("NeutronVPNIKEPolicy JAXB Test 5: Testing auth algorithm failed",
"sha1", testObject.getAuthAlgorithm());
Assert.assertEquals("NeutronVPNIPSECPolicy JAXB Test 3: Testing name failed",
"ipsecpolicy1", testObject.getName());
- Assert.assertEquals("NeutronVPNIPSECPolicy JAXB Test 4: Testing description failed",
- "update description", testObject.getDescription());
-
Assert.assertEquals("NeutronVPNIPSECPolicy JAXB Test 5: Testing transform protocol failed",
"esp", testObject.getTransformProtocol());
Assert.assertEquals("NeutronVPNIPSECSiteConnection JAXB Test 3: Testing name failed",
"myvpn", testObject.getName());
- Assert.assertEquals("NeutronVPNIPSECSiteConnection JAXB Test 4: Testing description failed",
- "Updated description", testObject.getDescription());
-
Assert.assertEquals("NeutronVPNIPSECSiteConnection JAXB Test 5: Testing peer address failed",
"172.24.4.226", testObject.getPeerAddress());
Assert.assertEquals("NeutronVPNService JAXB Test 7: Testing id failed",
"9faaf49f-dd89-4e39-a8c6-101839aa49bc", testObject.getID());
-
- Assert.assertEquals("NeutronVPNService JAXB Test 8: Testing description failed",
- "Updated description", testObject.getDescription());
}
catch (Exception e) {
Assert.fail("Tests failed");
@QueryParam("id") String queryID,
@QueryParam("name") String queryName,
@QueryParam("tenant_id") String queryTenantID,
- @QueryParam("description") String queryDescription,
@QueryParam("auth_algorithm") String queryAuthAlgorithm,
@QueryParam("encryption_algorithm") String queryEncryptionAlgorithm,
@QueryParam("phase1_negotiation_mode") String queryPhase1NegotiationMode,
NeutronVPNIKEPolicy oSS = i.next();
if ((queryID == null || queryID.equals(oSS.getID())) &&
(queryName == null || queryName.equals(oSS.getName())) &&
- (queryDescription == null || queryDescription.equals(oSS.getDescription())) &&
(queryAuthAlgorithm == null || queryAuthAlgorithm.equals(oSS.getAuthAlgorithm())) &&
(queryEncryptionAlgorithm == null || queryEncryptionAlgorithm.equals(oSS.getEncryptionAlgorithm())) &&
(queryPhase1NegotiationMode == null || queryPhase1NegotiationMode.equals(oSS.getPhase1NegotiationMode())) &&
@QueryParam("id") String queryID,
@QueryParam("tenant_id") String queryTenantID,
@QueryParam("name") String queryName,
- @QueryParam("description") String queryDescription,
@QueryParam("transform_protocol") String queryTransformProtocol,
@QueryParam("encapsulation_mode") String queryEncapsulationMode,
@QueryParam("auth_algorithm") String queryAuthAlgorithm,
NeutronVPNIPSECPolicy oSS = i.next();
if ((queryID == null || queryID.equals(oSS.getID())) &&
(queryName == null || queryName.equals(oSS.getName())) &&
- (queryDescription == null || queryDescription.equals(oSS.getDescription())) &&
(queryAuthAlgorithm == null || queryAuthAlgorithm.equals(oSS.getAuthAlgorithm())) &&
(queryEncryptionAlgorithm == null || queryEncryptionAlgorithm.equals(oSS.getEncryptionAlgorithm())) &&
(queryPFS == null || queryPFS.equals(oSS.getPerfectForwardSecrecy())) &&
@QueryParam("fields") List<String> fields,
// filter fields
@QueryParam("id") String queryID, @QueryParam("tenant_id") String queryTenantID,
- @QueryParam("name") String queryName, @QueryParam("description") String queryDescription,
+ @QueryParam("name") String queryName,
@QueryParam("peer_address") String queryPeerAddress, @QueryParam("peer_id") String queryPeerID,
@QueryParam("route_mode") String queryRouteMode, @QueryParam("mtu") Integer queryMtu,
@QueryParam("auth_mode") String queryAuthMode, @QueryParam("psk") String queryPsk,
if ((queryID == null || queryID.equals(oSS.getID()))
&& (queryTenantID == null || queryTenantID.equals(oSS.getTenantID()))
&& (queryName == null || queryName.equals(oSS.getName()))
- && (queryDescription == null || queryDescription.equals(oSS.getDescription()))
&& (queryPeerAddress == null || queryPeerAddress.equals(oSS.getPeerAddress()))
&& (queryPeerID == null || queryPeerID.equals(oSS.getPeerID()))
&& (queryRouteMode == null || queryRouteMode.equals(oSS.getRouteMode()))
if (ikePolicy.getTenantId() != null) {
answer.setTenantID(ikePolicy.getTenantId());
}
- if (ikePolicy.getDescr() != null) {
- answer.setDescription(ikePolicy.getDescr());
- }
if (ikePolicy.getAuthAlgorithm() != null) {
answer.setAuthAlgorithm(ikePolicy.getAuthAlgorithm());
}
if (ikePolicy.getTenantID() != null) {
ikePolicyBuilder.setTenantId(toUuid(ikePolicy.getTenantID()));
}
- if (ikePolicy.getDescription() != null) {
- ikePolicyBuilder.setDescr(ikePolicy.getDescription());
- }
if (ikePolicy.getAuthAlgorithm() != null) {
ikePolicyBuilder.setAuthAlgorithm(ikePolicy.getAuthAlgorithm());
}
if (ipsecPolicy.getTenantId() != null) {
answer.setTenantID(ipsecPolicy.getTenantId());
}
- if (ipsecPolicy.getDescr() != null) {
- answer.setDescription(ipsecPolicy.getDescr());
- }
if (ipsecPolicy.getAuthAlgorithm() != null) {
answer.setAuthAlgorithm(ipsecPolicy.getAuthAlgorithm());
}
if (ipsecPolicy.getTenantID() != null) {
ipsecPolicyBuilder.setTenantId(toUuid(ipsecPolicy.getTenantID()));
}
- if (ipsecPolicy.getDescription() != null) {
- ipsecPolicyBuilder.setDescr(ipsecPolicy.getDescription());
- }
if (ipsecPolicy.getAuthAlgorithm() != null) {
ipsecPolicyBuilder.setAuthAlgorithm(ipsecPolicy.getAuthAlgorithm());
}
if (ipsecSiteConnection.isAdminStateUp() != null) {
answer.setAdminStateUp(ipsecSiteConnection.isAdminStateUp());
}
- if (ipsecSiteConnection.getDescr() != null) {
- answer.setDescription(ipsecSiteConnection.getDescr());
- }
if (ipsecSiteConnection.getPeerAddress() != null) {
answer.setPeerAddress(ipsecSiteConnection.getPeerAddress());
}
if (ipsecSiteConnection.getAdminStateUp() != null) {
ipsecSiteConnectionBuilder.setAdminStateUp(ipsecSiteConnection.getAdminStateUp());
}
- if (ipsecSiteConnection.getDescription() != null) {
- ipsecSiteConnectionBuilder.setDescr(ipsecSiteConnection.getDescription());
- }
if (ipsecSiteConnection.getPeerAddress() != null) {
ipsecSiteConnectionBuilder.setPeerAddress(ipsecSiteConnection.getPeerAddress());
}
if (vpnService.getStatus() != null) {
answer.setStatus(vpnService.getStatus());
}
- if (vpnService.getDescr() != null) {
- answer.setDescription(vpnService.getDescr());
- }
if (vpnService.getSubnetId() != null) {
answer.setSubnetUUID(vpnService.getSubnetId().getValue());
}
if (vpnService.getStatus() != null) {
vpnServiceBuilder.setStatus(vpnService.getStatus());
}
- if (vpnService.getDescription() != null) {
- vpnServiceBuilder.setDescr(vpnService.getDescription());
- }
if (vpnService.getSubnetUUID() != null) {
vpnServiceBuilder.setSubnetId(toUuid(vpnService.getSubnetUUID()));
}