Remove explicit default super-constructor calls

The default constructor is called by default (hence its name), no need
to call it explicitly. Based on this commit [1].

[1] https://git.opendaylight.org/gerrit/#/c/63526/

Change-Id: Ia7a4ccf88c328aab9feade1252a06e2c94b660ac
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

diff --git a/vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceUtils.java b/vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceUtils.java
index fac2529937e7b8cf9cf9d25b53c7bb3775b247db..29631149eb4b54ade53ad5607a6f6321dd1a9f2c 100644 (file)
--- a/vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceUtils.java
+++ b/vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceUtils.java
@@ -129,7 +129,6 @@ public final class AclServiceUtils {
 
     @Inject
     public AclServiceUtils(AclDataUtil aclDataUtil, AclserviceConfig config, IdManagerService idManager) {
-        super();
         this.aclDataUtil = aclDataUtil;
         this.config = config;
         this.idManager = idManager;

diff --git a/vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/AclServiceTestModule.java b/vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/AclServiceTestModule.java
index fbf1ff87166ddf63accfd1dfe2f21920719d5897..fdcbc7e7d2f334bbc0235b977e30b18c8f862704 100644 (file)
--- a/vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/AclServiceTestModule.java
+++ b/vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/AclServiceTestModule.java
@@ -49,7 +49,6 @@ public class AclServiceTestModule extends AbstractModule {
     final SecurityGroupMode securityGroupMode;
 
     public AclServiceTestModule(SecurityGroupMode securityGroupMode) {
-        super();
         this.securityGroupMode = securityGroupMode;
     }
 

diff --git a/vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/infra/DataBrokerPairsUtil.java b/vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/infra/DataBrokerPairsUtil.java
index 9b237b79937803f81f65b69ec0ed5c3f0ddddf72..b6608409102da3ae5c4595f39d60c17511038bbc 100644 (file)
--- a/vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/infra/DataBrokerPairsUtil.java
+++ b/vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/infra/DataBrokerPairsUtil.java
@@ -37,7 +37,6 @@ public class DataBrokerPairsUtil {
 
     @Inject
     public DataBrokerPairsUtil(DataBroker db) {
-        super();
         this.singleTxDB = new SingleTransactionDataBroker(db);
     }
 

diff --git a/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpAllocationPoolRemoveJob.java b/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpAllocationPoolRemoveJob.java
index 3e9e784f8f3812406df9a170ddb6dbee93ab1c2c..6012fcfbf0b8ec20c9c12360ca30b8c0e1ff492b 100644 (file)
--- a/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpAllocationPoolRemoveJob.java
+++ b/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpAllocationPoolRemoveJob.java
@@ -21,7 +21,6 @@ public class DhcpAllocationPoolRemoveJob implements Callable<List<ListenableFutu
     private final String interfaceName;
 
     public DhcpAllocationPoolRemoveJob(DataBroker dataBroker, String interfaceName) {
-        super();
         this.dataBroker = dataBroker;
         this.interfaceName = interfaceName;
     }
@@ -36,5 +35,4 @@ public class DhcpAllocationPoolRemoveJob implements Callable<List<ListenableFutu
         DhcpServiceUtils.unbindDhcpService(interfaceName, unbindServiceTx);
         return Collections.singletonList(unbindServiceTx.submit());
     }
-
 }

diff --git a/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceAddJob.java b/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceAddJob.java
index d231775ca26871f44b02b6182ffc9fd7ab47ff7d..93568d883e4d15526d6e20a1c151aedf49ee57a2 100644 (file)
--- a/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceAddJob.java
+++ b/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceAddJob.java
@@ -69,7 +69,6 @@ public class DhcpInterfaceAddJob implements Callable<List<ListenableFuture<Void>
     public DhcpInterfaceAddJob(DhcpManager dhcpManager, DhcpExternalTunnelManager dhcpExternalTunnelManager,
                                DataBroker dataBroker, Interface interfaceAdd, BigInteger dpnId,
                                IInterfaceManager interfaceManager, IElanService elanService) {
-        super();
         this.dhcpManager = dhcpManager;
         this.dhcpExternalTunnelManager = dhcpExternalTunnelManager;
         this.dataBroker = dataBroker;

diff --git a/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceRemoveJob.java b/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceRemoveJob.java
index a7da1c24a6e2f28291fbeb4b2612b7e4db517fe3..5ef298525db936d38431c94b06af3ab9725de5bd 100644 (file)
--- a/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceRemoveJob.java
+++ b/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceRemoveJob.java
@@ -63,7 +63,6 @@ public class DhcpInterfaceRemoveJob implements Callable<List<ListenableFuture<Vo
                                   DataBroker dataBroker,
                                   Interface interfaceDel, BigInteger dpnId, IInterfaceManager interfaceManager,
                                   IElanService elanService) {
-        super();
         this.dhcpManager = dhcpManager;
         this.dhcpExternalTunnelManager = dhcpExternalTunnelManager;
         this.dataBroker = dataBroker;

diff --git a/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceUpdateJob.java b/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceUpdateJob.java
index 8962c09addb1d54105025260b5c38538b028544f..e5c81eca7f828a4f5ded47fb84f4ed187fb99152 100644 (file)
--- a/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceUpdateJob.java
+++ b/vpnservice/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceUpdateJob.java
@@ -36,7 +36,6 @@ public class DhcpInterfaceUpdateJob implements Callable<List<ListenableFuture<Vo
     public DhcpInterfaceUpdateJob(DhcpExternalTunnelManager dhcpExternalTunnelManager,
                                   DataBroker dataBroker, String interfaceName, BigInteger dpnId,
                                   OperStatus operStatus, IInterfaceManager interfaceManager) {
-        super();
         this.dhcpExternalTunnelManager = dhcpExternalTunnelManager;
         this.dataBroker = dataBroker;
         this.interfaceName = interfaceName;

diff --git a/vpnservice/elanmanager/elanmanager-api/src/main/java/org/opendaylight/netvirt/elan/arp/responder/ArpResponderInput.java b/vpnservice/elanmanager/elanmanager-api/src/main/java/org/opendaylight/netvirt/elan/arp/responder/ArpResponderInput.java
index e2ba332bb453ec6d57fcac517ad1fc7e04fa77f1..b874da2b9373c1e5fc758c1a389e865b25d0d58c 100644 (file)
--- a/vpnservice/elanmanager/elanmanager-api/src/main/java/org/opendaylight/netvirt/elan/arp/responder/ArpResponderInput.java
+++ b/vpnservice/elanmanager/elanmanager-api/src/main/java/org/opendaylight/netvirt/elan/arp/responder/ArpResponderInput.java
@@ -87,7 +87,6 @@ public class ArpResponderInput {
         }
 
         public ArpReponderInputBuilder(ArpResponderInput input) {
-            super();
             this.input = input;
         }
 

diff --git a/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronTrunkChangeListener.java b/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronTrunkChangeListener.java
index 99b680a6b72f00287fec3206c7e92cd7cd1a6b3f..79693c0f517f6efdaf611aedcd9cc87bb7f2a120 100644 (file)
--- a/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronTrunkChangeListener.java
+++ b/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronTrunkChangeListener.java
@@ -49,7 +49,6 @@ public class NeutronTrunkChangeListener extends AsyncDataTreeChangeListenerBase<
 
     @Inject
     public NeutronTrunkChangeListener(final DataBroker dataBroker, IInterfaceManager ifMgr) {
-        super();
         this.dataBroker = dataBroker;
         this.ifMgr = ifMgr;
     }

diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStartTask.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStartTask.java
index f2335ab0253335a6158969e62d5f70a3724a4c4d..d7d77a3f15c8bb72968057804fd228bc53d25277 100644 (file)
--- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStartTask.java
+++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStartTask.java
@@ -28,7 +28,6 @@ public class ArpMonitorStartTask implements Callable<List<ListenableFuture<Void>
     public ArpMonitorStartTask(MacEntry macEntry, Long profileId, DataBroker databroker,
         AlivenessMonitorService alivenessManager, OdlInterfaceRpcService interfaceRpc,
         INeutronVpnManager neutronVpnService, IInterfaceManager interfaceManager) {
-        super();
         this.macEntry = macEntry;
         this.arpMonitorProfileId = profileId;
         this.databroker = databroker;
@@ -45,5 +44,4 @@ public class ArpMonitorStartTask implements Callable<List<ListenableFuture<Void>
             interfaceManager);
         return null;
     }
-
 }
\ No newline at end of file

diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStopTask.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStopTask.java
index 3f5559f4793f7b736d450927d246cd6283c0098e..42935a5cc9755d25334c9ea9d313378a6e30330f 100644 (file)
--- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStopTask.java
+++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/ArpMonitorStopTask.java
@@ -35,7 +35,6 @@ public class ArpMonitorStopTask implements Callable<List<ListenableFuture<Void>>
 
     public ArpMonitorStopTask(MacEntry macEntry, DataBroker dataBroker,
         AlivenessMonitorService alivenessManager) {
-        super();
         this.macEntry = macEntry;
         this.dataBroker = dataBroker;
         this.alivenessManager = alivenessManager;

diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java
index d5618abcc19da1b15bff793e2b821f96cfcb13c7..bfe97596860bcb63fb65b112ef397b456a9c74b8 100755 (executable)
--- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java
+++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java
@@ -2211,7 +2211,6 @@ public class VpnInterfaceManager extends AsyncDataTreeChangeListenerBase<VpnInte
         VpnInterface vpnInterface;
 
         UnprocessedVpnInterfaceData(InstanceIdentifier<VpnInterface> identifier, VpnInterface vpnInterface) {
-            super();
             this.identifier = identifier;
             this.vpnInterface = vpnInterface;
         }

diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/arp/responder/ArpResponderHandler.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/arp/responder/ArpResponderHandler.java
index 499b995afa5299c34d98ce476bff86881722df17..27f48c37abd1cc76d46687acbd5c7ed699ff4f18 100644 (file)
--- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/arp/responder/ArpResponderHandler.java
+++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/arp/responder/ArpResponderHandler.java
@@ -57,7 +57,6 @@ public class ArpResponderHandler {
      *
      */
     public ArpResponderHandler(DataBroker dataBroker, IElanService elanService, IInterfaceManager interfaceManager) {
-        super();
         this.dataBroker = dataBroker;
         this.elanService = elanService;
         this.interfaceManager = interfaceManager;

diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkListener.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkListener.java
index 4e1f81953d108385a68745b75640d06871264019..96f49cca2a1f3bffa75835b56708f7b3977cab09 100755 (executable)
--- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkListener.java
+++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkListener.java
@@ -95,7 +95,6 @@ public class InterVpnLinkListener extends AsyncDataTreeChangeListenerBase<InterV
                                 final InterVpnLinkLocator interVpnLinkLocator,
                                 final VpnFootprintService vpnFootprintService,
                                 final VpnOpDataSyncer vpnOpDataSyncer) {
-        super();
         this.dataBroker = dataBroker;
         this.idManager = idManager;
         this.mdsalManager = mdsalManager;

diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkNodeListener.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkNodeListener.java
index 9f13078c974a3f8273c7e0a0e6714dbe470b2069..c6d8facbf82098d82709899a2078ecd22b6dc3be 100644 (file)
--- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkNodeListener.java
+++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkNodeListener.java
@@ -49,7 +49,6 @@ public class InterVpnLinkNodeListener extends AsyncDataTreeChangeListenerBase<No
 
     public InterVpnLinkNodeListener(final DataBroker dataBroker, final IMdsalApiManager mdsalMgr,
                                     final VpnFootprintService vpnFootprintService) {
-        super();
         this.dataBroker = dataBroker;
         this.mdsalManager = mdsalMgr;
         this.vpnFootprintService = vpnFootprintService;

diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkStateListener.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkStateListener.java
index 0a82ee613ece1ad51a5272c8543c1631b6b2f84f..85c3d9d2cb39ec58cd39438ebcbfd735d7cf5295 100644 (file)
--- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkStateListener.java
+++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkStateListener.java
@@ -33,7 +33,6 @@ public class InterVpnLinkStateListener
     private final IVpnLinkService ivpnLinkService;
 
     public InterVpnLinkStateListener(final DataBroker dataBroker, final IVpnLinkService interVpnLinkService) {
-        super();
         this.dataBroker = dataBroker;
         this.ivpnLinkService = interVpnLinkService;
     }