Quote param values to force them to be strings 16/87716/1
authorJamo Luhrsen <jluhrsen@gmail.com>
Fri, 14 Feb 2020 21:15:16 +0000 (13:15 -0800)
committerJamo Luhrsen <jluhrsen@gmail.com>
Fri, 14 Feb 2020 21:15:16 +0000 (13:15 -0800)
The jjb-deploy gerrit keyword that triggers the builder-jjb-deploy-job
is failing when passing a CSIT job as an argument. It was working with
another non-csit job (I tried a mvn-merge job). After some debugging,
I saw that some python lib (ElementTree.py) was throwing an exception
because a value was seen as an Int and not a string. It turned out to
be coming from our vm_x_count parameter in our csit templates. From
what I can tell, everything is now a string for those. My only guess
to why this used to work before is that some lib version has changed
and now more strict.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: If17d8e0f67e1c96f0473acd2b68ddf3aaf40d9f7

jjb/integration/integration-templates.yaml

index f0165cf611004a9262552fffda392c3c34ff14b8..6ae692419733cc233d3a8b3dcbd5dd07ab3ed016 100644 (file)
           use-features-boot: 'True'
           elasticsearch-attribute: '{elasticsearch-attribute}'
       - integration-stack-2-type:
-          vm_0_count: 1
+          vm_0_count: '1'
           vm_0_flavor: '{odl_system_flavor}'
           vm_0_image: '{odl_system_image}'
           vm_1_count: '{tools_system_count}'
           use-features-boot: 'True'
           elasticsearch-attribute: '{elasticsearch-attribute}'
       - integration-stack-2-type:
-          vm_0_count: 1
+          vm_0_count: '1'
           vm_0_flavor: '{odl_system_flavor}'
           vm_0_image: '{odl_system_image}'
           vm_1_count: '{tools_system_count}'
           use-features-boot: 'True'
           elasticsearch-attribute: '{elasticsearch-attribute}'
       - integration-stack-2-type:
-          vm_0_count: 1
+          vm_0_count: '1'
           vm_0_flavor: '{odl_system_flavor}'
           vm_0_image: '{odl_system_image}'
           vm_1_count: '{tools_system_count}'
           use-features-boot: 'True'
           elasticsearch-attribute: '{elasticsearch-attribute}'
       - integration-stack-2-type:
-          vm_0_count: 3
+          vm_0_count: '3'
           vm_0_flavor: '{odl_system_flavor}'
           vm_0_image: '{odl_system_image}'
           vm_1_count: '{tools_system_count}'
           use-features-boot: 'True'
           elasticsearch-attribute: '{elasticsearch-attribute}'
       - integration-stack-2-type:
-          vm_0_count: 3
+          vm_0_count: '3'
           vm_0_flavor: '{odl_system_flavor}'
           vm_0_image: '{odl_system_image}'
           vm_1_count: '{tools_system_count}'
           use-features-boot: 'True'
           elasticsearch-attribute: '{elasticsearch-attribute}'
       - integration-stack-2-type:
-          vm_0_count: 3
+          vm_0_count: '3'
           vm_0_flavor: '{odl_system_flavor}'
           vm_0_image: '{odl_system_image}'
           vm_1_count: '{tools_system_count}'
           use-features-boot: 'True'
           elasticsearch-attribute: '{elasticsearch-attribute}'
       - integration-stack-2-type:
-          vm_0_count: 3
+          vm_0_count: '3'
           vm_0_flavor: '{odl_system_flavor}'
           vm_0_image: '{odl_system_image}'
           vm_1_count: '{docker_system_count}'