Use ArrayList.sort() instead of Collections.sort() 63/76963/1
authorRobert Varga <robert.varga@pantheon.tech>
Sat, 13 Oct 2018 08:38:32 +0000 (10:38 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Sat, 13 Oct 2018 09:01:35 +0000 (11:01 +0200)
We do not need Collections, as we have Java 8 and hence can
directly use List.sort(). This has the side-effect of
short-circuiting to ArrayList's implementation.

Change-Id: If978265242275014c586fcf92d96d5ba09bb7bca
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 0da0d185e5c0720029b5cab2d1c614e96493431e)

binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/BuilderTemplate.xtend

index 325b6a0e5c88ff6819d3cdbb134aff0b9c1a31fa..c156bd0f24f2ba07598e812fd8cbb8b3bfe3c915 100644 (file)
@@ -507,11 +507,7 @@ class BuilderTemplate extends BaseTemplate {
             «val keyType = type.getKey»
             «IF isList && keyType !== null»
                 «val keyProps = new ArrayList((keyType as GeneratedTransferObject).properties)»
-                «Collections.sort(keyProps,
-                    [ p1, p2 |
-                        return p1.name.compareTo(p2.name)
-                    ])
-                »
+                «keyProps.sort([ p1, p2 | return p1.name.compareTo(p2.name) ])»
                 «FOR field : keyProps»
                     «removeProperty(allProps, field.name)»
                 «ENDFOR»