Use {Key,Trust}ManagerFactory.getDefaultAlgorithm() 25/104425/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 16 Feb 2023 12:24:22 +0000 (13:24 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 16 Feb 2023 12:24:22 +0000 (13:24 +0100)
Do not much with properties and magix strings -- use proper method to
acquire the algorithm.

Change-Id: I91b6a4f8fdaab1abf9bbaa665957f92d96e59663
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
aaa-cert/src/main/java/org/opendaylight/aaa/cert/impl/CertificateManagerService.java

index d08f5691316f5f626854a60d26a05e2e97d3959f..1303e24bf3a589f4c649a4b6b34c1fe55bbfe360 100644 (file)
@@ -13,7 +13,6 @@ import java.security.KeyManagementException;
 import java.security.KeyStore;
 import java.security.KeyStoreException;
 import java.security.NoSuchAlgorithmException;
-import java.security.Security;
 import java.security.UnrecoverableKeyException;
 import javax.net.ssl.KeyManagerFactory;
 import javax.net.ssl.SSLContext;
@@ -145,16 +144,12 @@ public class CertificateManagerService implements ICertificateManager, AutoClose
 
     @Override
     public SSLContext getServerContext() {
-        String algorithm = Security.getProperty("ssl.KeyManagerFactory.algorithm");
-        if (algorithm == null) {
-            algorithm = "SunX509";
-        }
         SSLContext serverContext = null;
         try {
-            KeyManagerFactory kmf = KeyManagerFactory.getInstance(algorithm);
+            KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());
             kmf.init(aaaCertProvider.getODLKeyStore(),
                     aaaCertProvider.getOdlKeyStoreInfo().getStorePassword().toCharArray());
-            TrustManagerFactory tmf = TrustManagerFactory.getInstance(algorithm);
+            TrustManagerFactory tmf = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm());
             tmf.init(aaaCertProvider.getTrustKeyStore());
 
             serverContext = SSLContext.getInstance("TLS");