UTIL Code Clean Up

Fix sonar complains, naming convention, declare final
method/classes, etc..

Change-Id: Ice7cc8b054fa7200842da970d2d1c3eae2eac8e4
Signed-off-by: Claudio <cgaspari@cisco.com>

diff --git a/util/src/test/java/org/opendaylight/protocol/util/ByteArrayTest.java b/util/src/test/java/org/opendaylight/protocol/util/ByteArrayTest.java
index 5fe3b5f28cb66b4e6409e4f7865e6f5795ebe13b..0cea42d6823c8f933664aeeecd944af62eab8c01 100644 (file)
--- a/util/src/test/java/org/opendaylight/protocol/util/ByteArrayTest.java
+++ b/util/src/test/java/org/opendaylight/protocol/util/ByteArrayTest.java
@@ -28,7 +28,7 @@ import org.junit.Test;
 
 public class ByteArrayTest {
 
-    byte[] before = new byte[] { 15, 28, 4, 6, 9, 10 };
+    final byte[] before = new byte[] { 15, 28, 4, 6, 9, 10 };
 
     @Test
     public void testReadBytes() {
@@ -132,7 +132,7 @@ public class ByteArrayTest {
     }
 
     private final byte[] inBytes = { (byte) 0x03, (byte) 0xFF, (byte) 0x01, (byte) 0x80 };
-    BitSet inBitSet = new BitSet();
+    final BitSet inBitSet = new BitSet();
 
     @Before
     public void generateBitSet() {

diff --git a/util/src/test/java/org/opendaylight/protocol/util/ByteBufWriteUtilTest.java b/util/src/test/java/org/opendaylight/protocol/util/ByteBufWriteUtilTest.java
index ed6a3d513696ec1e3d63482c73c59e3773217016..e6e9b13c9ea570c21808a8c02f8df9283185b9b0 100644 (file)
--- a/util/src/test/java/org/opendaylight/protocol/util/ByteBufWriteUtilTest.java
+++ b/util/src/test/java/org/opendaylight/protocol/util/ByteBufWriteUtilTest.java
@@ -242,7 +242,7 @@ public class ByteBufWriteUtilTest {
         c.setAccessible(true);
         try {
             c.newInstance();
-        } catch (InvocationTargetException e) {
+        } catch (final InvocationTargetException e) {
             throw e.getCause();
         }
     }

diff --git a/util/src/test/java/org/opendaylight/protocol/util/PCEPHexDumpParserTest.java b/util/src/test/java/org/opendaylight/protocol/util/PCEPHexDumpParserTest.java
index 6f2a044138591e5918a87b950e786a7d9f73c94d..8262e9fe5698f07c61a0a765e905a489080161f0 100644 (file)
--- a/util/src/test/java/org/opendaylight/protocol/util/PCEPHexDumpParserTest.java
+++ b/util/src/test/java/org/opendaylight/protocol/util/PCEPHexDumpParserTest.java
@@ -49,7 +49,7 @@ public class PCEPHexDumpParserTest {
         c.setAccessible(true);
         try {
             c.newInstance();
-        } catch (InvocationTargetException e) {
+        } catch (final InvocationTargetException e) {
             throw e.getCause();
         }
     }

diff --git a/util/src/test/java/org/opendaylight/protocol/util/StatisticsUtilTest.java b/util/src/test/java/org/opendaylight/protocol/util/StatisticsUtilTest.java
index 682e69709ee8114ca2d9bf89f2f318dd108ace58..d3aa348bacdcbb842bafca98a180a59b3f970ff6 100644 (file)
--- a/util/src/test/java/org/opendaylight/protocol/util/StatisticsUtilTest.java
+++ b/util/src/test/java/org/opendaylight/protocol/util/StatisticsUtilTest.java
@@ -37,7 +37,7 @@ public class StatisticsUtilTest {
         c.setAccessible(true);
         try {
             c.newInstance();
-        } catch (InvocationTargetException e) {
+        } catch (final InvocationTargetException e) {
             throw e.getCause();
         }
     }

diff --git a/util/src/test/java/org/opendaylight/protocol/util/ValuesTest.java b/util/src/test/java/org/opendaylight/protocol/util/ValuesTest.java
index a911dfff87e1d69b5275409d161462c6fb654a16..0f3a91f3b6499e6f138403469fcae9b2b3149ac0 100644 (file)
--- a/util/src/test/java/org/opendaylight/protocol/util/ValuesTest.java
+++ b/util/src/test/java/org/opendaylight/protocol/util/ValuesTest.java
@@ -20,7 +20,7 @@ public class ValuesTest {
         c.setAccessible(true);
         try {
             c.newInstance();
-        } catch (InvocationTargetException e) {
+        } catch (final InvocationTargetException e) {
             throw e.getCause();
         }
     }