Bump SpotBugs 4.8.5

https://github.com/spotbugs/spotbugs/releases/tag/4.8.4
https://github.com/spotbugs/spotbugs/releases/tag/4.8.5
https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-4.8.4.0
https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-4.8.5.0

Change-Id: Ib06115d936ef026013af499cffb9462a15053def
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/odlparent/pom.xml b/odlparent/pom.xml
index 68aa54ca66dbbaf97ca9295d7664cd1b54cd0118..10a7bc7260cac048dbcc05194457853f491e735a 100644 (file)
--- a/odlparent/pom.xml
+++ b/odlparent/pom.xml
@@ -355,7 +355,7 @@
       <dependency>
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-annotations</artifactId>
-        <version>4.8.3</version>
+        <version>4.8.5</version>
         <!-- Contains retention=RUNTIME annotations, which are not really needed -->
         <optional>true</optional>
         <exclusions>
@@ -1132,12 +1132,12 @@
         <plugin>
           <groupId>com.github.spotbugs</groupId>
           <artifactId>spotbugs-maven-plugin</artifactId>
-          <version>4.8.3.1</version>
+          <version>4.8.5.0</version>
           <dependencies>
             <dependency>
               <groupId>com.github.spotbugs</groupId>
               <artifactId>spotbugs</artifactId>
-              <version>4.8.3</version>
+              <version>4.8.5</version>
             </dependency>
             <dependency>
               <groupId>org.opendaylight.odlparent</groupId>

diff --git a/spotbugs/src/main/resources/spotbugs-exclude.xml b/spotbugs/src/main/resources/spotbugs-exclude.xml
index 27053a554397a354d26643c366547aefa8d1b94d..82aada5ad59a31785bf10fd5643481165a2c4966 100644 (file)
--- a/spotbugs/src/main/resources/spotbugs-exclude.xml
+++ b/spotbugs/src/main/resources/spotbugs-exclude.xml
@@ -65,6 +65,23 @@
            "clever use of a private constructor".
       -->
       <Bug pattern="CT_CONSTRUCTOR_THROW"/>
+
+      <!--
+           https://github.com/spotbugs/spotbugs/issues/2932. Causes a ton of false positives with eagerly-instantiated
+           singletons.
+      -->
+      <Bug pattern="SING_SINGLETON_GETTER_NOT_SYNCHRONIZED"/>
+
+      <!--
+           https://github.com/spotbugs/spotbugs/issues/2934. The logic identifying singletons seems to be over-eager,
+           assuming that a class is meant to be a singleton when there even is a single singleton value.
+      -->
+      <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
+
+      <!--
+           https://github.com/spotbugs/spotbugs/issues/2933. Causes false positives with readResolve()d singletons.
+      -->
+      <Bug pattern="SING_SINGLETON_IMPLEMENTS_SERIALIZABLE"/>
     </Or>
   </Match>
 </FindBugsFilter>