Disambiguate TransactionInvokerImplTest assertion 77/86277/8
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 6 Dec 2019 19:56:47 +0000 (20:56 +0100)
committerStephen Kitt <skitt@redhat.com>
Tue, 7 Jan 2020 16:04:52 +0000 (16:04 +0000)
Do not reuse mock objects for transactions, as that means we are
asserting that one them is replayed, except that we want to be
asserting that the last transaction was replayed.

JIRA: OVSDB-428
Change-Id: If7bf37edb46cd2ce155325e257cf1a891f8b2bf5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/transactions/md/TransactionInvokerImplTest.java

index 2b7ca7d1503b9253bbf40359f7ee093df95eee7b..1196679a255c7fcd60ce2d035989ac48e00c1757 100644 (file)
@@ -92,8 +92,8 @@ public class TransactionInvokerImplTest {
 
         final Map<ReadWriteTransaction,TransactionCommand> transactionToCommand = new HashMap<>();
         final TransactionCommand txCommand = mock(TransactionCommand.class);
-        transactionToCommand.put(tx1, txCommand);
-        transactionToCommand.put(tx2, txCommand);
+        transactionToCommand.put(tx1, mock(TransactionCommand.class));
+        transactionToCommand.put(tx2, mock(TransactionCommand.class));
         transactionToCommand.put(transaction, txCommand);
 
         final TransactionInvokerImpl invoker = new TransactionInvokerImpl(db, pendingTransactions,