Remove an unneeded synchronized block

updateStats() is already synchronized, there is no need to synchronize
further.

Change-Id: I961a5a40d75e376e216e903fbd3a28cfaa4dab00
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/TopologyStatsProviderImpl.java b/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/TopologyStatsProviderImpl.java
index c88801a4edc1f8288ed6c0519a372e1c8f451817..960685439be373eacd5c906e27bd26fe012c8edd 100644 (file)
--- a/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/TopologyStatsProviderImpl.java
+++ b/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/TopologyStatsProviderImpl.java
@@ -74,15 +74,12 @@ public final class TopologyStatsProviderImpl implements TopologySessionStatsRegi
             final ScheduledExecutorService scheduler) {
         this.dataBroker = requireNonNull(dataBroker);
         LOG.info("Initializing TopologyStatsProvider service.");
-        final TimerTask task = new TimerTask() {
+        scheduleTask = scheduler.scheduleAtFixedRate(new TimerTask() {
             @Override
             public void run() {
-                synchronized (TopologyStatsProviderImpl.this) {
-                    updateStats();
-                }
+                updateStats();
             }
-        };
-        scheduleTask = scheduler.scheduleAtFixedRate(task, 0, updateIntervalSeconds, TimeUnit.SECONDS);
+        }, 0, updateIntervalSeconds, TimeUnit.SECONDS);
     }
 
     @Override
@@ -133,7 +130,7 @@ public final class TopologyStatsProviderImpl implements TopologySessionStatsRegi
     }
 
     @SuppressWarnings("checkstyle:IllegalCatch")
-    public synchronized void updateStats() {
+    private synchronized void updateStats() {
         final TransactionChain chain = accessChain();
         if (chain == null) {
             // Already closed, do not bother