Sonar issues fix

- removed unused parameter
- reordered modifiers
- removed redundant modifiers

Change-Id: Ia0a23e6ec9987316026c23674f3a5f1d517ef0ae
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

diff --git a/bgp/rib-impl/src/main/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModule.java b/bgp/rib-impl/src/main/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModule.java
index 28cc1018285603285b53b0054299079af135430b..3e8893ac07f6b60a5206bcad857e524c3946d689 100644 (file)
--- a/bgp/rib-impl/src/main/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModule.java
+++ b/bgp/rib-impl/src/main/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModule.java
@@ -129,7 +129,7 @@ public final class BGPPeerModule extends org.opendaylight.controller.config.yang
 
         // Initiate connection
         if(getInitiateConnection()) {
-            final Future<Void> cf = initiateConnection(createAddress(), password, remoteAs, getPeerRegistryBackwards());
+            final Future<Void> cf = initiateConnection(createAddress(), password, getPeerRegistryBackwards());
             return new CloseableNoEx() {
                 @Override
                 public void close() {
@@ -199,7 +199,7 @@ public final class BGPPeerModule extends org.opendaylight.controller.config.yang
         return new IpAddress(host.getIpv6Address());
     }
 
-    private io.netty.util.concurrent.Future<Void> initiateConnection(final InetSocketAddress address, final String password, final AsNumber remoteAs, final BGPPeerRegistry registry) {
+    private io.netty.util.concurrent.Future<Void> initiateConnection(final InetSocketAddress address, final String password, final BGPPeerRegistry registry) {
         final KeyMapping keys;
         if (password != null) {
             keys = new KeyMapping();

diff --git a/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/BasePCEPSessionProposalFactory.java b/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/BasePCEPSessionProposalFactory.java
index dc187578d51e063f05338951a799b8f41346d0fb..5e8cba33cf216a656feeb1f2a71ebbd998454514 100644 (file)
--- a/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/BasePCEPSessionProposalFactory.java
+++ b/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/BasePCEPSessionProposalFactory.java
@@ -16,7 +16,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.typ
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.OpenBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.open.object.open.TlvsBuilder;
 
-final public class BasePCEPSessionProposalFactory implements PCEPSessionProposalFactory {
+public final class BasePCEPSessionProposalFactory implements PCEPSessionProposalFactory {
 
     private final int keepAlive, deadTimer;
     private final List<PCEPCapability> capabilities;
@@ -34,7 +34,7 @@ final public class BasePCEPSessionProposalFactory implements PCEPSessionProposal
     }
 
     @Override
-    public final Open getSessionProposal(final InetSocketAddress address, final int sessionId) {
+    public Open getSessionProposal(final InetSocketAddress address, final int sessionId) {
         return getSessionProposal(address, sessionId, null);
     }
 
@@ -58,11 +58,11 @@ final public class BasePCEPSessionProposalFactory implements PCEPSessionProposal
         return oBuilder.setTlvs(builder.build()).build();
     }
 
-    public final int getKeepAlive() {
+    public int getKeepAlive() {
         return this.keepAlive;
     }
 
-    public final int getDeadTimer() {
+    public int getDeadTimer() {
         return this.deadTimer;
     }