Include Routes Node when generating route path 54/77054/1
authorClaudio D. Gasparini <claudio.gasparini@pantheon.tech>
Wed, 17 Oct 2018 06:40:04 +0000 (08:40 +0200)
committerClaudio David Gasparini <claudio.gasparini@pantheon.tech>
Wed, 17 Oct 2018 08:13:57 +0000 (08:13 +0000)
Given that it is common node, therefore
duplicate code can removed and is easier for user.

Change-Id: I5babaf17c9b70258aa7772e7cd5c443dcad9a442
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
19 files changed:
bgp/extensions/evpn/src/test/java/org/opendaylight/protocol/bgp/evpn/impl/EvpnRibSupportTest.java
bgp/extensions/flowspec/src/test/java/org/opendaylight/protocol/bgp/flowspec/FlowspecIpv4RIBSupportTest.java
bgp/extensions/flowspec/src/test/java/org/opendaylight/protocol/bgp/flowspec/FlowspecIpv6RIBSupportTest.java
bgp/extensions/flowspec/src/test/java/org/opendaylight/protocol/bgp/flowspec/FlowspecL3vpnIpv4RIBSupportTest.java
bgp/extensions/flowspec/src/test/java/org/opendaylight/protocol/bgp/flowspec/FlowspecL3vpnIpv6RIBSupportTest.java
bgp/extensions/inet/src/test/java/org/opendaylight/protocol/bgp/inet/IPv4RIBSupportTest.java
bgp/extensions/inet/src/test/java/org/opendaylight/protocol/bgp/inet/IPv6RIBSupportTest.java
bgp/extensions/l3vpn/src/test/java/org/opendaylight/protocol/bgp/l3vpn/mcast/L3vpnMcastIpv4RIBSupportTest.java
bgp/extensions/l3vpn/src/test/java/org/opendaylight/protocol/bgp/l3vpn/mcast/L3vpnMcastIpv6RIBSupportTest.java
bgp/extensions/l3vpn/src/test/java/org/opendaylight/protocol/bgp/l3vpn/unicast/ipv4/VpnIpv4RIBSupportTest.java
bgp/extensions/l3vpn/src/test/java/org/opendaylight/protocol/bgp/l3vpn/unicast/ipv6/VpnIpv6RIBSupportTest.java
bgp/extensions/labeled-unicast/src/test/java/org/opendaylight/protocol/bgp/labeled/unicast/LabeledUnicastIpv4RIBSupportTest.java
bgp/extensions/labeled-unicast/src/test/java/org/opendaylight/protocol/bgp/labeled/unicast/LabeledUnicastIpv6RIBSupportTest.java
bgp/extensions/linkstate/src/test/java/org/opendaylight/protocol/bgp/linkstate/LinkstateRIBSupportTest.java
bgp/extensions/mvpn/src/test/java/org/opendaylight/protocol/bgp/mvpn/impl/MvpnIpv4RIBSupportTest.java
bgp/extensions/mvpn/src/test/java/org/opendaylight/protocol/bgp/mvpn/impl/MvpnIpv6RIBSupportTest.java
bgp/extensions/route-target/src/test/java/org/opendaylight/protocol/bgp/route/targetcontrain/impl/RouteTargetConstrainRIBSupportTest.java
bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/AbstractRIBSupport.java
bgp/rib-spi/src/test/java/org/opendaylight/protocol/bgp/rib/spi/RIBSupportTest.java

index d25b33a60e8cb0a920e101c80b707b8dc7513912..2c8e524eb25bc026e1a6e3e5cd207fa4e1b710ad 100644 (file)
@@ -157,7 +157,7 @@ public final class EvpnRibSupportTest extends AbstractRIBSupportTest<EvpnRoutesC
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(EVPN_ROUTES);
         assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 74d5720f5d8cb6038b406f24e0325f54c1180411..3a1581e363e77edd24dfbaadaf7e99a08cf300b4 100644 (file)
@@ -149,7 +149,7 @@ public class FlowspecIpv4RIBSupportTest extends AbstractRIBSupportTest<FlowspecR
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(this.routes);
         assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 0ed03c0780844cefd4d3ce19fe046f1b163842a8..1b8cf4c35c3e6d96050310e59ecb484b963192b2 100644 (file)
@@ -149,7 +149,7 @@ public class FlowspecIpv6RIBSupportTest extends AbstractRIBSupportTest<FlowspecI
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(this.routes);
         assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 6293c83ce6b573da8130cd861b970f6069d3c0b0..bb068d73d69d4220e03b44328e961ab9ea5681ac 100644 (file)
@@ -148,7 +148,7 @@ public class FlowspecL3vpnIpv4RIBSupportTest extends AbstractRIBSupportTest<Flow
                 = createRouteNIWP(new FlowspecL3vpnIpv4RoutesBuilder()
                 .setFlowspecL3vpnRoute(Collections.singletonList(ROUTE)).build());
         assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 7ee770a097b77428529d0467a45d431920e851a7..0b4525474000df75b71b80403b86cade65b7996a 100644 (file)
@@ -151,7 +151,7 @@ public class FlowspecL3vpnIpv6RIBSupportTest extends AbstractRIBSupportTest<Flow
                 = createRouteNIWP(new FlowspecL3vpnIpv6RoutesBuilder()
                 .setFlowspecL3vpnRoute(Collections.singletonList(ROUTE)).build());
         Assert.assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 6b53a896b9c73927ab86ecad21b0f5dc3a59d511..3c5712ecbd43289677ef65f7aafdd6359a9d00f7 100644 (file)
@@ -138,8 +138,7 @@ public final class IPv4RIBSupportTest extends AbstractRIBSupportTest<Ipv4RoutesC
     @Test
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(ROUTES);
-        assertEquals(getRoutePath().node(prefixNii), this.ribSupport.routePath(getTablePath()
-                .node(Routes.QNAME), prefixNii));
+        assertEquals(getRoutePath().node(prefixNii), this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index ffe084c92d36a89352011fc65053eaa016237bd0..6daa540c1241ff7a369aa6edc0458e6315b29da4 100644 (file)
@@ -139,7 +139,7 @@ public final class IPv6RIBSupportTest extends AbstractRIBSupportTest<Ipv6RoutesC
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(ROUTES);
         assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 563e82f0be3ccdd6cff4bbd2a21e52d6db0961d7..39e6812205a9bd7fe80ced9d3dc4d08519aecac0 100644 (file)
@@ -154,7 +154,7 @@ public class L3vpnMcastIpv4RIBSupportTest extends AbstractRIBSupportTest<L3vpnMc
     public void testRoutePath() {
         final YangInstanceIdentifier.NodeIdentifierWithPredicates prefixNii = createRouteNIWP(MCAST_L3VPN_ROUTES);
         final YangInstanceIdentifier expected = getRoutePath().node(prefixNii);
-        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii);
+        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath(), prefixNii);
         assertEquals(expected, actual);
     }
 
index 2c23197832d595a8a9b2571faa16c90cd5d44ed5..85dda133f13ec7c2d568d8b48025b4b01150b811 100644 (file)
@@ -154,7 +154,7 @@ public class L3vpnMcastIpv6RIBSupportTest extends AbstractRIBSupportTest<L3vpnMc
     public void testRoutePath() {
         final YangInstanceIdentifier.NodeIdentifierWithPredicates prefixNii = createRouteNIWP(MCAST_L3VPN_ROUTES);
         final YangInstanceIdentifier expected = getRoutePath().node(prefixNii);
-        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii);
+        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath(), prefixNii);
         assertEquals(expected, actual);
     }
 
index a52504499f0e8c4c04e1facd8ac5b0dc42a54862..d3adfa4226798e3634302af9da953bd6dfea12bb 100644 (file)
@@ -131,7 +131,7 @@ public class VpnIpv4RIBSupportTest extends AbstractRIBSupportTest<VpnIpv4RoutesC
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(ROUTES);
         assertEquals(getRoutePath().node(prefixNii), ribSupport
-                .routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                .routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 87de1075049e73c53eb03c2b145972e564bd45b8..5f5b7166ef1a81e33bbb1b9a6770b615a53a49ff 100644 (file)
@@ -130,7 +130,7 @@ public class VpnIpv6RIBSupportTest extends AbstractRIBSupportTest<VpnIpv6RoutesC
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(ROUTES);
         assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index c958521144066f00f15b2744fecc334eefbdbfe6..9a7d693df1843df01b1fa101b6ef6ee4c79ab7ed 100644 (file)
@@ -162,7 +162,7 @@ public class LabeledUnicastIpv4RIBSupportTest extends AbstractRIBSupportTest<Lab
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(ROUTES);
         assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 89443b24eca067435d667256a74d644b630494ec..987adefac790b29064a991e94a4218cf521dbb66 100644 (file)
@@ -160,7 +160,7 @@ public class LabeledUnicastIpv6RIBSupportTest extends AbstractRIBSupportTest<Lab
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(ROUTES);
         assertEquals(getRoutePath().node(prefixNii),
-                this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+                this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index eb1091e0aad304f01a841ac98b29e4fb9050c013..7858d17898641663c51b2153e0caa4efa75f2297 100644 (file)
@@ -178,7 +178,7 @@ public final class LinkstateRIBSupportTest extends AbstractRIBSupportTest<Linkst
     @Test
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(ROUTES);
-        Assert.assertEquals(getRoutePath().node(prefixNii), this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii));
+        Assert.assertEquals(getRoutePath().node(prefixNii), this.ribSupport.routePath(getTablePath(), prefixNii));
     }
 
     @Test
index 6952a53815926e6199341766f1cce789ce59c142..5d61a6303fe8273a21e20024bff77166331a07aa 100644 (file)
@@ -154,7 +154,7 @@ public class MvpnIpv4RIBSupportTest extends AbstractRIBSupportTest<MvpnRoutesIpv
     public void testRoutePath() {
         final YangInstanceIdentifier.NodeIdentifierWithPredicates prefixNii = createRouteNIWP(MVPN_ROUTES);
         final YangInstanceIdentifier expected = getRoutePath().node(prefixNii);
-        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii);
+        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath(), prefixNii);
         assertEquals(expected, actual);
     }
 
index 972b1af7e660df7e95b36868ffadc02a28c49b9c..2fbb9a97cd8fde45488f604ee648dedef1cdadb9 100644 (file)
@@ -156,7 +156,7 @@ public final class MvpnIpv6RIBSupportTest extends AbstractRIBSupportTest<MvpnRou
     public void testRoutePath() {
         final NodeIdentifierWithPredicates prefixNii = createRouteNIWP(MVPN_ROUTES);
         final YangInstanceIdentifier expected = getRoutePath().node(prefixNii);
-        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii);
+        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath(), prefixNii);
         assertEquals(expected, actual);
     }
 
index 4d54d3555de398635ca658665d1d648f7c80753f..d69dd8391b21db2f1ba3778e0d468f90fdff072c 100644 (file)
@@ -168,7 +168,7 @@ public class RouteTargetConstrainRIBSupportTest extends AbstractRIBSupportTest<R
     public void testRoutePath() {
         final YangInstanceIdentifier.NodeIdentifierWithPredicates prefixNii = createRouteNIWP(RT_ROUTES);
         final YangInstanceIdentifier expected = getRoutePath().node(prefixNii);
-        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath().node(Routes.QNAME), prefixNii);
+        final YangInstanceIdentifier actual = this.ribSupport.routePath(getTablePath(), prefixNii);
         assertEquals(expected, actual);
     }
 
index 6bce72be11906be755f0734a3a7478af9d97ffad..6ee13014416a80dfea3ad4413cdf572a74766311 100644 (file)
@@ -379,7 +379,7 @@ public abstract class AbstractRIBSupport<
     @Override
     public final YangInstanceIdentifier routePath(
             final YangInstanceIdentifier routesTablePaths, final PathArgument routeId) {
-        return routesYangInstanceIdentifier(routesTablePaths).node(routeId);
+        return routesYangInstanceIdentifier(routesTablePaths.node(Routes.QNAME)).node(routeId);
     }
 
     @Override
index e27733e86f35f9e7ae94595134f0001e0b65ba22..ef803b9cbe5095d4fd7b432701575eaafb021cb4 100644 (file)
@@ -215,7 +215,7 @@ public class RIBSupportTest extends AbstractConcurrentDataBrokerTest {
     public void routePath() {
         assertEquals(LOC_RIB_TARGET.node(ROUTES_IDENTIFIER)
                         .node(Ipv4Routes.QNAME).node(Ipv4Route.QNAME).node(PREFIX_NII),
-                this.ribSupportTestImp.routePath(LOC_RIB_TARGET.node(Routes.QNAME), PREFIX_NII));
+                this.ribSupportTestImp.routePath(LOC_RIB_TARGET, PREFIX_NII));
     }
 
     @Test